chore(lib/babe/inherents): remove duplicate types #3668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axaysagathiya
requested review from
edwardmack,
timwu20,
EclesioMeloJunior,
jimjbrettj,
kishansagathiya,
dimartiro and
kanishkatn
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## issue-3507 #3668 +/- ##
==============================================
- Coverage 50.09% 50.07% -0.03%
==============================================
Files 255 255
Lines 30859 30834 -25
==============================================
- Hits 15459 15439 -20
Misses 13791 13791
+ Partials 1609 1604 -5 |
kishansagathiya
approved these changes
Jan 8, 2024
timwu20
approved these changes
Jan 8, 2024
dimartiro
approved these changes
Jan 12, 2024
axaysagathiya
added a commit
that referenced
this pull request
Jan 16, 2024
…verseer (#3532) - Implemented functionality to handle a statement message coming to the candidate backing subsystem - StatementMessage represents a validator's assessment of a specific candidate. - on receiving a statement message, we import a statement into the statement table and dispatch `Backed` notifications and misbehaviours as a result of importing a statement. - if the statement is seconded, the committed candidate receipt will be fetched from the statement table. Attesting data will be generated and stored to retry validation with other backing validators if a validator does not provide a PoV. - if the statement is valid, the validator index will be stored in existing attesting data. It will be checked whether the backing job is already running with the current validator. If not, the backing job will be started. - and then validation work will be kicked off. - added some overseer messages for other subsystems as well, such as provisioner, candidate validation, and statement distribution in `dot/parachain/types/overseer_messages.go` - implemented `Misbehaviour` enum using the interface (#3601) - removed duplicate parachain types from `lib/babe/inherents` (#3668) - implemented ExecutorParams varying datatype slice (partially implements #3544)
kishansagathiya
pushed a commit
that referenced
this pull request
Jan 23, 2024
…verseer (#3532) - Implemented functionality to handle a statement message coming to the candidate backing subsystem - StatementMessage represents a validator's assessment of a specific candidate. - on receiving a statement message, we import a statement into the statement table and dispatch `Backed` notifications and misbehaviours as a result of importing a statement. - if the statement is seconded, the committed candidate receipt will be fetched from the statement table. Attesting data will be generated and stored to retry validation with other backing validators if a validator does not provide a PoV. - if the statement is valid, the validator index will be stored in existing attesting data. It will be checked whether the backing job is already running with the current validator. If not, the backing job will be started. - and then validation work will be kicked off. - added some overseer messages for other subsystems as well, such as provisioner, candidate validation, and statement distribution in `dot/parachain/types/overseer_messages.go` - implemented `Misbehaviour` enum using the interface (#3601) - removed duplicate parachain types from `lib/babe/inherents` (#3668) - implemented ExecutorParams varying datatype slice (partially implements #3544)
kishansagathiya
pushed a commit
that referenced
this pull request
Jan 24, 2024
…verseer (#3532) - Implemented functionality to handle a statement message coming to the candidate backing subsystem - StatementMessage represents a validator's assessment of a specific candidate. - on receiving a statement message, we import a statement into the statement table and dispatch `Backed` notifications and misbehaviours as a result of importing a statement. - if the statement is seconded, the committed candidate receipt will be fetched from the statement table. Attesting data will be generated and stored to retry validation with other backing validators if a validator does not provide a PoV. - if the statement is valid, the validator index will be stored in existing attesting data. It will be checked whether the backing job is already running with the current validator. If not, the backing job will be started. - and then validation work will be kicked off. - added some overseer messages for other subsystems as well, such as provisioner, candidate validation, and statement distribution in `dot/parachain/types/overseer_messages.go` - implemented `Misbehaviour` enum using the interface (#3601) - removed duplicate parachain types from `lib/babe/inherents` (#3668) - implemented ExecutorParams varying datatype slice (partially implements #3544)
timwu20
pushed a commit
that referenced
this pull request
Jun 15, 2024
…verseer (#3532) - Implemented functionality to handle a statement message coming to the candidate backing subsystem - StatementMessage represents a validator's assessment of a specific candidate. - on receiving a statement message, we import a statement into the statement table and dispatch `Backed` notifications and misbehaviours as a result of importing a statement. - if the statement is seconded, the committed candidate receipt will be fetched from the statement table. Attesting data will be generated and stored to retry validation with other backing validators if a validator does not provide a PoV. - if the statement is valid, the validator index will be stored in existing attesting data. It will be checked whether the backing job is already running with the current validator. If not, the backing job will be started. - and then validation work will be kicked off. - added some overseer messages for other subsystems as well, such as provisioner, candidate validation, and statement distribution in `dot/parachain/types/overseer_messages.go` - implemented `Misbehaviour` enum using the interface (#3601) - removed duplicate parachain types from `lib/babe/inherents` (#3668) - implemented ExecutorParams varying datatype slice (partially implements #3544)
timwu20
pushed a commit
that referenced
this pull request
Jun 17, 2024
…verseer (#3532) - Implemented functionality to handle a statement message coming to the candidate backing subsystem - StatementMessage represents a validator's assessment of a specific candidate. - on receiving a statement message, we import a statement into the statement table and dispatch `Backed` notifications and misbehaviours as a result of importing a statement. - if the statement is seconded, the committed candidate receipt will be fetched from the statement table. Attesting data will be generated and stored to retry validation with other backing validators if a validator does not provide a PoV. - if the statement is valid, the validator index will be stored in existing attesting data. It will be checked whether the backing job is already running with the current validator. If not, the backing job will be started. - and then validation work will be kicked off. - added some overseer messages for other subsystems as well, such as provisioner, candidate validation, and statement distribution in `dot/parachain/types/overseer_messages.go` - implemented `Misbehaviour` enum using the interface (#3601) - removed duplicate parachain types from `lib/babe/inherents` (#3668) - implemented ExecutorParams varying datatype slice (partially implements #3544)
timwu20
pushed a commit
that referenced
this pull request
Jun 20, 2024
…verseer (#3532) - Implemented functionality to handle a statement message coming to the candidate backing subsystem - StatementMessage represents a validator's assessment of a specific candidate. - on receiving a statement message, we import a statement into the statement table and dispatch `Backed` notifications and misbehaviours as a result of importing a statement. - if the statement is seconded, the committed candidate receipt will be fetched from the statement table. Attesting data will be generated and stored to retry validation with other backing validators if a validator does not provide a PoV. - if the statement is valid, the validator index will be stored in existing attesting data. It will be checked whether the backing job is already running with the current validator. If not, the backing job will be started. - and then validation work will be kicked off. - added some overseer messages for other subsystems as well, such as provisioner, candidate validation, and statement distribution in `dot/parachain/types/overseer_messages.go` - implemented `Misbehaviour` enum using the interface (#3601) - removed duplicate parachain types from `lib/babe/inherents` (#3668) - implemented ExecutorParams varying datatype slice (partially implements #3544)
kishansagathiya
pushed a commit
that referenced
this pull request
Jul 15, 2024
…verseer (#3532) - Implemented functionality to handle a statement message coming to the candidate backing subsystem - StatementMessage represents a validator's assessment of a specific candidate. - on receiving a statement message, we import a statement into the statement table and dispatch `Backed` notifications and misbehaviours as a result of importing a statement. - if the statement is seconded, the committed candidate receipt will be fetched from the statement table. Attesting data will be generated and stored to retry validation with other backing validators if a validator does not provide a PoV. - if the statement is valid, the validator index will be stored in existing attesting data. It will be checked whether the backing job is already running with the current validator. If not, the backing job will be started. - and then validation work will be kicked off. - added some overseer messages for other subsystems as well, such as provisioner, candidate validation, and statement distribution in `dot/parachain/types/overseer_messages.go` - implemented `Misbehaviour` enum using the interface (#3601) - removed duplicate parachain types from `lib/babe/inherents` (#3668) - implemented ExecutorParams varying datatype slice (partially implements #3544)
kishansagathiya
pushed a commit
that referenced
this pull request
Jul 15, 2024
…verseer (#3532) - Implemented functionality to handle a statement message coming to the candidate backing subsystem - StatementMessage represents a validator's assessment of a specific candidate. - on receiving a statement message, we import a statement into the statement table and dispatch `Backed` notifications and misbehaviours as a result of importing a statement. - if the statement is seconded, the committed candidate receipt will be fetched from the statement table. Attesting data will be generated and stored to retry validation with other backing validators if a validator does not provide a PoV. - if the statement is valid, the validator index will be stored in existing attesting data. It will be checked whether the backing job is already running with the current validator. If not, the backing job will be started. - and then validation work will be kicked off. - added some overseer messages for other subsystems as well, such as provisioner, candidate validation, and statement distribution in `dot/parachain/types/overseer_messages.go` - implemented `Misbehaviour` enum using the interface (#3601) - removed duplicate parachain types from `lib/babe/inherents` (#3668) - implemented ExecutorParams varying datatype slice (partially implements #3544)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Tests
go test -tags integration github.com/ChainSafe/gossamerIssues
closes #3665
Note
need to merge only after #3532 gets merged
Primary Reviewer
@kishansagathiya @edwardmack