chore(dot/parachain/overseer): fix TestHandleBlockEvents the flaky test
#3707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axaysagathiya
requested review from
edwardmack,
timwu20,
EclesioMeloJunior,
jimjbrettj,
kishansagathiya and
dimartiro
as code owners
P1sar
added
C-simple
kishansagathiya
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
Currently TestHandleBlockEvents fails a lot of times in CI. This PR shows a bigger problem of how to gracefully shutdown overseer and subsystems.
Even though, this solution is not ideal, since it keeps the channels open, it is necessary to unblock other PRs. Currently, we are having to run CI some 6-7 to pass it due to this test.
Hence approving this. Will tackle the problem to shutting down overseer and subsystems separately.
EclesioMeloJunior
approved these changes
Jan 23, 2024
axaysagathiya
deleted the
axay/chore/overseer/test-handle-block-events
branch
kishansagathiya
pushed a commit
that referenced
this pull request
Jan 24, 2024
timwu20
pushed a commit
that referenced
this pull request
Jun 15, 2024
timwu20
pushed a commit
that referenced
this pull request
Jun 17, 2024
timwu20
pushed a commit
that referenced
this pull request
Jun 20, 2024
kishansagathiya
pushed a commit
that referenced
this pull request
Jul 15, 2024
kishansagathiya
pushed a commit
that referenced
this pull request
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
IMO, we should not close either of them.
That is why I removed the code to close overseerToSubsystem channels.
Used a
waitGroupin the test to wait till we received all the messages in mocked subsystems before we called the stop function of overseer.Tests
go test -tags integration github.com/ChainSafe/gossamerIssues
closes #3717
Primary Reviewer
@kishansagathiya @EclesioMeloJunior