Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dot/parachain/backing): Import statement into statement table #3966

Merged
merged 25 commits into from
Jun 10, 2024
Merged

feat(dot/parachain/backing): Import statement into statement table #3966

merged 25 commits into from
Jun 10, 2024

Conversation

axaysagathiya
Copy link
Contributor

@axaysagathiya axaysagathiya commented May 21, 2024 •
edited
Loading

Description

  • The statement table stores statements about candidates(parachain blocks) issued by authorities(parachain validators)
  • to call methods of statement table, we have an interface with a few methods, Which I am implementing one by one.
  • to know more about the statement table, read the description of issue feat(dot/parachain/backing): Implement Statement Table #3471
    • also, you can see it has a bunch of sub-issues, and this PR addresses one of them.

Changes

  • This PR implements a method to import the statement into the statement table
  • unexported TableContext struct
  • rename table interface method from getCandidate to getCommittedCandidateReceipt
  • changed attestedToBackedCandidate func to toBackedCandidate method of `attestedCandidate struct

Tests

go test ./dot/parachain/backing/...

Issues

#3471

Primary Reviewer

@edwardmack @timwu20

@axaysagathiya axaysagathiya changed the base branch from feat/parachain to axay/feat/backing/statement-table/attested-candidate May 21, 2024 14:37
Base automatically changed from axay/feat/backing/statement-table/attested-candidate to feat/parachain May 22, 2024 17:59
@axaysagathiya axaysagathiya marked this pull request as ready for review May 29, 2024 11:15
@axaysagathiya axaysagathiya requested a review from dimartiro as a code owner May 29, 2024 11:15
edwardmack
edwardmack reviewed May 29, 2024
View reviewed changes
Copy link
Contributor

@edwardmack edwardmack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the description of Tests to something like go test github.com/ChainSafe/gossamer/dot/parachain/backing -v or something to indicate the new tests that were created.

dot/parachain/backing/statement_table.go Show resolved Hide resolved
@axaysagathiya axaysagathiya requested a review from edwardmack May 31, 2024 15:17
@axaysagathiya
address reviews
ad9d533
@axaysagathiya
Merge branch 'axay/feat/backing/statement-table/import-statement' of …
d0c6a98 
…github.com:ChainSafe/gossamer into axay/feat/backing/statement-table/import-statement
edwardmack
edwardmack approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@edwardmack edwardmack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.

@axaysagathiya axaysagathiya merged commit 08e0381 into feat/parachain Jun 10, 2024
21 checks passed
@axaysagathiya axaysagathiya deleted the axay/feat/backing/statement-table/import-statement branch June 10, 2024 09:35
timwu20 pushed a commit that referenced this pull request Jun 17, 2024
@axaysagathiya @timwu20
feat(dot/parachain/backing): Import statement into statement table (#…
3f2e62f 
…3966)

- This PR implements a method to import the statement into the statement table
- unexported TableContext struct
- rename table interface method from getCandidate to getCommittedCandidateReceipt
- changed attestedToBackedCandidate func to toBackedCandidate method of `attestedCandidate struct
timwu20 pushed a commit that referenced this pull request Jun 17, 2024
@axaysagathiya @timwu20
feat(dot/parachain/backing): Import statement into statement table (#…
4a6efba 
…3966)

- This PR implements a method to import the statement into the statement table
- unexported TableContext struct
- rename table interface method from getCandidate to getCommittedCandidateReceipt
- changed attestedToBackedCandidate func to toBackedCandidate method of `attestedCandidate struct
timwu20 pushed a commit that referenced this pull request Jun 20, 2024
@axaysagathiya @timwu20
feat(dot/parachain/backing): Import statement into statement table (#…
d8d4874 
…3966)

- This PR implements a method to import the statement into the statement table
- unexported TableContext struct
- rename table interface method from getCandidate to getCommittedCandidateReceipt
- changed attestedToBackedCandidate func to toBackedCandidate method of `attestedCandidate struct
kishansagathiya pushed a commit that referenced this pull request Jul 15, 2024
@axaysagathiya @kishansagathiya
feat(dot/parachain/backing): Import statement into statement table (#…
65b6a7a 
…3966)

- This PR implements a method to import the statement into the statement table
- unexported TableContext struct
- rename table interface method from getCandidate to getCommittedCandidateReceipt
- changed attestedToBackedCandidate func to toBackedCandidate method of `attestedCandidate struct
kishansagathiya pushed a commit that referenced this pull request Jul 15, 2024
@axaysagathiya @kishansagathiya
feat(dot/parachain/backing): Import statement into statement table (#…
c6ba57c 
…3966)

- This PR implements a method to import the statement into the statement table
- unexported TableContext struct
- rename table interface method from getCandidate to getCommittedCandidateReceipt
- changed attestedToBackedCandidate func to toBackedCandidate method of `attestedCandidate struct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwardmack edwardmack edwardmack approved these changes

@timwu20 timwu20 timwu20 approved these changes

@EclesioMeloJunior EclesioMeloJunior Awaiting requested review from EclesioMeloJunior EclesioMeloJunior is a code owner

@jimjbrettj jimjbrettj Awaiting requested review from jimjbrettj jimjbrettj is a code owner

@dimartiro dimartiro Awaiting requested review from dimartiro

@kishansagathiya kishansagathiya Awaiting requested review from kishansagathiya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@axaysagathiya @timwu20 @edwardmack @kishansagathiya