Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: track block source in lodestar summary dashboard #5668

Merged
merged 2 commits into from
Jun 20, 2023
Merged

chore: track block source in lodestar summary dashboard #5668

merged 2 commits into from
Jun 20, 2023

Conversation

twoeths
Copy link
Contributor

@twoeths twoeths commented Jun 19, 2023

Motivation

  • If blocks come from either range sync or unknown block sync that's an issue to our node

Description

  • Track block source in lodestar dashboard as a new panel
  • Change the uid of lodestar_summary.json to be lodestar_summary so it works with download_dashboards.mjs script (see

    lodestar/scripts/download_dashboards.mjs

    Line 65 in 9a8a6f4

    if (fs.existsSync(outpath)) {
    ). After this is merged we should reimport this dashboard to grafana and remove the old uid dashboard
Screenshot 2023-06-19 at 13 33 12

@twoeths twoeths requested a review from a team as a code owner June 19, 2023 06:33
@github-actions
Copy link
Contributor

github-actions bot commented Jun 19, 2023 •
edited
Loading

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: f14633d Previous: 7c54a7b Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 607.71 us/op 999.28 us/op 0.61
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 61.883 us/op 49.398 us/op 1.25
BLS verify - blst-native 1.2955 ms/op 1.2294 ms/op 1.05
BLS verifyMultipleSignatures 3 - blst-native 2.6274 ms/op 2.4835 ms/op 1.06
BLS verifyMultipleSignatures 8 - blst-native 5.7944 ms/op 5.3432 ms/op 1.08
BLS verifyMultipleSignatures 32 - blst-native 20.533 ms/op 19.363 ms/op 1.06
BLS aggregatePubkeys 32 - blst-native 27.431 us/op 25.802 us/op 1.06
BLS aggregatePubkeys 128 - blst-native 107.87 us/op 101.26 us/op 1.07
getAttestationsForBlock 67.137 ms/op 58.965 ms/op 1.14
isKnown best case - 1 super set check 279.00 ns/op 263.00 ns/op 1.06
isKnown normal case - 2 super set checks 277.00 ns/op 255.00 ns/op 1.09
isKnown worse case - 16 super set checks 279.00 ns/op 257.00 ns/op 1.09
CheckpointStateCache - add get delete 6.2980 us/op 5.3580 us/op 1.18
validate gossip signedAggregateAndProof - struct 3.0598 ms/op 2.8639 ms/op 1.07
validate gossip attestation - struct 1.4633 ms/op 1.3503 ms/op 1.08
pickEth1Vote - no votes 1.4937 ms/op 1.3847 ms/op 1.08
pickEth1Vote - max votes 12.794 ms/op 10.475 ms/op 1.22
pickEth1Vote - Eth1Data hashTreeRoot value x2048 10.497 ms/op 9.4063 ms/op 1.12
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 17.547 ms/op 15.320 ms/op 1.15
pickEth1Vote - Eth1Data fastSerialize value x2048 846.31 us/op 678.66 us/op 1.25
pickEth1Vote - Eth1Data fastSerialize tree x2048 6.7639 ms/op 7.3198 ms/op 0.92
bytes32 toHexString 753.00 ns/op 580.00 ns/op 1.30
bytes32 Buffer.toString(hex) 445.00 ns/op 417.00 ns/op 1.07
bytes32 Buffer.toString(hex) from Uint8Array 655.00 ns/op 616.00 ns/op 1.06
bytes32 Buffer.toString(hex) + 0x 442.00 ns/op 405.00 ns/op 1.09
Object access 1 prop 0.21200 ns/op 0.18900 ns/op 1.12
Map access 1 prop 0.18600 ns/op 0.16800 ns/op 1.11
Object get x1000 7.3300 ns/op 6.8420 ns/op 1.07
Map get x1000 0.69500 ns/op 0.67100 ns/op 1.04
Object set x1000 77.763 ns/op 67.850 ns/op 1.15
Map set x1000 59.926 ns/op 55.320 ns/op 1.08
Return object 10000 times 0.25690 ns/op 0.24930 ns/op 1.03
Throw Error 10000 times 4.6095 us/op 4.4592 us/op 1.03
fastMsgIdFn sha256 / 200 bytes 4.0040 us/op 3.7520 us/op 1.07
fastMsgIdFn h32 xxhash / 200 bytes 347.00 ns/op 331.00 ns/op 1.05
fastMsgIdFn h64 xxhash / 200 bytes 499.00 ns/op 517.00 ns/op 0.97
fastMsgIdFn sha256 / 1000 bytes 12.544 us/op 12.149 us/op 1.03
fastMsgIdFn h32 xxhash / 1000 bytes 463.00 ns/op 468.00 ns/op 0.99
fastMsgIdFn h64 xxhash / 1000 bytes 577.00 ns/op 587.00 ns/op 0.98
fastMsgIdFn sha256 / 10000 bytes 113.34 us/op 110.20 us/op 1.03
fastMsgIdFn h32 xxhash / 10000 bytes 2.1290 us/op 2.0610 us/op 1.03
fastMsgIdFn h64 xxhash / 10000 bytes 1.5330 us/op 1.5160 us/op 1.01
enrSubnets - fastDeserialize 64 bits 1.7670 us/op 2.0830 us/op 0.85
enrSubnets - ssz BitVector 64 bits 647.00 ns/op 699.00 ns/op 0.93
enrSubnets - fastDeserialize 4 bits 221.00 ns/op 233.00 ns/op 0.95
enrSubnets - ssz BitVector 4 bits 650.00 ns/op 696.00 ns/op 0.93
prioritizePeers score -10:0 att 32-0.1 sync 2-0 118.20 us/op 141.38 us/op 0.84
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 168.89 us/op 153.54 us/op 1.10
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 200.66 us/op 195.89 us/op 1.02
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 382.43 us/op 375.83 us/op 1.02
prioritizePeers score 0:0 att 64-1 sync 4-1 449.02 us/op 455.24 us/op 0.99
array of 16000 items push then shift 1.7510 us/op 1.7552 us/op 1.00
LinkedList of 16000 items push then shift 9.7350 ns/op 10.505 ns/op 0.93
array of 16000 items push then pop 118.77 ns/op 130.59 ns/op 0.91
LinkedList of 16000 items push then pop 9.4310 ns/op 10.301 ns/op 0.92
array of 24000 items push then shift 2.4741 us/op 2.4906 us/op 0.99
LinkedList of 24000 items push then shift 9.5760 ns/op 11.606 ns/op 0.83
array of 24000 items push then pop 95.791 ns/op 100.75 ns/op 0.95
LinkedList of 24000 items push then pop 9.3510 ns/op 10.552 ns/op 0.89
intersect bitArray bitLen 8 13.929 ns/op 14.189 ns/op 0.98
intersect array and set length 8 88.282 ns/op 105.05 ns/op 0.84
intersect bitArray bitLen 128 46.089 ns/op 46.730 ns/op 0.99
intersect array and set length 128 1.2645 us/op 1.3194 us/op 0.96
Buffer.concat 32 items 3.1120 us/op 2.9010 us/op 1.07
Uint8Array.set 32 items 2.7630 us/op 2.5610 us/op 1.08
transfer serialized Status (84 B) 2.4160 us/op 2.2690 us/op 1.06
copy serialized Status (84 B) 1.9600 us/op 1.8530 us/op 1.06
transfer serialized SignedVoluntaryExit (112 B) 2.5720 us/op 2.7100 us/op 0.95
copy serialized SignedVoluntaryExit (112 B) 2.1210 us/op 1.9140 us/op 1.11
transfer serialized ProposerSlashing (416 B) 3.0600 us/op 2.8090 us/op 1.09
copy serialized ProposerSlashing (416 B) 3.5260 us/op 3.4940 us/op 1.01
transfer serialized Attestation (485 B) 3.5200 us/op 2.9190 us/op 1.21
copy serialized Attestation (485 B) 3.4500 us/op 3.4120 us/op 1.01
transfer serialized AttesterSlashing (33232 B) 3.5140 us/op 2.9080 us/op 1.21
copy serialized AttesterSlashing (33232 B) 7.5170 us/op 8.3450 us/op 0.90
transfer serialized Small SignedBeaconBlock (128000 B) 3.8310 us/op 2.8980 us/op 1.32
copy serialized Small SignedBeaconBlock (128000 B) 18.840 us/op 21.109 us/op 0.89
transfer serialized Avg SignedBeaconBlock (200000 B) 3.4020 us/op 3.4130 us/op 1.00
copy serialized Avg SignedBeaconBlock (200000 B) 26.472 us/op 36.623 us/op 0.72
transfer serialized BlobsSidecar (524380 B) 3.8330 us/op 3.3190 us/op 1.15
copy serialized BlobsSidecar (524380 B) 185.44 us/op 83.488 us/op 2.22
transfer serialized Big SignedBeaconBlock (1000000 B) 3.7320 us/op 3.6590 us/op 1.02
copy serialized Big SignedBeaconBlock (1000000 B) 320.09 us/op 385.38 us/op 0.83
pass gossip attestations to forkchoice per slot 2.8935 ms/op 2.7385 ms/op 1.06
forkChoice updateHead vc 100000 bc 64 eq 0 2.2437 ms/op 2.2827 ms/op 0.98
forkChoice updateHead vc 600000 bc 64 eq 0 12.820 ms/op 15.436 ms/op 0.83
forkChoice updateHead vc 1000000 bc 64 eq 0 26.518 ms/op 18.979 ms/op 1.40
forkChoice updateHead vc 600000 bc 320 eq 0 18.621 ms/op 17.071 ms/op 1.09
forkChoice updateHead vc 600000 bc 1200 eq 0 89.813 ms/op 85.143 ms/op 1.05
forkChoice updateHead vc 600000 bc 64 eq 1000 22.584 ms/op 21.018 ms/op 1.07
forkChoice updateHead vc 600000 bc 64 eq 10000 24.950 ms/op 22.753 ms/op 1.10
forkChoice updateHead vc 600000 bc 64 eq 300000 43.147 ms/op 33.689 ms/op 1.28
computeDeltas 3.5060 ms/op 3.0721 ms/op 1.14
computeProposerBoostScoreFromBalances 1.9102 ms/op 1.8093 ms/op 1.06
altair processAttestation - 250000 vs - 7PWei normalcase 4.2734 ms/op 3.4067 ms/op 1.25
altair processAttestation - 250000 vs - 7PWei worstcase 5.5700 ms/op 4.3271 ms/op 1.29
altair processAttestation - setStatus - 1/6 committees join 168.10 us/op 150.63 us/op 1.12
altair processAttestation - setStatus - 1/3 committees join 321.10 us/op 299.13 us/op 1.07
altair processAttestation - setStatus - 1/2 committees join 439.06 us/op 399.18 us/op 1.10
altair processAttestation - setStatus - 2/3 committees join 485.82 us/op 483.36 us/op 1.01
altair processAttestation - setStatus - 4/5 committees join 689.93 us/op 695.04 us/op 0.99
altair processAttestation - setStatus - 100% committees join 797.02 us/op 809.25 us/op 0.98
altair processBlock - 250000 vs - 7PWei normalcase 16.442 ms/op 18.498 ms/op 0.89
altair processBlock - 250000 vs - 7PWei normalcase hashState 30.539 ms/op 27.078 ms/op 1.13
altair processBlock - 250000 vs - 7PWei worstcase 51.545 ms/op 50.977 ms/op 1.01
altair processBlock - 250000 vs - 7PWei worstcase hashState 70.338 ms/op 74.414 ms/op 0.95
phase0 processBlock - 250000 vs - 7PWei normalcase 2.4962 ms/op 2.3185 ms/op 1.08
phase0 processBlock - 250000 vs - 7PWei worstcase 33.063 ms/op 31.311 ms/op 1.06
altair processEth1Data - 250000 vs - 7PWei normalcase 499.50 us/op 587.80 us/op 0.85
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 8.9020 us/op 8.8160 us/op 1.01
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 33.877 us/op 29.622 us/op 1.14
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 14.909 us/op 11.396 us/op 1.31
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 9.1970 us/op 10.031 us/op 0.92
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 106.40 us/op 121.88 us/op 0.87
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 693.20 us/op 1.0109 ms/op 0.69
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 934.45 us/op 969.32 us/op 0.96
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 927.36 us/op 909.13 us/op 1.02
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 2.4612 ms/op 2.7209 ms/op 0.90
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 1.6699 ms/op 1.5087 ms/op 1.11
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 3.9211 ms/op 4.1415 ms/op 0.95
Tree 40 250000 create 560.96 ms/op 416.49 ms/op 1.35
Tree 40 250000 get(125000) 208.46 ns/op 190.85 ns/op 1.09
Tree 40 250000 set(125000) 1.9953 us/op 1.0286 us/op 1.94
Tree 40 250000 toArray() 25.609 ms/op 22.266 ms/op 1.15
Tree 40 250000 iterate all - toArray() + loop 24.962 ms/op 21.139 ms/op 1.18
Tree 40 250000 iterate all - get(i) 86.717 ms/op 76.250 ms/op 1.14
MutableVector 250000 create 13.606 ms/op 11.697 ms/op 1.16
MutableVector 250000 get(125000) 7.8050 ns/op 6.4500 ns/op 1.21
MutableVector 250000 set(125000) 373.55 ns/op 293.80 ns/op 1.27
MutableVector 250000 toArray() 5.1149 ms/op 4.3259 ms/op 1.18
MutableVector 250000 iterate all - toArray() + loop 5.4241 ms/op 4.0404 ms/op 1.34
MutableVector 250000 iterate all - get(i) 1.6497 ms/op 1.5584 ms/op 1.06
Array 250000 create 4.4992 ms/op 2.9307 ms/op 1.54
Array 250000 clone - spread 1.4129 ms/op 1.1283 ms/op 1.25
Array 250000 get(125000) 0.71400 ns/op 0.55700 ns/op 1.28
Array 250000 set(125000) 1.1880 ns/op 0.62700 ns/op 1.89
Array 250000 iterate all - loop 95.920 us/op 83.141 us/op 1.15
effectiveBalanceIncrements clone Uint8Array 300000 55.180 us/op 30.999 us/op 1.78
effectiveBalanceIncrements clone MutableVector 300000 323.00 ns/op 338.00 ns/op 0.96
effectiveBalanceIncrements rw all Uint8Array 300000 186.78 us/op 170.44 us/op 1.10
effectiveBalanceIncrements rw all MutableVector 300000 94.741 ms/op 90.105 ms/op 1.05
phase0 afterProcessEpoch - 250000 vs - 7PWei 121.65 ms/op 117.89 ms/op 1.03
phase0 beforeProcessEpoch - 250000 vs - 7PWei 43.078 ms/op 43.978 ms/op 0.98
altair processEpoch - mainnet_e81889 341.88 ms/op 327.52 ms/op 1.04
mainnet_e81889 - altair beforeProcessEpoch 88.073 ms/op 53.086 ms/op 1.66
mainnet_e81889 - altair processJustificationAndFinalization 20.021 us/op 19.284 us/op 1.04
mainnet_e81889 - altair processInactivityUpdates 5.8598 ms/op 6.3005 ms/op 0.93
mainnet_e81889 - altair processRewardsAndPenalties 49.444 ms/op 65.228 ms/op 0.76
mainnet_e81889 - altair processRegistryUpdates 2.4780 us/op 2.7470 us/op 0.90
mainnet_e81889 - altair processSlashings 631.00 ns/op 541.00 ns/op 1.17
mainnet_e81889 - altair processEth1DataReset 1.3230 us/op 572.00 ns/op 2.31
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.5522 ms/op 1.2623 ms/op 1.23
mainnet_e81889 - altair processSlashingsReset 5.5840 us/op 4.7430 us/op 1.18
mainnet_e81889 - altair processRandaoMixesReset 11.850 us/op 7.2620 us/op 1.63
mainnet_e81889 - altair processHistoricalRootsUpdate 2.2760 us/op 838.00 ns/op 2.72
mainnet_e81889 - altair processParticipationFlagUpdates 5.9670 us/op 2.4060 us/op 2.48
mainnet_e81889 - altair processSyncCommitteeUpdates 1.0100 us/op 779.00 ns/op 1.30
mainnet_e81889 - altair afterProcessEpoch 144.27 ms/op 131.69 ms/op 1.10
phase0 processEpoch - mainnet_e58758 451.04 ms/op 371.22 ms/op 1.22
mainnet_e58758 - phase0 beforeProcessEpoch 162.56 ms/op 114.26 ms/op 1.42
mainnet_e58758 - phase0 processJustificationAndFinalization 20.987 us/op 17.820 us/op 1.18
mainnet_e58758 - phase0 processRewardsAndPenalties 55.649 ms/op 61.876 ms/op 0.90
mainnet_e58758 - phase0 processRegistryUpdates 11.544 us/op 8.6890 us/op 1.33
mainnet_e58758 - phase0 processSlashings 943.00 ns/op 565.00 ns/op 1.67
mainnet_e58758 - phase0 processEth1DataReset 826.00 ns/op 709.00 ns/op 1.17
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.1008 ms/op 1.1167 ms/op 0.99
mainnet_e58758 - phase0 processSlashingsReset 5.8020 us/op 3.9500 us/op 1.47
mainnet_e58758 - phase0 processRandaoMixesReset 8.1850 us/op 4.9880 us/op 1.64
mainnet_e58758 - phase0 processHistoricalRootsUpdate 836.00 ns/op 1.1200 us/op 0.75
mainnet_e58758 - phase0 processParticipationRecordUpdates 7.7860 us/op 4.7860 us/op 1.63
mainnet_e58758 - phase0 afterProcessEpoch 112.12 ms/op 102.27 ms/op 1.10
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.2930 ms/op 1.2511 ms/op 1.03
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.6063 ms/op 1.5188 ms/op 1.06
altair processInactivityUpdates - 250000 normalcase 21.525 ms/op 25.358 ms/op 0.85
altair processInactivityUpdates - 250000 worstcase 21.526 ms/op 29.813 ms/op 0.72
phase0 processRegistryUpdates - 250000 normalcase 13.918 us/op 7.9780 us/op 1.74
phase0 processRegistryUpdates - 250000 badcase_full_deposits 332.75 us/op 274.66 us/op 1.21
phase0 processRegistryUpdates - 250000 worstcase 0.5 158.60 ms/op 114.42 ms/op 1.39
altair processRewardsAndPenalties - 250000 normalcase 75.000 ms/op 72.339 ms/op 1.04
altair processRewardsAndPenalties - 250000 worstcase 63.250 ms/op 77.500 ms/op 0.82
phase0 getAttestationDeltas - 250000 normalcase 12.860 ms/op 10.486 ms/op 1.23
phase0 getAttestationDeltas - 250000 worstcase 10.424 ms/op 9.5280 ms/op 1.09
phase0 processSlashings - 250000 worstcase 4.4340 ms/op 3.9337 ms/op 1.13
altair processSyncCommitteeUpdates - 250000 222.00 ms/op 185.02 ms/op 1.20
BeaconState.hashTreeRoot - No change 317.00 ns/op 280.00 ns/op 1.13
BeaconState.hashTreeRoot - 1 full validator 56.477 us/op 53.718 us/op 1.05
BeaconState.hashTreeRoot - 32 full validator 598.39 us/op 571.64 us/op 1.05
BeaconState.hashTreeRoot - 512 full validator 5.4485 ms/op 5.7095 ms/op 0.95
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 70.917 us/op 67.097 us/op 1.06
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 958.59 us/op 908.80 us/op 1.05
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 13.259 ms/op 12.471 ms/op 1.06
BeaconState.hashTreeRoot - 1 balances 53.915 us/op 51.750 us/op 1.04
BeaconState.hashTreeRoot - 32 balances 477.20 us/op 459.68 us/op 1.04
BeaconState.hashTreeRoot - 512 balances 4.7164 ms/op 4.5646 ms/op 1.03
BeaconState.hashTreeRoot - 250000 balances 77.412 ms/op 77.613 ms/op 1.00
aggregationBits - 2048 els - zipIndexesInBitList 18.922 us/op 18.862 us/op 1.00
regular array get 100000 times 45.915 us/op 43.459 us/op 1.06
wrappedArray get 100000 times 34.593 us/op 33.290 us/op 1.04
arrayWithProxy get 100000 times 17.079 ms/op 17.213 ms/op 0.99
ssz.Root.equals 599.00 ns/op 572.00 ns/op 1.05
byteArrayEquals 589.00 ns/op 570.00 ns/op 1.03
shuffle list - 16384 els 7.2307 ms/op 7.0420 ms/op 1.03
shuffle list - 250000 els 104.48 ms/op 102.63 ms/op 1.02
processSlot - 1 slots 8.8760 us/op 9.9770 us/op 0.89
processSlot - 32 slots 1.5520 ms/op 1.4398 ms/op 1.08
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 36.177 ms/op 37.287 ms/op 0.97
getCommitteeAssignments - req 1 vs - 250000 vc 2.9761 ms/op 2.9839 ms/op 1.00
getCommitteeAssignments - req 100 vs - 250000 vc 4.2377 ms/op 4.2224 ms/op 1.00
getCommitteeAssignments - req 1000 vs - 250000 vc 4.6165 ms/op 4.5788 ms/op 1.01
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 4.9300 ns/op 4.9900 ns/op 0.99
state getBlockRootAtSlot - 250000 vs - 7PWei 551.00 ns/op 1.1684 us/op 0.47
computeProposers - vc 250000 10.527 ms/op 11.336 ms/op 0.93
computeEpochShuffling - vc 250000 104.14 ms/op 105.83 ms/op 0.98
getNextSyncCommittee - vc 250000 185.72 ms/op 186.06 ms/op 1.00
computeSigningRoot for AttestationData 15.012 us/op 14.331 us/op 1.05
hash AttestationData serialized data then Buffer.toString(base64) 2.6430 us/op 2.5052 us/op 1.06
toHexString serialized data 1.1205 us/op 1.2089 us/op 0.93
Buffer.toString(base64) 357.41 ns/op 359.56 ns/op 0.99

by benchmarkbot/action

twoeths
twoeths commented Jun 19, 2023
View reviewed changes
dashboards/lodestar_summary.json
@@ -3219,7 +3372,7 @@
},
"timezone": "utc",
"title": "Lodestar",
"uid": "lodestar",
"uid": "lodestar_summary",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uid needs to map to the file name

@dapplion dapplion merged commit e60af64 into unstable Jun 20, 2023
@dapplion dapplion deleted the tuyen/block_source_panel branch June 20, 2023 09:37
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.10.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nflaig nflaig nflaig approved these changes

@dapplion dapplion dapplion left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@twoeths @wemeetagain @dapplion @nflaig