-
-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: track participants of produced aggregates #5750
Merged
wemeetagain
merged 3 commits into
unstable
from
dapplion/metrics-production-participants
Jul 14, 2023
Merged
feat: track participants of produced aggregates #5750
wemeetagain
merged 3 commits into
unstable
from
dapplion/metrics-production-participants
Jul 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance Report✔️ no performance regression detected Full benchmark results
|
wemeetagain
reviewed
Jul 12, 2023
nflaig
reviewed
Jul 14, 2023
nflaig
approved these changes
Jul 14, 2023
wemeetagain
approved these changes
Jul 14, 2023
🎉 This PR is included in v1.10.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Know the quality of produced aggregates for any API callee
Description
Added metrics:
lodestar/packages/beacon-node/src/metrics/metrics/lodestar.ts
Lines 226 to 227 in 7f24c6e
lodestar/packages/beacon-node/src/metrics/metrics/lodestar.ts
Lines 233 to 234 in 7f24c6e
lodestar/packages/beacon-node/src/metrics/metrics/lodestar.ts
Lines 240 to 241 in 7f24c6e
Considerations
This PR adds an extra step in block production hot path. 1 call per block to getTrueBitIndexes for a 512 bits SyncAggregate. I have added a benchmark and showed to it adds ~12us which is not a concern at all