fix: fix eslint for import/no-extraneous-dependencies #5752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazarhussain
force-pushed
the
nh/update-lint
branch
from
7fd995f to
5bb6cb3
Compare
nazarhussain
force-pushed
the
nh/update-lint
branch
from
5bb6cb3 to
e506cf4
Compare
Performance Report✔️ no performance regression detected Full benchmark results
|
matthewkeil
approved these changes
Jul 12, 2023
nflaig
reviewed
Jul 13, 2023
| @@ -152,7 +156,6 @@ module.exports = { | |||
| semi: "off", | |||
| }, | |||
| settings: { | |||
| "import/internal-regex": "^@chainsafe/", | |||
There was a problem hiding this comment.
why was this removed? should add some context in the PR
There was a problem hiding this comment.
First it was contextually not correct. Secondly it was making the mono-repo packages as external.
| import {BeaconConfig} from "@lodestar/config"; | ||
| import {LoggerNode} from "@lodestar/logger/node"; | ||
| import type {LoggerNode} from "@lodestar/logger/node"; |
There was a problem hiding this comment.
@lodestar/logger is a dependency of beacon-node, what is the reason for adding explicit type only import?
There was a problem hiding this comment.
On 2nd thought, maybe it makes sense. The only reason the beacon-node packages requires @lodestar/logger as dependency is because the workers need to initialize their own instance using getNodeLogger. I don't think this can be solved though as it will not be possible to inject the logger to the worker process.
There was a problem hiding this comment.
For type only import, it was changed before I realized that worker are requiring getNodeLogger.
| @@ -1,5 +1,6 @@ | |||
| import {itBench} from "@dapplion/benchmark"; | |||
| import {PointFormat} from "@chainsafe/bls/types"; | |||
| // eslint-disable-next-line import/no-relative-packages | |||
| import {generatePerfTestCachedStatePhase0, numValidators} from "../../../../../../state-transition/test/perf/util.js"; | |||
There was a problem hiding this comment.
I feel like we should get rid of those cross-package relative imports. Those functions could be moved to @lodestar/test-utils and then imported from there.
There was a problem hiding this comment.
Yes we can do that and @lodestar/test-utils will be helpful in this context.
|
🎉 This PR is included in v1.10.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
All the packages should have valid dependencies.
Description
import/no-extraneous-dependencieswhich was not effective for mono-repo packages.Steps to test or reproduce
Run all tests
NOTE: Would be better to review by commit.