-
-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(db): add check for gdu vs du #5788
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewkeil
changed the title
tes(db): add check for gdu vs du
test(db): add check for gdu vs du
Jul 23, 2023
Performance Report✔️ no performance regression detected Full benchmark results
|
dapplion
approved these changes
Jul 24, 2023
nflaig
approved these changes
Jul 24, 2023
wemeetagain
approved these changes
Jul 24, 2023
🎉 This PR is included in v1.10.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I reinstalled my osX and a new error popped up. The
du
command does not have the-b
flag in the osx version ofdu
. Required me to installdu
from the GNUcoreutils
.brew install du
prefixes the commands withg
so the command name isgdu
.I did not have this aliased nor on my path before reinstalling. Never ran into the error before updating/reinstalling the os so it may be something new but am not 100% certain. Installed version
Ventura 13.4.1 (22F82)
.I found a stack overflow page that explained how to alias all the commands but a few other pages I found said there could be system instability from fully aliasing because existing scripts can potentially fail if expecting the osx versions.
OSX man page for
du
GNU man page for
du
SO page for issues with aliasing commands
Description
Checks for existence of
gdu
command ondarwin
platform and defaults back todu
ifgdu
is not found.Steps to test or reproduce
On mac with
coreutils
installed viahomebrew
:cd packages/db yarn test:unit