Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove extra white space in logs if context is empty #6046

Merged
merged 1 commit into from
Oct 18, 2023
Merged

fix: remove extra white space in logs if context is empty #6046

merged 1 commit into from
Oct 18, 2023

Conversation

nflaig
Copy link
Member

@nflaig nflaig commented Oct 18, 2023

Motivation

Noticed that an extra white space is added to log if context is an empty object {}

Current

Oct-17 18:07:21.655[rest]            error: Req req-pt5m registerValidator error  - Execution builder not enabled

Expected

Oct-17 18:07:21.655[rest]            error: Req req-pt5m registerValidator error - Execution builder not enabled

Description

Additionally check if provided object is empty and handle it the same way as undefined values. In most places, an empty object is passed to the logger instead of undefined.

@nflaig nflaig requested a review from a team as a code owner October 18, 2023 07:17
@nflaig nflaig added this to the v1.12.0 milestone Oct 18, 2023
@github-actions
Copy link
Contributor

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: b74bb38 Previous: 3a6702e Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 574.47 us/op 591.39 us/op 0.97
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 100.14 us/op 96.258 us/op 1.04
BLS verify - blst-native 1.3868 ms/op 1.4387 ms/op 0.96
BLS verifyMultipleSignatures 3 - blst-native 2.8803 ms/op 3.1584 ms/op 0.91
BLS verifyMultipleSignatures 8 - blst-native 6.4201 ms/op 6.7372 ms/op 0.95
BLS verifyMultipleSignatures 32 - blst-native 23.419 ms/op 23.889 ms/op 0.98
BLS verifyMultipleSignatures 64 - blst-native 47.992 ms/op 47.726 ms/op 1.01
BLS verifyMultipleSignatures 128 - blst-native 90.117 ms/op 92.975 ms/op 0.97
BLS deserializing 10000 signatures 950.11 ms/op 937.44 ms/op 1.01
BLS deserializing 100000 signatures 9.6070 s/op 9.4726 s/op 1.01
BLS verifyMultipleSignatures - same message - 3 - blst-native 1.4759 ms/op 1.4405 ms/op 1.02
BLS verifyMultipleSignatures - same message - 8 - blst-native 1.6881 ms/op 1.6308 ms/op 1.04
BLS verifyMultipleSignatures - same message - 32 - blst-native 2.5076 ms/op 2.5340 ms/op 0.99
BLS verifyMultipleSignatures - same message - 64 - blst-native 3.9464 ms/op 3.6870 ms/op 1.07
BLS verifyMultipleSignatures - same message - 128 - blst-native 6.2042 ms/op 5.9755 ms/op 1.04
BLS aggregatePubkeys 32 - blst-native 27.795 us/op 26.978 us/op 1.03
BLS aggregatePubkeys 128 - blst-native 108.40 us/op 105.61 us/op 1.03
getAttestationsForBlock 56.162 ms/op 47.545 ms/op 1.18
isKnown best case - 1 super set check 565.00 ns/op 500.00 ns/op 1.13
isKnown normal case - 2 super set checks 562.00 ns/op 491.00 ns/op 1.14
isKnown worse case - 16 super set checks 576.00 ns/op 496.00 ns/op 1.16
CheckpointStateCache - add get delete 6.6020 us/op 6.0640 us/op 1.09
validate api signedAggregateAndProof - struct 2.9725 ms/op 2.8973 ms/op 1.03
validate gossip signedAggregateAndProof - struct 3.0990 ms/op 2.9555 ms/op 1.05
validate gossip attestation - vc 640000 1.5130 ms/op 1.4370 ms/op 1.05
batch validate gossip attestation - vc 640000 - chunk 32 189.16 us/op 176.91 us/op 1.07
batch validate gossip attestation - vc 640000 - chunk 64 159.99 us/op 157.20 us/op 1.02
batch validate gossip attestation - vc 640000 - chunk 128 151.53 us/op 146.92 us/op 1.03
batch validate gossip attestation - vc 640000 - chunk 256 146.00 us/op 139.00 us/op 1.05
pickEth1Vote - no votes 1.3558 ms/op 1.3552 ms/op 1.00
pickEth1Vote - max votes 13.287 ms/op 10.651 ms/op 1.25
pickEth1Vote - Eth1Data hashTreeRoot value x2048 22.073 ms/op 18.362 ms/op 1.20
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 31.870 ms/op 26.737 ms/op 1.19
pickEth1Vote - Eth1Data fastSerialize value x2048 688.50 us/op 667.58 us/op 1.03
pickEth1Vote - Eth1Data fastSerialize tree x2048 5.6377 ms/op 4.9896 ms/op 1.13
bytes32 toHexString 641.00 ns/op 572.00 ns/op 1.12
bytes32 Buffer.toString(hex) 324.00 ns/op 313.00 ns/op 1.04
bytes32 Buffer.toString(hex) from Uint8Array 530.00 ns/op 505.00 ns/op 1.05
bytes32 Buffer.toString(hex) + 0x 323.00 ns/op 318.00 ns/op 1.02
Object access 1 prop 0.21000 ns/op 0.19900 ns/op 1.06
Map access 1 prop 0.16600 ns/op 0.16000 ns/op 1.04
Object get x1000 8.1110 ns/op 8.2920 ns/op 0.98
Map get x1000 0.68500 ns/op 0.75700 ns/op 0.90
Object set x1000 68.621 ns/op 68.037 ns/op 1.01
Map set x1000 50.595 ns/op 49.631 ns/op 1.02
Return object 10000 times 0.27380 ns/op 0.26710 ns/op 1.03
Throw Error 10000 times 4.2230 us/op 4.5380 us/op 0.93
fastMsgIdFn sha256 / 200 bytes 3.6330 us/op 3.7430 us/op 0.97
fastMsgIdFn h32 xxhash / 200 bytes 326.00 ns/op 320.00 ns/op 1.02
fastMsgIdFn h64 xxhash / 200 bytes 414.00 ns/op 378.00 ns/op 1.10
fastMsgIdFn sha256 / 1000 bytes 12.528 us/op 12.733 us/op 0.98
fastMsgIdFn h32 xxhash / 1000 bytes 492.00 ns/op 452.00 ns/op 1.09
fastMsgIdFn h64 xxhash / 1000 bytes 484.00 ns/op 467.00 ns/op 1.04
fastMsgIdFn sha256 / 10000 bytes 111.40 us/op 111.89 us/op 1.00
fastMsgIdFn h32 xxhash / 10000 bytes 2.0890 us/op 2.2540 us/op 0.93
fastMsgIdFn h64 xxhash / 10000 bytes 1.4680 us/op 1.4870 us/op 0.99
send data - 1000 256B messages 23.289 ms/op 21.846 ms/op 1.07
send data - 1000 512B messages 31.448 ms/op 28.640 ms/op 1.10
send data - 1000 1024B messages 47.045 ms/op 43.619 ms/op 1.08
send data - 1000 1200B messages 37.002 ms/op 33.063 ms/op 1.12
send data - 1000 2048B messages 39.391 ms/op 35.798 ms/op 1.10
send data - 1000 4096B messages 44.694 ms/op 29.583 ms/op 1.51
send data - 1000 16384B messages 90.242 ms/op 89.664 ms/op 1.01
send data - 1000 65536B messages 339.54 ms/op 328.14 ms/op 1.03
enrSubnets - fastDeserialize 64 bits 1.6430 us/op 1.4990 us/op 1.10
enrSubnets - ssz BitVector 64 bits 500.00 ns/op 490.00 ns/op 1.02
enrSubnets - fastDeserialize 4 bits 207.00 ns/op 209.00 ns/op 0.99
enrSubnets - ssz BitVector 4 bits 509.00 ns/op 482.00 ns/op 1.06
prioritizePeers score -10:0 att 32-0.1 sync 2-0 122.06 us/op 112.49 us/op 1.09
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 146.79 us/op 142.43 us/op 1.03
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 211.85 us/op 192.80 us/op 1.10
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 339.10 us/op 318.53 us/op 1.06
prioritizePeers score 0:0 att 64-1 sync 4-1 380.31 us/op 373.41 us/op 1.02
array of 16000 items push then shift 1.8127 us/op 1.7264 us/op 1.05
LinkedList of 16000 items push then shift 10.939 ns/op 9.4650 ns/op 1.16
array of 16000 items push then pop 98.267 ns/op 94.307 ns/op 1.04
LinkedList of 16000 items push then pop 9.8120 ns/op 9.3410 ns/op 1.05
array of 24000 items push then shift 2.7158 us/op 2.6676 us/op 1.02
LinkedList of 24000 items push then shift 10.870 ns/op 11.093 ns/op 0.98
array of 24000 items push then pop 140.61 ns/op 141.75 ns/op 0.99
LinkedList of 24000 items push then pop 9.6570 ns/op 9.6790 ns/op 1.00
intersect bitArray bitLen 8 7.4690 ns/op 7.6090 ns/op 0.98
intersect array and set length 8 75.700 ns/op 70.140 ns/op 1.08
intersect bitArray bitLen 128 34.939 ns/op 35.611 ns/op 0.98
intersect array and set length 128 954.65 ns/op 927.22 ns/op 1.03
bitArray.getTrueBitIndexes() bitLen 128 1.8540 us/op 1.6790 us/op 1.10
bitArray.getTrueBitIndexes() bitLen 248 3.0780 us/op 2.9510 us/op 1.04
bitArray.getTrueBitIndexes() bitLen 512 6.2910 us/op 5.4400 us/op 1.16
Buffer.concat 32 items 1.0660 us/op 1.0990 us/op 0.97
Uint8Array.set 32 items 2.0100 us/op 2.7550 us/op 0.73
Set add up to 64 items then delete first 4.8371 us/op 4.7997 us/op 1.01
OrderedSet add up to 64 items then delete first 6.3548 us/op 6.2912 us/op 1.01
Set add up to 64 items then delete last 5.2400 us/op 5.2798 us/op 0.99
OrderedSet add up to 64 items then delete last 6.7548 us/op 6.6747 us/op 1.01
Set add up to 64 items then delete middle 5.2434 us/op 5.1297 us/op 1.02
OrderedSet add up to 64 items then delete middle 8.1553 us/op 8.3198 us/op 0.98
Set add up to 128 items then delete first 10.643 us/op 10.612 us/op 1.00
OrderedSet add up to 128 items then delete first 14.420 us/op 14.432 us/op 1.00
Set add up to 128 items then delete last 10.370 us/op 10.168 us/op 1.02
OrderedSet add up to 128 items then delete last 13.611 us/op 13.346 us/op 1.02
Set add up to 128 items then delete middle 10.332 us/op 10.388 us/op 0.99
OrderedSet add up to 128 items then delete middle 19.065 us/op 19.222 us/op 0.99
Set add up to 256 items then delete first 21.562 us/op 21.141 us/op 1.02
OrderedSet add up to 256 items then delete first 29.089 us/op 29.111 us/op 1.00
Set add up to 256 items then delete last 20.720 us/op 20.664 us/op 1.00
OrderedSet add up to 256 items then delete last 27.395 us/op 27.293 us/op 1.00
Set add up to 256 items then delete middle 20.605 us/op 20.526 us/op 1.00
OrderedSet add up to 256 items then delete middle 49.990 us/op 50.327 us/op 0.99
transfer serialized Status (84 B) 1.8810 us/op 1.8990 us/op 0.99
copy serialized Status (84 B) 1.6240 us/op 1.6100 us/op 1.01
transfer serialized SignedVoluntaryExit (112 B) 1.9800 us/op 2.0180 us/op 0.98
copy serialized SignedVoluntaryExit (112 B) 1.6690 us/op 1.7010 us/op 0.98
transfer serialized ProposerSlashing (416 B) 2.4540 us/op 3.1500 us/op 0.78
copy serialized ProposerSlashing (416 B) 2.5140 us/op 2.7950 us/op 0.90
transfer serialized Attestation (485 B) 2.5790 us/op 2.6090 us/op 0.99
copy serialized Attestation (485 B) 2.7550 us/op 3.0800 us/op 0.89
transfer serialized AttesterSlashing (33232 B) 2.8140 us/op 3.1140 us/op 0.90
copy serialized AttesterSlashing (33232 B) 9.0390 us/op 6.5160 us/op 1.39
transfer serialized Small SignedBeaconBlock (128000 B) 3.1730 us/op 3.2620 us/op 0.97
copy serialized Small SignedBeaconBlock (128000 B) 24.030 us/op 15.727 us/op 1.53
transfer serialized Avg SignedBeaconBlock (200000 B) 3.3710 us/op 3.6840 us/op 0.92
copy serialized Avg SignedBeaconBlock (200000 B) 37.453 us/op 28.104 us/op 1.33
transfer serialized BlobsSidecar (524380 B) 4.3590 us/op 3.7670 us/op 1.16
copy serialized BlobsSidecar (524380 B) 120.22 us/op 106.22 us/op 1.13
transfer serialized Big SignedBeaconBlock (1000000 B) 3.8240 us/op 3.9860 us/op 0.96
copy serialized Big SignedBeaconBlock (1000000 B) 203.85 us/op 190.36 us/op 1.07
pass gossip attestations to forkchoice per slot 4.3384 ms/op 3.9533 ms/op 1.10
forkChoice updateHead vc 100000 bc 64 eq 0 821.53 us/op 701.27 us/op 1.17
forkChoice updateHead vc 600000 bc 64 eq 0 8.3806 ms/op 4.8288 ms/op 1.74
forkChoice updateHead vc 1000000 bc 64 eq 0 8.7232 ms/op 7.2803 ms/op 1.20
forkChoice updateHead vc 600000 bc 320 eq 0 5.2720 ms/op 4.6053 ms/op 1.14
forkChoice updateHead vc 600000 bc 1200 eq 0 4.9566 ms/op 4.7397 ms/op 1.05
forkChoice updateHead vc 600000 bc 7200 eq 0 7.7290 ms/op 6.0948 ms/op 1.27
forkChoice updateHead vc 600000 bc 64 eq 1000 13.097 ms/op 11.969 ms/op 1.09
forkChoice updateHead vc 600000 bc 64 eq 10000 15.832 ms/op 12.881 ms/op 1.23
forkChoice updateHead vc 600000 bc 64 eq 300000 46.137 ms/op 18.857 ms/op 2.45
computeDeltas 500000 validators 300 proto nodes 7.7247 ms/op 6.4981 ms/op 1.19
computeDeltas 500000 validators 1200 proto nodes 7.8507 ms/op 6.3823 ms/op 1.23
computeDeltas 500000 validators 7200 proto nodes 7.9215 ms/op 6.6132 ms/op 1.20
computeDeltas 750000 validators 300 proto nodes 12.356 ms/op 9.9695 ms/op 1.24
computeDeltas 750000 validators 1200 proto nodes 12.154 ms/op 9.7029 ms/op 1.25
computeDeltas 750000 validators 7200 proto nodes 11.552 ms/op 9.8402 ms/op 1.17
computeDeltas 1400000 validators 300 proto nodes 20.788 ms/op 18.906 ms/op 1.10
computeDeltas 1400000 validators 1200 proto nodes 19.411 ms/op 18.639 ms/op 1.04
computeDeltas 1400000 validators 7200 proto nodes 19.486 ms/op 18.990 ms/op 1.03
computeDeltas 2100000 validators 300 proto nodes 28.075 ms/op 27.932 ms/op 1.01
computeDeltas 2100000 validators 1200 proto nodes 28.071 ms/op 28.705 ms/op 0.98
computeDeltas 2100000 validators 7200 proto nodes 28.260 ms/op 28.333 ms/op 1.00
computeProposerBoostScoreFromBalances 500000 validators 3.4047 ms/op 3.4071 ms/op 1.00
computeProposerBoostScoreFromBalances 750000 validators 3.4080 ms/op 3.4026 ms/op 1.00
computeProposerBoostScoreFromBalances 1400000 validators 3.3839 ms/op 3.3851 ms/op 1.00
computeProposerBoostScoreFromBalances 2100000 validators 3.3514 ms/op 3.3763 ms/op 0.99
altair processAttestation - 250000 vs - 7PWei normalcase 2.3258 ms/op 3.0004 ms/op 0.78
altair processAttestation - 250000 vs - 7PWei worstcase 3.2896 ms/op 4.2801 ms/op 0.77
altair processAttestation - setStatus - 1/6 committees join 175.83 us/op 191.51 us/op 0.92
altair processAttestation - setStatus - 1/3 committees join 341.98 us/op 366.67 us/op 0.93
altair processAttestation - setStatus - 1/2 committees join 462.57 us/op 495.50 us/op 0.93
altair processAttestation - setStatus - 2/3 committees join 587.65 us/op 633.15 us/op 0.93
altair processAttestation - setStatus - 4/5 committees join 791.44 us/op 858.47 us/op 0.92
altair processAttestation - setStatus - 100% committees join 904.32 us/op 1.0163 ms/op 0.89
altair processBlock - 250000 vs - 7PWei normalcase 10.567 ms/op 10.637 ms/op 0.99
altair processBlock - 250000 vs - 7PWei normalcase hashState 33.724 ms/op 36.793 ms/op 0.92
altair processBlock - 250000 vs - 7PWei worstcase 37.970 ms/op 48.576 ms/op 0.78
altair processBlock - 250000 vs - 7PWei worstcase hashState 88.562 ms/op 101.79 ms/op 0.87
phase0 processBlock - 250000 vs - 7PWei normalcase 2.8798 ms/op 3.2752 ms/op 0.88
phase0 processBlock - 250000 vs - 7PWei worstcase 28.770 ms/op 34.288 ms/op 0.84
altair processEth1Data - 250000 vs - 7PWei normalcase 480.92 us/op 682.34 us/op 0.70
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 12.213 us/op 18.702 us/op 0.65
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 95.664 us/op 90.920 us/op 1.05
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 17.327 us/op 27.119 us/op 0.64
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 11.917 us/op 11.780 us/op 1.01
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 223.05 us/op 175.09 us/op 1.27
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 1.0224 ms/op 1.5119 ms/op 0.68
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 2.1314 ms/op 2.2744 ms/op 0.94
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 2.6953 ms/op 1.7404 ms/op 1.55
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 3.1119 ms/op 4.1089 ms/op 0.76
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 2.3306 ms/op 3.1210 ms/op 0.75
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 4.8828 ms/op 7.4446 ms/op 0.66
Tree 40 250000 create 347.49 ms/op 572.15 ms/op 0.61
Tree 40 250000 get(125000) 192.79 ns/op 216.66 ns/op 0.89
Tree 40 250000 set(125000) 826.95 ns/op 1.0940 us/op 0.76
Tree 40 250000 toArray() 16.380 ms/op 22.807 ms/op 0.72
Tree 40 250000 iterate all - toArray() + loop 17.844 ms/op 22.695 ms/op 0.79
Tree 40 250000 iterate all - get(i) 66.019 ms/op 76.171 ms/op 0.87
MutableVector 250000 create 15.856 ms/op 14.324 ms/op 1.11
MutableVector 250000 get(125000) 6.5560 ns/op 7.0130 ns/op 0.93
MutableVector 250000 set(125000) 262.79 ns/op 306.96 ns/op 0.86
MutableVector 250000 toArray() 3.2688 ms/op 4.1736 ms/op 0.78
MutableVector 250000 iterate all - toArray() + loop 3.4119 ms/op 4.1580 ms/op 0.82
MutableVector 250000 iterate all - get(i) 1.5408 ms/op 1.6538 ms/op 0.93
Array 250000 create 2.7381 ms/op 3.8954 ms/op 0.70
Array 250000 clone - spread 1.0380 ms/op 1.2016 ms/op 0.86
Array 250000 get(125000) 0.50500 ns/op 0.59900 ns/op 0.84
Array 250000 set(125000) 0.57500 ns/op 0.71500 ns/op 0.80
Array 250000 iterate all - loop 83.151 us/op 87.119 us/op 0.95
effectiveBalanceIncrements clone Uint8Array 300000 21.011 us/op 30.064 us/op 0.70
effectiveBalanceIncrements clone MutableVector 300000 266.00 ns/op 317.00 ns/op 0.84
effectiveBalanceIncrements rw all Uint8Array 300000 178.83 us/op 192.07 us/op 0.93
effectiveBalanceIncrements rw all MutableVector 300000 71.879 ms/op 97.045 ms/op 0.74
phase0 afterProcessEpoch - 250000 vs - 7PWei 117.32 ms/op 120.96 ms/op 0.97
phase0 beforeProcessEpoch - 250000 vs - 7PWei 46.137 ms/op 50.191 ms/op 0.92
altair processEpoch - mainnet_e81889 460.63 ms/op 496.56 ms/op 0.93
mainnet_e81889 - altair beforeProcessEpoch 63.211 ms/op 65.110 ms/op 0.97
mainnet_e81889 - altair processJustificationAndFinalization 27.964 us/op 23.457 us/op 1.19
mainnet_e81889 - altair processInactivityUpdates 5.4813 ms/op 6.5323 ms/op 0.84
mainnet_e81889 - altair processRewardsAndPenalties 84.335 ms/op 67.829 ms/op 1.24
mainnet_e81889 - altair processRegistryUpdates 2.6760 us/op 3.1220 us/op 0.86
mainnet_e81889 - altair processSlashings 459.00 ns/op 524.00 ns/op 0.88
mainnet_e81889 - altair processEth1DataReset 495.00 ns/op 1.0750 us/op 0.46
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.5204 ms/op 1.2943 ms/op 1.17
mainnet_e81889 - altair processSlashingsReset 4.2970 us/op 4.7730 us/op 0.90
mainnet_e81889 - altair processRandaoMixesReset 7.2560 us/op 6.4510 us/op 1.12
mainnet_e81889 - altair processHistoricalRootsUpdate 843.00 ns/op 891.00 ns/op 0.95
mainnet_e81889 - altair processParticipationFlagUpdates 2.9390 us/op 2.6980 us/op 1.09
mainnet_e81889 - altair processSyncCommitteeUpdates 815.00 ns/op 886.00 ns/op 0.92
mainnet_e81889 - altair afterProcessEpoch 131.13 ms/op 132.83 ms/op 0.99
capella processEpoch - mainnet_e217614 1.7173 s/op 1.6924 s/op 1.01
mainnet_e217614 - capella beforeProcessEpoch 272.21 ms/op 263.87 ms/op 1.03
mainnet_e217614 - capella processJustificationAndFinalization 13.666 us/op 15.931 us/op 0.86
mainnet_e217614 - capella processInactivityUpdates 17.773 ms/op 17.362 ms/op 1.02
mainnet_e217614 - capella processRewardsAndPenalties 322.12 ms/op 302.05 ms/op 1.07
mainnet_e217614 - capella processRegistryUpdates 24.679 us/op 30.539 us/op 0.81
mainnet_e217614 - capella processSlashings 748.00 ns/op 610.00 ns/op 1.23
mainnet_e217614 - capella processEth1DataReset 577.00 ns/op 1.1390 us/op 0.51
mainnet_e217614 - capella processEffectiveBalanceUpdates 4.2787 ms/op 4.2096 ms/op 1.02
mainnet_e217614 - capella processSlashingsReset 3.5840 us/op 2.5690 us/op 1.40
mainnet_e217614 - capella processRandaoMixesReset 6.7250 us/op 5.1930 us/op 1.30
mainnet_e217614 - capella processHistoricalRootsUpdate 987.00 ns/op 631.00 ns/op 1.56
mainnet_e217614 - capella processParticipationFlagUpdates 1.9370 us/op 1.5850 us/op 1.22
mainnet_e217614 - capella afterProcessEpoch 344.77 ms/op 303.35 ms/op 1.14
phase0 processEpoch - mainnet_e58758 531.91 ms/op 434.35 ms/op 1.22
mainnet_e58758 - phase0 beforeProcessEpoch 154.63 ms/op 107.30 ms/op 1.44
mainnet_e58758 - phase0 processJustificationAndFinalization 20.744 us/op 16.674 us/op 1.24
mainnet_e58758 - phase0 processRewardsAndPenalties 60.628 ms/op 56.702 ms/op 1.07
mainnet_e58758 - phase0 processRegistryUpdates 14.626 us/op 11.577 us/op 1.26
mainnet_e58758 - phase0 processSlashings 889.00 ns/op 628.00 ns/op 1.42
mainnet_e58758 - phase0 processEth1DataReset 570.00 ns/op 500.00 ns/op 1.14
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.3008 ms/op 1.0682 ms/op 1.22
mainnet_e58758 - phase0 processSlashingsReset 3.4580 us/op 2.2830 us/op 1.51
mainnet_e58758 - phase0 processRandaoMixesReset 6.7740 us/op 5.3320 us/op 1.27
mainnet_e58758 - phase0 processHistoricalRootsUpdate 876.00 ns/op 960.00 ns/op 0.91
mainnet_e58758 - phase0 processParticipationRecordUpdates 5.1370 us/op 4.9510 us/op 1.04
mainnet_e58758 - phase0 afterProcessEpoch 120.07 ms/op 108.38 ms/op 1.11
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.6281 ms/op 1.2693 ms/op 1.28
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 2.4703 ms/op 1.4486 ms/op 1.71
altair processInactivityUpdates - 250000 normalcase 28.064 ms/op 25.581 ms/op 1.10
altair processInactivityUpdates - 250000 worstcase 28.792 ms/op 25.679 ms/op 1.12
phase0 processRegistryUpdates - 250000 normalcase 9.9080 us/op 10.088 us/op 0.98
phase0 processRegistryUpdates - 250000 badcase_full_deposits 459.71 us/op 380.08 us/op 1.21
phase0 processRegistryUpdates - 250000 worstcase 0.5 149.90 ms/op 131.94 ms/op 1.14
altair processRewardsAndPenalties - 250000 normalcase 78.495 ms/op 70.552 ms/op 1.11
altair processRewardsAndPenalties - 250000 worstcase 72.895 ms/op 70.842 ms/op 1.03
phase0 getAttestationDeltas - 250000 normalcase 9.0053 ms/op 8.6195 ms/op 1.04
phase0 getAttestationDeltas - 250000 worstcase 9.9617 ms/op 8.4045 ms/op 1.19
phase0 processSlashings - 250000 worstcase 2.4931 ms/op 2.4941 ms/op 1.00
altair processSyncCommitteeUpdates - 250000 178.10 ms/op 163.33 ms/op 1.09
BeaconState.hashTreeRoot - No change 271.00 ns/op 264.00 ns/op 1.03
BeaconState.hashTreeRoot - 1 full validator 184.65 us/op 133.80 us/op 1.38
BeaconState.hashTreeRoot - 32 full validator 1.6186 ms/op 1.7519 ms/op 0.92
BeaconState.hashTreeRoot - 512 full validator 16.613 ms/op 12.102 ms/op 1.37
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 179.92 us/op 137.24 us/op 1.31
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 2.8848 ms/op 1.8504 ms/op 1.56
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 34.598 ms/op 28.803 ms/op 1.20
BeaconState.hashTreeRoot - 1 balances 151.80 us/op 125.59 us/op 1.21
BeaconState.hashTreeRoot - 32 balances 1.1558 ms/op 1.5155 ms/op 0.76
BeaconState.hashTreeRoot - 512 balances 13.021 ms/op 14.175 ms/op 0.92
BeaconState.hashTreeRoot - 250000 balances 229.69 ms/op 198.01 ms/op 1.16
aggregationBits - 2048 els - zipIndexesInBitList 17.372 us/op 16.028 us/op 1.08
regular array get 100000 times 33.889 us/op 33.643 us/op 1.01
wrappedArray get 100000 times 33.729 us/op 33.760 us/op 1.00
arrayWithProxy get 100000 times 15.008 ms/op 15.415 ms/op 0.97
ssz.Root.equals 225.00 ns/op 232.00 ns/op 0.97
byteArrayEquals 240.00 ns/op 242.00 ns/op 0.99
shuffle list - 16384 els 7.2941 ms/op 7.1398 ms/op 1.02
shuffle list - 250000 els 106.07 ms/op 103.13 ms/op 1.03
processSlot - 1 slots 18.613 us/op 16.449 us/op 1.13
processSlot - 32 slots 4.6236 ms/op 3.3455 ms/op 1.38
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 59.435 ms/op 56.011 ms/op 1.06
getCommitteeAssignments - req 1 vs - 250000 vc 2.6181 ms/op 2.7127 ms/op 0.97
getCommitteeAssignments - req 100 vs - 250000 vc 3.9291 ms/op 3.9565 ms/op 0.99
getCommitteeAssignments - req 1000 vs - 250000 vc 4.1996 ms/op 4.2635 ms/op 0.99
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 5.3100 ns/op 5.1400 ns/op 1.03
state getBlockRootAtSlot - 250000 vs - 7PWei 702.82 ns/op 565.77 ns/op 1.24
computeProposers - vc 250000 9.8476 ms/op 9.3084 ms/op 1.06
computeEpochShuffling - vc 250000 110.77 ms/op 109.66 ms/op 1.01
getNextSyncCommittee - vc 250000 159.41 ms/op 157.46 ms/op 1.01
computeSigningRoot for AttestationData 22.533 us/op 28.365 us/op 0.79
hash AttestationData serialized data then Buffer.toString(base64) 2.4297 us/op 2.4050 us/op 1.01
toHexString serialized data 1.1873 us/op 1.1546 us/op 1.03
Buffer.toString(base64) 257.82 ns/op 258.46 ns/op 1.00

by benchmarkbot/action

@wemeetagain wemeetagain merged commit 4fa6327 into unstable Oct 18, 2023
@wemeetagain wemeetagain deleted the nflaig/remove-extra-whitespace branch October 18, 2023 13:58
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.12.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wemeetagain wemeetagain wemeetagain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nflaig @wemeetagain