-
-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: improve prerequisites for OSX users #6157
Conversation
Performance Report✔️ no performance regression detected Full benchmark results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about adding os specifics like this, @matthewkeil probably has some thoughts. Does the docs rework maybe address this is a nicer way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of nits but overall strong start! Welcome to the team 🚀
b482b5d
to
d82d729
Compare
Co-authored-by: Nico Flaig <[email protected]>
Co-authored-by: Nico Flaig <[email protected]>
Co-authored-by: Matthew Keil <[email protected]>
Co-authored-by: Matthew Keil <[email protected]>
d82d729
to
f59b5fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎸
🎉 This PR is included in v1.13.0 🎉 |
Motivation
Improves DX for OSX users
Description
Add some extra prerequisites for OSX users so that they can build/test
lodestar
.python
is required for mac silicon users as https://github.com/ChainSafe/blst-ts doesn't provide a prebuild for those CPUs