test: migrate logger tests to vitest #6220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazarhussain
commented
Dec 21, 2023
| import {expose} from "@chainsafe/threads/worker"; | ||
|
|
||
| const parentPort = worker.parentPort; | ||
| const workerData = worker.workerData as {logFilepath: string}; | ||
| const workerData = worker.workerData; |
There was a problem hiding this comment.
Have to convert this TS file to JS as Worker can only load the JS files. Earlier this was handled by runtime compilation with global node loader.
nazarhussain
commented
Dec 21, 2023
| logger.restoreStubs(); | ||
| expect(logger.getLogs()).deep.equals([output[format]]); | ||
|
|
||
| expect((console as TestConsole)._stdout.write).toHaveBeenNthCalledWith(1, `${output[format]}\n`); |
There was a problem hiding this comment.
The last \n added in expectation, which was earlier removed by stubLoggerForProcessStd.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## unstable #6220 +/- ##
=========================================
Coverage 84.46% 84.46%
=========================================
Files 177 177
Lines 14913 14913
Branches 909 909
=========================================
Hits 12596 12596
Misses 2294 2294
Partials 23 23 |
nflaig
reviewed
Dec 21, 2023
Performance Report✔️ no performance regression detected Full benchmark results
|
nflaig
reviewed
Dec 21, 2023
| @@ -27,13 +25,13 @@ describe("Json helper", () => { | |||
|
|
|||
| // Functions | |||
| // eslint-disable-next-line @typescript-eslint/no-empty-function | |||
| {id: "function", arg: function () {}, json: "function () { }"}, | |||
| {id: "function", arg: function () {}, json: "function() {\n }"}, | |||
There was a problem hiding this comment.
I don't really get from where the line breaks are coming
Function toString() does not seem to add them
lodestar/packages/logger/src/utils/json.ts
Lines 25 to 26 in 2530fae
See output
> (function() {}).toString()
'function() {}'Or is this related to what you mentioned here #6220 (comment)?
There was a problem hiding this comment.
Yes, the stub earlier was removing the new line break from the output. As no source code is changed related to encoding, so reset assure it behaves it had been before.
There was a problem hiding this comment.
But I still don't get why there would be a new line in the middle of the function, what's adding that?
There was a problem hiding this comment.
When vitest transpile the TS code to JS the esbuild/rollup add a new line at the function definition, that translates to new line when we do the function.string().
const arg = function () {
};
console.log(arg.toString());I could not find the direct fix tin the Rollup config for it, and fixing the test fixture is not destructive in this case, so left it like that.
There was a problem hiding this comment.
I also don't think it is worth to try and find a fix for it, just good to know why these new lines are there
nflaig
reviewed
Dec 25, 2023
There was a problem hiding this comment.
should this file be renamed now?
There was a problem hiding this comment.
Will remove it completely when migrate all the tests.
nflaig
approved these changes
Dec 25, 2023
|
🎉 This PR is included in v1.14.0 🎉 |
ensi321
pushed a commit
to ensi321/lodestar
that referenced
this pull request
Jan 22, 2024
* Migrate logger tests to vitest * Remove lint comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Consolidate the testing frameworks and migrate to vitest.
Description
Migrate
loggertests to vitest.Steps to test or reproduce