Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add Ephemery Deneb fork epoch #6287

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Conversation

taxmeifyoucan
Copy link
Contributor

Ephemery will be forking to Deneb at epoch 5 starting from iteration 111. To continue supporting the network, Lodestar config needs to be updated.

I am opening PR to kick it off but there might be more configuration needed, cc @atkinsonholly

@taxmeifyoucan taxmeifyoucan requested a review from a team as a code owner January 12, 2024 06:29
@CLAassistant
Copy link

CLAassistant commented Jan 12, 2024

CLA assistant check
All committers have signed the CLA.

@taxmeifyoucan taxmeifyoucan changed the title Add Ephemery Deneb fork epoch fix: add Ephemery Deneb fork epoch Jan 12, 2024
nflaig
nflaig previously approved these changes Jan 12, 2024
Copy link
Member

@nflaig nflaig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @taxmeifyoucan, if there are further changes required we can add them separately.

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

Merging #6287 (44ee370) into unstable (aa87c54) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff            @@
##           unstable    #6287   +/-   ##
=========================================
  Coverage     80.38%   80.38%           
=========================================
  Files           202      202           
  Lines         19620    19620           
  Branches       1176     1176           
=========================================
  Hits          15771    15771           
  Misses         3821     3821           
  Partials         28       28           

@nflaig nflaig enabled auto-merge (squash) January 12, 2024 16:52
@nflaig nflaig merged commit 5e69423 into ChainSafe:unstable Jan 12, 2024
14 of 15 checks passed
@philknows
Copy link
Member

Thanks for getting this in! We're cutting an rc.2 with this and pending testing over the weekend will get released by Monday. Please reach out in Discord if you need to get our attention for anything.

@wemeetagain
Copy link
Member

🎉 This PR is included in v1.14.0 🎉

ensi321 pushed a commit to ensi321/lodestar that referenced this pull request Jan 22, 2024
* Add Ephemery Deneb fork epoch

* Extra new line

---------

Co-authored-by: Nico Flaig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants