-
-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: regen to use different state caches based on nHistoricalStates flag #6359
Conversation
Performance Report✔️ no performance regression detected Full benchmark results
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## unstable #6359 +/- ##
============================================
- Coverage 60.15% 59.95% -0.20%
============================================
Files 407 399 -8
Lines 46511 43592 -2919
Branches 1550 1382 -168
============================================
- Hits 27980 26137 -1843
+ Misses 18499 17426 -1073
+ Partials 32 29 -3 |
e2e tests are stable, passed 6 times. The key thing is to use |
8c18c82
to
0b90609
Compare
decide to separate this PR to multiple PRs to make it easier to review |
Motivation
nHistoricalStates
flag, by default leave itfalse
Description
chain.nHistoricalStates
flagchain.maxBlockStates
(default to 32) for the new block state andchain.maxCPStateEpochsInMemory
(default to 2) for the persistent cp stateTradeoff of this approach:
part of #5968