Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix code coverage #6410

Merged
merged 12 commits into from
Feb 8, 2024
Merged

test: fix code coverage #6410

merged 12 commits into from
Feb 8, 2024

Conversation

nazarhussain
Copy link
Contributor

Motivation

To have consistent and valid code coverage data.

Description

  • Fix the broken coverage upload
  • All the packages were uploaded with same root dir as src and overriding the coverage data of other packages.
  • Remove unnecessary coverage flags per package, we can always do that by navigating to package directory.
  • Add a coverage flag unit to keep it separate, in case we introduce integration coverage in future.

Steps to test or reproduce

  • Run all the tests.

@nazarhussain nazarhussain requested a review from a team as a code owner February 8, 2024 13:33
@nazarhussain nazarhussain self-assigned this Feb 8, 2024
nazarhussain
nazarhussain commented Feb 8, 2024
View reviewed changes
.github/workflows/test.yml
@@ -194,7 +194,12 @@ jobs:
# if: ${{ failure() && steps.unit_tests.conclusion == 'failure' }}

- name: Upload coverage data
run: yarn coverage
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tasks are not more valid as npm package codecov is deprecated. And they recommend to use new native binaries instead.
https://about.codecov.io/blog/introducing-codecovs-new-uploader/

nazarhussain
nazarhussain commented Feb 8, 2024
View reviewed changes
package.json
@@ -54,7 +53,6 @@
"@typescript-eslint/parser": "6.7.2",
"@vitest/coverage-v8": "^1.2.1",
"@vitest/browser": "^1.2.1",
"codecov": "^3.8.3",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This package is deprecated. https://about.codecov.io/blog/codecov-uploader-deprecation-plan/

@codecov Codecov
Copy link

codecov bot commented Feb 8, 2024 •
edited
Loading

Codecov Report

Merging #6410 (bdda8e3) into unstable (d1caa1f) will increase coverage by 1.58%.
Report is 1 commits behind head on unstable.
The diff coverage is n/a.

Additional details and impacted files 
@@             Coverage Diff              @@
##           unstable    #6410      +/-   ##
============================================
+ Coverage     60.14%   61.72%   +1.58%     
============================================
  Files           407      553     +146     
  Lines         46512    57844   +11332     
  Branches       1551     1830     +279     
============================================
+ Hits          27975    35707    +7732     
- Misses        18505    22100    +3595     
- Partials         32       37       +5

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 8, 2024 •
edited
Loading

⚠️ Performance Alert ⚠️

Possible performance regression was detected for some benchmarks.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold.

Benchmark suite Current: 5f94fbe Previous: cb99fc4 Ratio
getSlashingsAndExits - 2k 9.3497 ms/op 376.54 us/op 24.83
fastMsgIdFn h32 xxhash / 1000 bytes 1.7580 us/op 484.00 ns/op 3.63
forkChoice updateHead vc 600000 bc 64 eq 300000 67.789 ms/op 15.818 ms/op 4.29
Full benchmark results
Benchmark suite Current: 5f94fbe Previous: cb99fc4 Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 630.64 us/op 781.72 us/op 0.81
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 126.97 us/op 81.024 us/op 1.57
BLS verify - blst-native 1.3411 ms/op 1.2785 ms/op 1.05
BLS verifyMultipleSignatures 3 - blst-native 2.8161 ms/op 2.6808 ms/op 1.05
BLS verifyMultipleSignatures 8 - blst-native 6.2182 ms/op 5.8822 ms/op 1.06
BLS verifyMultipleSignatures 32 - blst-native 22.641 ms/op 21.498 ms/op 1.05
BLS verifyMultipleSignatures 64 - blst-native 46.308 ms/op 41.692 ms/op 1.11
BLS verifyMultipleSignatures 128 - blst-native 90.259 ms/op 82.488 ms/op 1.09
BLS deserializing 10000 signatures 967.96 ms/op 903.85 ms/op 1.07
BLS deserializing 100000 signatures 9.4991 s/op 9.2095 s/op 1.03
BLS verifyMultipleSignatures - same message - 3 - blst-native 1.3775 ms/op 1.3066 ms/op 1.05
BLS verifyMultipleSignatures - same message - 8 - blst-native 1.5653 ms/op 1.4719 ms/op 1.06
BLS verifyMultipleSignatures - same message - 32 - blst-native 2.5035 ms/op 2.7219 ms/op 0.92
BLS verifyMultipleSignatures - same message - 64 - blst-native 3.8528 ms/op 4.2498 ms/op 0.91
BLS verifyMultipleSignatures - same message - 128 - blst-native 6.3750 ms/op 7.4937 ms/op 0.85
BLS aggregatePubkeys 32 - blst-native 27.621 us/op 27.126 us/op 1.02
BLS aggregatePubkeys 128 - blst-native 104.03 us/op 99.345 us/op 1.05
notSeenSlots=1 numMissedVotes=1 numBadVotes=10 95.200 ms/op 49.096 ms/op 1.94
notSeenSlots=1 numMissedVotes=0 numBadVotes=4 103.59 ms/op 46.645 ms/op 2.22
notSeenSlots=2 numMissedVotes=1 numBadVotes=10 60.964 ms/op 32.538 ms/op 1.87
getSlashingsAndExits - default max 243.07 us/op 216.85 us/op 1.12
getSlashingsAndExits - 2k 9.3497 ms/op 376.54 us/op 24.83
proposeBlockBody type=full, size=empty 6.8371 ms/op 5.0356 ms/op 1.36
isKnown best case - 1 super set check 623.00 ns/op 296.00 ns/op 2.10
isKnown normal case - 2 super set checks 547.00 ns/op 289.00 ns/op 1.89
isKnown worse case - 16 super set checks 433.00 ns/op 285.00 ns/op 1.52
CheckpointStateCache - add get delete 6.0540 us/op 4.8990 us/op 1.24
validate api signedAggregateAndProof - struct 2.8752 ms/op 2.7149 ms/op 1.06
validate gossip signedAggregateAndProof - struct 2.8717 ms/op 2.7206 ms/op 1.06
validate gossip attestation - vc 640000 1.4262 ms/op 1.3251 ms/op 1.08
batch validate gossip attestation - vc 640000 - chunk 32 184.75 us/op 157.06 us/op 1.18
batch validate gossip attestation - vc 640000 - chunk 64 174.04 us/op 139.37 us/op 1.25
batch validate gossip attestation - vc 640000 - chunk 128 180.89 us/op 134.26 us/op 1.35
batch validate gossip attestation - vc 640000 - chunk 256 173.77 us/op 133.63 us/op 1.30
pickEth1Vote - no votes 1.7873 ms/op 1.1459 ms/op 1.56
pickEth1Vote - max votes 19.883 ms/op 8.9590 ms/op 2.22
pickEth1Vote - Eth1Data hashTreeRoot value x2048 24.656 ms/op 22.168 ms/op 1.11
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 46.079 ms/op 24.552 ms/op 1.88
pickEth1Vote - Eth1Data fastSerialize value x2048 945.86 us/op 587.73 us/op 1.61
pickEth1Vote - Eth1Data fastSerialize tree x2048 9.7834 ms/op 6.0949 ms/op 1.61
bytes32 toHexString 1.1220 us/op 475.00 ns/op 2.36
bytes32 Buffer.toString(hex) 378.00 ns/op 281.00 ns/op 1.35
bytes32 Buffer.toString(hex) from Uint8Array 698.00 ns/op 406.00 ns/op 1.72
bytes32 Buffer.toString(hex) + 0x 413.00 ns/op 282.00 ns/op 1.46
Object access 1 prop 0.30500 ns/op 0.16100 ns/op 1.89
Map access 1 prop 0.21600 ns/op 0.15000 ns/op 1.44
Object get x1000 11.396 ns/op 7.0120 ns/op 1.63
Map get x1000 1.2870 ns/op 0.73300 ns/op 1.76
Object set x1000 117.74 ns/op 48.439 ns/op 2.43
Map set x1000 72.553 ns/op 41.436 ns/op 1.75
Return object 10000 times 0.38560 ns/op 0.24350 ns/op 1.58
Throw Error 10000 times 5.2352 us/op 3.8205 us/op 1.37
fastMsgIdFn sha256 / 200 bytes 5.0850 us/op 3.2960 us/op 1.54
fastMsgIdFn h32 xxhash / 200 bytes 533.00 ns/op 286.00 ns/op 1.86
fastMsgIdFn h64 xxhash / 200 bytes 507.00 ns/op 360.00 ns/op 1.41
fastMsgIdFn sha256 / 1000 bytes 13.205 us/op 11.485 us/op 1.15
fastMsgIdFn h32 xxhash / 1000 bytes 1.7580 us/op 484.00 ns/op 3.63
fastMsgIdFn h64 xxhash / 1000 bytes 1.1200 us/op 460.00 ns/op 2.43
fastMsgIdFn sha256 / 10000 bytes 121.28 us/op 105.14 us/op 1.15
fastMsgIdFn h32 xxhash / 10000 bytes 3.1790 us/op 2.0590 us/op 1.54
fastMsgIdFn h64 xxhash / 10000 bytes 2.1560 us/op 1.4340 us/op 1.50
send data - 1000 256B messages 29.845 ms/op 22.829 ms/op 1.31
send data - 1000 512B messages 41.654 ms/op 28.667 ms/op 1.45
send data - 1000 1024B messages 52.220 ms/op 40.220 ms/op 1.30
send data - 1000 1200B messages 63.107 ms/op 40.766 ms/op 1.55
send data - 1000 2048B messages 78.478 ms/op 53.480 ms/op 1.47
send data - 1000 4096B messages 62.286 ms/op 47.366 ms/op 1.32
send data - 1000 16384B messages 179.07 ms/op 116.28 ms/op 1.54
send data - 1000 65536B messages 636.61 ms/op 441.47 ms/op 1.44
enrSubnets - fastDeserialize 64 bits 2.2340 us/op 1.2340 us/op 1.81
enrSubnets - ssz BitVector 64 bits 614.00 ns/op 404.00 ns/op 1.52
enrSubnets - fastDeserialize 4 bits 264.00 ns/op 170.00 ns/op 1.55
enrSubnets - ssz BitVector 4 bits 635.00 ns/op 414.00 ns/op 1.53
prioritizePeers score -10:0 att 32-0.1 sync 2-0 140.57 us/op 96.828 us/op 1.45
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 172.21 us/op 128.86 us/op 1.34
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 275.18 us/op 159.72 us/op 1.72
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 400.16 us/op 288.64 us/op 1.39
prioritizePeers score 0:0 att 64-1 sync 4-1 484.42 us/op 335.02 us/op 1.45
array of 16000 items push then shift 1.8937 us/op 1.6016 us/op 1.18
LinkedList of 16000 items push then shift 12.947 ns/op 8.7500 ns/op 1.48
array of 16000 items push then pop 153.16 ns/op 95.453 ns/op 1.60
LinkedList of 16000 items push then pop 12.172 ns/op 8.5970 ns/op 1.42
array of 24000 items push then shift 2.6945 us/op 2.5319 us/op 1.06
LinkedList of 24000 items push then shift 11.730 ns/op 8.8390 ns/op 1.33
array of 24000 items push then pop 211.76 ns/op 113.85 ns/op 1.86
LinkedList of 24000 items push then pop 11.733 ns/op 8.6660 ns/op 1.35
intersect bitArray bitLen 8 8.0610 ns/op 5.8920 ns/op 1.37
intersect array and set length 8 114.94 ns/op 67.392 ns/op 1.71
intersect bitArray bitLen 128 47.552 ns/op 34.590 ns/op 1.37
intersect array and set length 128 1.2918 us/op 836.02 ns/op 1.55
bitArray.getTrueBitIndexes() bitLen 128 2.3050 us/op 1.3860 us/op 1.66
bitArray.getTrueBitIndexes() bitLen 248 4.1140 us/op 2.3620 us/op 1.74
bitArray.getTrueBitIndexes() bitLen 512 8.8970 us/op 4.7030 us/op 1.89
Buffer.concat 32 items 1.5080 us/op 917.00 ns/op 1.64
Uint8Array.set 32 items 2.7530 us/op 1.8880 us/op 1.46
Set add up to 64 items then delete first 5.4248 us/op 4.2949 us/op 1.26
OrderedSet add up to 64 items then delete first 8.1205 us/op 5.3814 us/op 1.51
Set add up to 64 items then delete last 6.2021 us/op 5.0855 us/op 1.22
OrderedSet add up to 64 items then delete last 8.3957 us/op 6.5443 us/op 1.28
Set add up to 64 items then delete middle 5.9214 us/op 4.7267 us/op 1.25
OrderedSet add up to 64 items then delete middle 9.6648 us/op 7.4349 us/op 1.30
Set add up to 128 items then delete first 12.241 us/op 9.4403 us/op 1.30
OrderedSet add up to 128 items then delete first 17.005 us/op 12.747 us/op 1.33
Set add up to 128 items then delete last 12.005 us/op 9.9304 us/op 1.21
OrderedSet add up to 128 items then delete last 16.466 us/op 11.817 us/op 1.39
Set add up to 128 items then delete middle 12.421 us/op 9.7361 us/op 1.28
OrderedSet add up to 128 items then delete middle 24.394 us/op 17.330 us/op 1.41
Set add up to 256 items then delete first 24.612 us/op 20.382 us/op 1.21
OrderedSet add up to 256 items then delete first 35.977 us/op 25.520 us/op 1.41
Set add up to 256 items then delete last 24.092 us/op 18.147 us/op 1.33
OrderedSet add up to 256 items then delete last 34.329 us/op 23.422 us/op 1.47
Set add up to 256 items then delete middle 24.090 us/op 18.422 us/op 1.31
OrderedSet add up to 256 items then delete middle 61.886 us/op 45.030 us/op 1.37
transfer serialized Status (84 B) 2.4930 us/op 1.7060 us/op 1.46
copy serialized Status (84 B) 1.9430 us/op 1.2770 us/op 1.52
transfer serialized SignedVoluntaryExit (112 B) 2.5980 us/op 1.9130 us/op 1.36
copy serialized SignedVoluntaryExit (112 B) 1.8730 us/op 1.4600 us/op 1.28
transfer serialized ProposerSlashing (416 B) 3.6460 us/op 2.9950 us/op 1.22
copy serialized ProposerSlashing (416 B) 3.2750 us/op 2.8340 us/op 1.16
transfer serialized Attestation (485 B) 2.8370 us/op 3.2850 us/op 0.86
copy serialized Attestation (485 B) 2.4650 us/op 2.8780 us/op 0.86
transfer serialized AttesterSlashing (33232 B) 2.5360 us/op 3.2000 us/op 0.79
copy serialized AttesterSlashing (33232 B) 19.841 us/op 7.1850 us/op 2.76
transfer serialized Small SignedBeaconBlock (128000 B) 4.2130 us/op 3.8180 us/op 1.10
copy serialized Small SignedBeaconBlock (128000 B) 37.566 us/op 15.861 us/op 2.37
transfer serialized Avg SignedBeaconBlock (200000 B) 4.8130 us/op 3.9360 us/op 1.22
copy serialized Avg SignedBeaconBlock (200000 B) 55.576 us/op 24.257 us/op 2.29
transfer serialized BlobsSidecar (524380 B) 6.0070 us/op 3.8080 us/op 1.58
copy serialized BlobsSidecar (524380 B) 182.70 us/op 110.01 us/op 1.66
transfer serialized Big SignedBeaconBlock (1000000 B) 6.8540 us/op 3.8330 us/op 1.79
copy serialized Big SignedBeaconBlock (1000000 B) 413.44 us/op 158.52 us/op 2.61
pass gossip attestations to forkchoice per slot 5.6507 ms/op 4.2971 ms/op 1.32
forkChoice updateHead vc 100000 bc 64 eq 0 907.07 us/op 703.47 us/op 1.29
forkChoice updateHead vc 600000 bc 64 eq 0 9.2774 ms/op 4.1302 ms/op 2.25
forkChoice updateHead vc 1000000 bc 64 eq 0 9.3299 ms/op 6.8351 ms/op 1.37
forkChoice updateHead vc 600000 bc 320 eq 0 5.0957 ms/op 4.0866 ms/op 1.25
forkChoice updateHead vc 600000 bc 1200 eq 0 5.6011 ms/op 4.2527 ms/op 1.32
forkChoice updateHead vc 600000 bc 7200 eq 0 8.9275 ms/op 5.1423 ms/op 1.74
forkChoice updateHead vc 600000 bc 64 eq 1000 13.079 ms/op 10.954 ms/op 1.19
forkChoice updateHead vc 600000 bc 64 eq 10000 14.722 ms/op 11.642 ms/op 1.26
forkChoice updateHead vc 600000 bc 64 eq 300000 67.789 ms/op 15.818 ms/op 4.29
computeDeltas 500000 validators 300 proto nodes 8.2101 ms/op 6.4010 ms/op 1.28
computeDeltas 500000 validators 1200 proto nodes 7.9884 ms/op 6.6543 ms/op 1.20
computeDeltas 500000 validators 7200 proto nodes 7.7905 ms/op 6.5841 ms/op 1.18
computeDeltas 750000 validators 300 proto nodes 11.500 ms/op 10.381 ms/op 1.11
computeDeltas 750000 validators 1200 proto nodes 11.044 ms/op 11.263 ms/op 0.98
computeDeltas 750000 validators 7200 proto nodes 11.361 ms/op 10.876 ms/op 1.04
computeDeltas 1400000 validators 300 proto nodes 22.952 ms/op 21.317 ms/op 1.08
computeDeltas 1400000 validators 1200 proto nodes 21.866 ms/op 20.108 ms/op 1.09
computeDeltas 1400000 validators 7200 proto nodes 23.127 ms/op 20.248 ms/op 1.14
computeDeltas 2100000 validators 300 proto nodes 37.940 ms/op 29.790 ms/op 1.27
computeDeltas 2100000 validators 1200 proto nodes 34.022 ms/op 30.143 ms/op 1.13
computeDeltas 2100000 validators 7200 proto nodes 31.311 ms/op 29.880 ms/op 1.05
altair processAttestation - 250000 vs - 7PWei normalcase 4.1231 ms/op 3.1623 ms/op 1.30
altair processAttestation - 250000 vs - 7PWei worstcase 5.0235 ms/op 4.6440 ms/op 1.08
altair processAttestation - setStatus - 1/6 committees join 211.28 us/op 203.37 us/op 1.04
altair processAttestation - setStatus - 1/3 committees join 424.94 us/op 382.98 us/op 1.11
altair processAttestation - setStatus - 1/2 committees join 568.15 us/op 516.15 us/op 1.10
altair processAttestation - setStatus - 2/3 committees join 771.21 us/op 636.69 us/op 1.21
altair processAttestation - setStatus - 4/5 committees join 1.2203 ms/op 959.94 us/op 1.27
altair processAttestation - setStatus - 100% committees join 1.1331 ms/op 1.1557 ms/op 0.98
altair processBlock - 250000 vs - 7PWei normalcase 12.032 ms/op 13.730 ms/op 0.88
altair processBlock - 250000 vs - 7PWei normalcase hashState 41.066 ms/op 42.443 ms/op 0.97
altair processBlock - 250000 vs - 7PWei worstcase 48.965 ms/op 41.982 ms/op 1.17
altair processBlock - 250000 vs - 7PWei worstcase hashState 102.52 ms/op 104.01 ms/op 0.99
phase0 processBlock - 250000 vs - 7PWei normalcase 4.6048 ms/op 3.0790 ms/op 1.50
phase0 processBlock - 250000 vs - 7PWei worstcase 37.580 ms/op 33.161 ms/op 1.13
altair processEth1Data - 250000 vs - 7PWei normalcase 833.93 us/op 735.01 us/op 1.13
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 12.876 us/op 21.139 us/op 0.61
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 83.078 us/op 73.998 us/op 1.12
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 28.571 us/op 23.975 us/op 1.19
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 16.820 us/op 12.388 us/op 1.36
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 196.69 us/op 238.39 us/op 0.83
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 1.5713 ms/op 2.0913 ms/op 0.75
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 1.9908 ms/op 2.4322 ms/op 0.82
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 2.1267 ms/op 2.3467 ms/op 0.91
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 4.6371 ms/op 5.2909 ms/op 0.88
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 3.1554 ms/op 2.6495 ms/op 1.19
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 7.8052 ms/op 6.5981 ms/op 1.18
Tree 40 250000 create 419.49 ms/op 535.46 ms/op 0.78
Tree 40 250000 get(125000) 222.82 ns/op 228.22 ns/op 0.98
Tree 40 250000 set(125000) 1.2181 us/op 1.4383 us/op 0.85
Tree 40 250000 toArray() 24.954 ms/op 24.810 ms/op 1.01
Tree 40 250000 iterate all - toArray() + loop 24.998 ms/op 25.252 ms/op 0.99
Tree 40 250000 iterate all - get(i) 75.862 ms/op 78.896 ms/op 0.96
MutableVector 250000 create 15.058 ms/op 15.406 ms/op 0.98
MutableVector 250000 get(125000) 6.7700 ns/op 7.6170 ns/op 0.89
MutableVector 250000 set(125000) 317.48 ns/op 590.63 ns/op 0.54
MutableVector 250000 toArray() 4.0881 ms/op 4.9283 ms/op 0.83
MutableVector 250000 iterate all - toArray() + loop 4.5329 ms/op 4.7994 ms/op 0.94
MutableVector 250000 iterate all - get(i) 1.6316 ms/op 1.7937 ms/op 0.91
Array 250000 create 3.6856 ms/op 4.3540 ms/op 0.85
Array 250000 clone - spread 1.7305 ms/op 1.5474 ms/op 1.12
Array 250000 get(125000) 2.3000 ns/op 1.7390 ns/op 1.32
Array 250000 set(125000) 5.9640 ns/op 5.3690 ns/op 1.11
Array 250000 iterate all - loop 180.69 us/op 180.71 us/op 1.00
effectiveBalanceIncrements clone Uint8Array 300000 67.258 us/op 48.579 us/op 1.38
effectiveBalanceIncrements clone MutableVector 300000 591.00 ns/op 396.00 ns/op 1.49
effectiveBalanceIncrements rw all Uint8Array 300000 211.10 us/op 206.95 us/op 1.02
effectiveBalanceIncrements rw all MutableVector 300000 109.49 ms/op 103.46 ms/op 1.06
phase0 afterProcessEpoch - 250000 vs - 7PWei 117.89 ms/op 127.33 ms/op 0.93
phase0 beforeProcessEpoch - 250000 vs - 7PWei 56.578 ms/op 66.226 ms/op 0.85
altair processEpoch - mainnet_e81889 699.55 ms/op 559.10 ms/op 1.25
mainnet_e81889 - altair beforeProcessEpoch 105.89 ms/op 93.815 ms/op 1.13
mainnet_e81889 - altair processJustificationAndFinalization 28.828 us/op 17.811 us/op 1.62
mainnet_e81889 - altair processInactivityUpdates 8.2336 ms/op 6.6234 ms/op 1.24
mainnet_e81889 - altair processRewardsAndPenalties 75.802 ms/op 42.611 ms/op 1.78
mainnet_e81889 - altair processRegistryUpdates 7.3740 us/op 2.9660 us/op 2.49
mainnet_e81889 - altair processSlashings 1.1420 us/op 759.00 ns/op 1.50
mainnet_e81889 - altair processEth1DataReset 1.3580 us/op 1.8300 us/op 0.74
mainnet_e81889 - altair processEffectiveBalanceUpdates 2.5223 ms/op 1.4639 ms/op 1.72
mainnet_e81889 - altair processSlashingsReset 9.0010 us/op 7.9900 us/op 1.13
mainnet_e81889 - altair processRandaoMixesReset 9.7290 us/op 7.9420 us/op 1.23
mainnet_e81889 - altair processHistoricalRootsUpdate 1.8430 us/op 1.5950 us/op 1.16
mainnet_e81889 - altair processParticipationFlagUpdates 4.9460 us/op 6.3540 us/op 0.78
mainnet_e81889 - altair processSyncCommitteeUpdates 1.2720 us/op 2.0070 us/op 0.63
mainnet_e81889 - altair afterProcessEpoch 152.08 ms/op 124.24 ms/op 1.22
capella processEpoch - mainnet_e217614 3.1875 s/op 2.5352 s/op 1.26
mainnet_e217614 - capella beforeProcessEpoch 674.84 ms/op 486.06 ms/op 1.39
mainnet_e217614 - capella processJustificationAndFinalization 31.642 us/op 19.133 us/op 1.65
mainnet_e217614 - capella processInactivityUpdates 29.342 ms/op 21.198 ms/op 1.38
mainnet_e217614 - capella processRewardsAndPenalties 508.53 ms/op 422.81 ms/op 1.20
mainnet_e217614 - capella processRegistryUpdates 43.178 us/op 17.112 us/op 2.52
mainnet_e217614 - capella processSlashings 1.2350 us/op 578.00 ns/op 2.14
mainnet_e217614 - capella processEth1DataReset 1.0440 us/op 452.00 ns/op 2.31
mainnet_e217614 - capella processEffectiveBalanceUpdates 10.282 ms/op 5.6264 ms/op 1.83
mainnet_e217614 - capella processSlashingsReset 7.9910 us/op 3.6630 us/op 2.18
mainnet_e217614 - capella processRandaoMixesReset 12.363 us/op 4.5600 us/op 2.71
mainnet_e217614 - capella processHistoricalRootsUpdate 1.5430 us/op 427.00 ns/op 3.61
mainnet_e217614 - capella processParticipationFlagUpdates 5.2540 us/op 1.4300 us/op 3.67
mainnet_e217614 - capella afterProcessEpoch 409.58 ms/op 301.82 ms/op 1.36
phase0 processEpoch - mainnet_e58758 902.96 ms/op 436.38 ms/op 2.07
mainnet_e58758 - phase0 beforeProcessEpoch 275.08 ms/op 125.38 ms/op 2.19
mainnet_e58758 - phase0 processJustificationAndFinalization 29.985 us/op 17.257 us/op 1.74
mainnet_e58758 - phase0 processRewardsAndPenalties 70.078 ms/op 37.873 ms/op 1.85
mainnet_e58758 - phase0 processRegistryUpdates 22.754 us/op 11.921 us/op 1.91
mainnet_e58758 - phase0 processSlashings 1.3740 us/op 420.00 ns/op 3.27
mainnet_e58758 - phase0 processEth1DataReset 1.2660 us/op 426.00 ns/op 2.97
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 2.2008 ms/op 1.1714 ms/op 1.88
mainnet_e58758 - phase0 processSlashingsReset 6.5920 us/op 3.0230 us/op 2.18
mainnet_e58758 - phase0 processRandaoMixesReset 9.6290 us/op 5.8810 us/op 1.64
mainnet_e58758 - phase0 processHistoricalRootsUpdate 1.0840 us/op 543.00 ns/op 2.00
mainnet_e58758 - phase0 processParticipationRecordUpdates 8.2340 us/op 4.4510 us/op 1.85
mainnet_e58758 - phase0 afterProcessEpoch 117.69 ms/op 97.974 ms/op 1.20
phase0 processEffectiveBalanceUpdates - 250000 normalcase 2.4363 ms/op 1.3860 ms/op 1.76
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 2.3489 ms/op 1.9794 ms/op 1.19
altair processInactivityUpdates - 250000 normalcase 33.916 ms/op 23.606 ms/op 1.44
altair processInactivityUpdates - 250000 worstcase 40.867 ms/op 20.158 ms/op 2.03
phase0 processRegistryUpdates - 250000 normalcase 21.625 us/op 8.1010 us/op 2.67
phase0 processRegistryUpdates - 250000 badcase_full_deposits 670.70 us/op 410.16 us/op 1.64
phase0 processRegistryUpdates - 250000 worstcase 0.5 226.73 ms/op 125.88 ms/op 1.80
altair processRewardsAndPenalties - 250000 normalcase 66.188 ms/op 42.949 ms/op 1.54
altair processRewardsAndPenalties - 250000 worstcase 60.688 ms/op 40.880 ms/op 1.48
phase0 getAttestationDeltas - 250000 normalcase 12.410 ms/op 8.9342 ms/op 1.39
phase0 getAttestationDeltas - 250000 worstcase 11.742 ms/op 9.0759 ms/op 1.29
phase0 processSlashings - 250000 worstcase 107.20 us/op 82.023 us/op 1.31
altair processSyncCommitteeUpdates - 250000 164.93 ms/op 155.67 ms/op 1.06
BeaconState.hashTreeRoot - No change 528.00 ns/op 376.00 ns/op 1.40
BeaconState.hashTreeRoot - 1 full validator 143.37 us/op 122.80 us/op 1.17
BeaconState.hashTreeRoot - 32 full validator 1.4342 ms/op 1.5146 ms/op 0.95
BeaconState.hashTreeRoot - 512 full validator 20.297 ms/op 13.752 ms/op 1.48
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 175.78 us/op 145.10 us/op 1.21
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 2.3059 ms/op 2.1634 ms/op 1.07
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 35.516 ms/op 23.908 ms/op 1.49
BeaconState.hashTreeRoot - 1 balances 145.57 us/op 107.98 us/op 1.35
BeaconState.hashTreeRoot - 32 balances 1.2984 ms/op 1.2388 ms/op 1.05
BeaconState.hashTreeRoot - 512 balances 15.190 ms/op 13.398 ms/op 1.13
BeaconState.hashTreeRoot - 250000 balances 228.37 ms/op 229.58 ms/op 0.99
aggregationBits - 2048 els - zipIndexesInBitList 34.809 us/op 18.553 us/op 1.88
byteArrayEquals 32 91.092 ns/op 75.711 ns/op 1.20
Buffer.compare 32 66.661 ns/op 56.832 ns/op 1.17
byteArrayEquals 1024 2.8731 us/op 2.0780 us/op 1.38
Buffer.compare 1024 91.494 ns/op 71.998 ns/op 1.27
byteArrayEquals 16384 45.627 us/op 32.686 us/op 1.40
Buffer.compare 16384 305.04 ns/op 244.73 ns/op 1.25
byteArrayEquals 123687377 306.03 ms/op 263.96 ms/op 1.16
Buffer.compare 123687377 11.361 ms/op 8.9139 ms/op 1.27
byteArrayEquals 32 - diff last byte 125.01 ns/op 84.093 ns/op 1.49
Buffer.compare 32 - diff last byte 69.654 ns/op 58.951 ns/op 1.18
byteArrayEquals 1024 - diff last byte 3.2508 us/op 2.2338 us/op 1.46
Buffer.compare 1024 - diff last byte 93.553 ns/op 78.283 ns/op 1.20
byteArrayEquals 16384 - diff last byte 43.919 us/op 34.887 us/op 1.26
Buffer.compare 16384 - diff last byte 327.66 ns/op 301.11 ns/op 1.09
byteArrayEquals 123687377 - diff last byte 318.73 ms/op 272.26 ms/op 1.17
Buffer.compare 123687377 - diff last byte 12.410 ms/op 9.7619 ms/op 1.27
byteArrayEquals 32 - random bytes 7.3510 ns/op 6.2760 ns/op 1.17
Buffer.compare 32 - random bytes 66.857 ns/op 63.914 ns/op 1.05
byteArrayEquals 1024 - random bytes 7.2440 ns/op 7.1700 ns/op 1.01
Buffer.compare 1024 - random bytes 70.668 ns/op 63.377 ns/op 1.12
byteArrayEquals 16384 - random bytes 6.9960 ns/op 6.3050 ns/op 1.11
Buffer.compare 16384 - random bytes 69.758 ns/op 63.362 ns/op 1.10
byteArrayEquals 123687377 - random bytes 22.690 ns/op 9.2900 ns/op 2.44
Buffer.compare 123687377 - random bytes 89.750 ns/op 76.700 ns/op 1.17
regular array get 100000 times 57.491 us/op 46.504 us/op 1.24
wrappedArray get 100000 times 56.499 us/op 46.481 us/op 1.22
arrayWithProxy get 100000 times 18.183 ms/op 14.805 ms/op 1.23
ssz.Root.equals 70.014 ns/op 58.481 ns/op 1.20
byteArrayEquals 68.908 ns/op 57.281 ns/op 1.20
Buffer.compare 17.091 ns/op 12.741 ns/op 1.34
shuffle list - 16384 els 8.2203 ms/op 7.3652 ms/op 1.12
shuffle list - 250000 els 120.08 ms/op 106.96 ms/op 1.12
processSlot - 1 slots 22.164 us/op 18.632 us/op 1.19
processSlot - 32 slots 5.0955 ms/op 3.2672 ms/op 1.56
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 76.362 ms/op 61.870 ms/op 1.23
getCommitteeAssignments - req 1 vs - 250000 vc 3.7179 ms/op 2.5147 ms/op 1.48
getCommitteeAssignments - req 100 vs - 250000 vc 4.3062 ms/op 3.7257 ms/op 1.16
getCommitteeAssignments - req 1000 vs - 250000 vc 4.6359 ms/op 4.0430 ms/op 1.15
findModifiedValidators - 10000 modified validators 820.11 ms/op 531.88 ms/op 1.54
findModifiedValidators - 1000 modified validators 578.64 ms/op 467.55 ms/op 1.24
findModifiedValidators - 100 modified validators 601.10 ms/op 464.25 ms/op 1.29
findModifiedValidators - 10 modified validators 523.57 ms/op 427.86 ms/op 1.22
findModifiedValidators - 1 modified validators 461.06 ms/op 425.03 ms/op 1.08
findModifiedValidators - no difference 447.28 ms/op 420.26 ms/op 1.06
compare ViewDUs 5.4088 s/op 4.8502 s/op 1.12
compare each validator Uint8Array 2.1516 s/op 2.0767 s/op 1.04
compare ViewDU to Uint8Array 1.7271 s/op 1.4589 s/op 1.18
migrate state 1000000 validators, 24 modified, 0 new 1.0563 s/op 881.48 ms/op 1.20
migrate state 1000000 validators, 1700 modified, 1000 new 1.2777 s/op 1.0784 s/op 1.18
migrate state 1000000 validators, 3400 modified, 2000 new 1.5241 s/op 1.3290 s/op 1.15
migrate state 1500000 validators, 24 modified, 0 new 1.0491 s/op 770.13 ms/op 1.36
migrate state 1500000 validators, 1700 modified, 1000 new 1.3061 s/op 1.1069 s/op 1.18
migrate state 1500000 validators, 3400 modified, 2000 new 1.8015 s/op 1.2666 s/op 1.42
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 5.7000 ns/op 4.2500 ns/op 1.34
state getBlockRootAtSlot - 250000 vs - 7PWei 767.06 ns/op 849.71 ns/op 0.90
computeProposers - vc 250000 10.643 ms/op 8.8213 ms/op 1.21
computeEpochShuffling - vc 250000 121.38 ms/op 103.30 ms/op 1.17
getNextSyncCommittee - vc 250000 210.46 ms/op 147.99 ms/op 1.42
computeSigningRoot for AttestationData 34.317 us/op 25.285 us/op 1.36
hash AttestationData serialized data then Buffer.toString(base64) 2.5649 us/op 2.3199 us/op 1.11
toHexString serialized data 2.0025 us/op 1.1311 us/op 1.77
Buffer.toString(base64) 315.75 ns/op 227.78 ns/op 1.39

by benchmarkbot/action

jeluard
jeluard reviewed Feb 8, 2024
View reviewed changes
Copy link
Contributor

@jeluard jeluard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub actions could be kept up-to-date using dependabot but looks like it's not use on purpose?

@nflaig nflaig changed the title fix: fix code coverage test: fix code coverage Feb 8, 2024
@nazarhussain
Copy link
Contributor Author

GitHub actions could be kept up-to-date using dependabot but looks like it's not use on purpose?

Yes we don't like to use some bot contributions. 😄

@jeluard
Copy link
Contributor

jeluard commented Feb 8, 2024

GitHub actions could be kept up-to-date using dependabot but looks like it's not use on purpose?

Yes we don't like to use some bot contributions. 😄

Makes sense, although they could be restricted to GitHub actions only.

jeluard
jeluard reviewed Feb 8, 2024
View reviewed changes
.codecov.yml Show resolved Hide resolved
.github/workflows/test.yml Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
nflaig
nflaig reviewed Feb 8, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@nazarhussain nazarhussain requested a review from nflaig February 8, 2024 15:34
@nazarhussain nazarhussain requested a review from jeluard February 8, 2024 15:37
@nazarhussain nazarhussain merged commit c98a48a into unstable Feb 8, 2024
11 of 15 checks passed
@nazarhussain nazarhussain deleted the nh/fix-ci-coverage branch February 8, 2024 15:59
@nflaig nflaig mentioned this pull request Feb 9, 2024
Open
14 tasks
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.16.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeluard jeluard jeluard approved these changes

@nflaig nflaig Awaiting requested review from nflaig

Assignees

@nazarhussain nazarhussain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nazarhussain @jeluard @wemeetagain @nflaig