feat: warning log if primary beacon node is unhealthy #6921
+46
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nflaig
commented
Jun 29, 2024
| @@ -42,5 +42,6 @@ export function getClient(opts: HttpClientOptions, modules: ClientModules): ApiC | |||
| node: node.getClient(config, httpClient), | |||
| proof: proof.getClient(config, httpClient), | |||
| validator: validator.getClient(config, httpClient), | |||
| httpClient, | |||
There was a problem hiding this comment.
Alternative to exposing the http client here would be to emit the warning inside the http client itself but that's not ideal either because a) it does not have any context to what it is connected meaning the log message would have to be more generic and b) it's does not have access to the clock, could emit the warning at an arbitrary interval but emitting on validator makes more sense to me.
| @@ -134,6 +134,19 @@ export class Validator { | |||
| this.clock.start(this.controller.signal); | |||
| this.chainHeaderTracker.start(this.controller.signal); | |||
|
|
|||
| // Add notifier to warn user if primary node is unhealthy as there might | |||
There was a problem hiding this comment.
Something to consider is a dedicated notifier as we have it in the beacon node, this would allow to emit further information every epoch / slot, for example the statuses of imported validators / active keys, etc.
Performance Report✔️ no performance regression detected Full benchmark results
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #6921 +/- ##
============================================
- Coverage 62.52% 62.50% -0.02%
============================================
Files 575 575
Lines 60985 61002 +17
Branches 2118 2127 +9
============================================
+ Hits 38128 38131 +3
- Misses 22818 22832 +14
Partials 39 39 |
nflaig
changed the title
wemeetagain
approved these changes
Jul 5, 2024
|
🎉 This PR is included in v1.20.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #6611
Description
Add warning log if primary beacon node is unhealthy
Related to #6415