Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only return local keys from /eth/v1/keystores #7215

Merged
merged 2 commits into from
Nov 3, 2024
Merged

fix: only return local keys from /eth/v1/keystores #7215

merged 2 commits into from
Nov 3, 2024

Conversation

nflaig
Copy link
Member

@nflaig nflaig commented Nov 1, 2024

Motivation

See #7213

Description

Only return local keys from /eth/v1/keystores

As per spec:

List all validating pubkeys known to and decrypted by this keymanager binary

@nflaig nflaig requested a review from a team as a code owner November 1, 2024 17:27
@codecov Codecov
Copy link

codecov bot commented Nov 1, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.39%. Comparing base (06b4c2d) to head (889163e).
Report is 2 commits behind head on unstable.

Additional details and impacted files 
@@            Coverage Diff            @@
##           unstable    #7215   +/-   ##
=========================================
  Coverage     49.38%   49.39%           
=========================================
  Files           599      599           
  Lines         39956    39956           
  Branches       2097     2106    +9     
=========================================
+ Hits          19733    19735    +2     
+ Misses        20185    20183    -2     
  Partials         38       38

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2024 •
edited
Loading

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: a58c487 Previous: 06b4c2d Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 1.9152 ms/op 2.2642 ms/op 0.85
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 43.317 us/op 69.775 us/op 0.62
BLS verify - blst 754.32 us/op 1.0233 ms/op 0.74
BLS verifyMultipleSignatures 3 - blst 1.1727 ms/op 1.5842 ms/op 0.74
BLS verifyMultipleSignatures 8 - blst 1.6393 ms/op 2.5115 ms/op 0.65
BLS verifyMultipleSignatures 32 - blst 4.7573 ms/op 6.5633 ms/op 0.72
BLS verifyMultipleSignatures 64 - blst 8.8693 ms/op 11.133 ms/op 0.80
BLS verifyMultipleSignatures 128 - blst 17.672 ms/op 20.299 ms/op 0.87
BLS deserializing 10000 signatures 658.77 ms/op 752.85 ms/op 0.88
BLS deserializing 100000 signatures 6.7498 s/op 7.2695 s/op 0.93
BLS verifyMultipleSignatures - same message - 3 - blst 872.04 us/op 935.86 us/op 0.93
BLS verifyMultipleSignatures - same message - 8 - blst 953.68 us/op 1.0577 ms/op 0.90
BLS verifyMultipleSignatures - same message - 32 - blst 1.6521 ms/op 1.8107 ms/op 0.91
BLS verifyMultipleSignatures - same message - 64 - blst 2.5369 ms/op 2.7299 ms/op 0.93
BLS verifyMultipleSignatures - same message - 128 - blst 4.3130 ms/op 4.7750 ms/op 0.90
BLS aggregatePubkeys 32 - blst 19.432 us/op 21.806 us/op 0.89
BLS aggregatePubkeys 128 - blst 69.063 us/op 77.726 us/op 0.89
notSeenSlots=1 numMissedVotes=1 numBadVotes=10 62.257 ms/op 79.474 ms/op 0.78
notSeenSlots=1 numMissedVotes=0 numBadVotes=4 47.322 ms/op 68.149 ms/op 0.69
notSeenSlots=2 numMissedVotes=1 numBadVotes=10 37.460 ms/op 54.022 ms/op 0.69
getSlashingsAndExits - default max 84.502 us/op 215.80 us/op 0.39
getSlashingsAndExits - 2k 258.33 us/op 500.51 us/op 0.52
proposeBlockBody type=full, size=empty 5.7110 ms/op 8.3371 ms/op 0.69
isKnown best case - 1 super set check 276.00 ns/op 705.00 ns/op 0.39
isKnown normal case - 2 super set checks 263.00 ns/op 741.00 ns/op 0.35
isKnown worse case - 16 super set checks 265.00 ns/op 734.00 ns/op 0.36
InMemoryCheckpointStateCache - add get delete 2.5640 us/op 5.1650 us/op 0.50
updateUnfinalizedPubkeys - updating 10 pubkeys 832.82 us/op 1.6693 ms/op 0.50
updateUnfinalizedPubkeys - updating 100 pubkeys 3.1436 ms/op 6.3416 ms/op 0.50
updateUnfinalizedPubkeys - updating 1000 pubkeys 48.398 ms/op 84.247 ms/op 0.57
validate api signedAggregateAndProof - struct 1.3216 ms/op 1.9358 ms/op 0.68
validate gossip signedAggregateAndProof - struct 1.3300 ms/op 1.8343 ms/op 0.73
batch validate gossip attestation - vc 640000 - chunk 32 117.74 us/op 159.07 us/op 0.74
batch validate gossip attestation - vc 640000 - chunk 64 109.44 us/op 134.14 us/op 0.82
batch validate gossip attestation - vc 640000 - chunk 128 104.48 us/op 119.56 us/op 0.87
batch validate gossip attestation - vc 640000 - chunk 256 100.38 us/op 108.45 us/op 0.93
pickEth1Vote - no votes 1.0795 ms/op 1.0872 ms/op 0.99
pickEth1Vote - max votes 6.5915 ms/op 6.8299 ms/op 0.97
pickEth1Vote - Eth1Data hashTreeRoot value x2048 14.793 ms/op 14.225 ms/op 1.04
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 18.767 ms/op 17.707 ms/op 1.06
pickEth1Vote - Eth1Data fastSerialize value x2048 461.76 us/op 489.10 us/op 0.94
pickEth1Vote - Eth1Data fastSerialize tree x2048 3.2147 ms/op 2.9889 ms/op 1.08
bytes32 toHexString 427.00 ns/op 489.00 ns/op 0.87
bytes32 Buffer.toString(hex) 250.00 ns/op 284.00 ns/op 0.88
bytes32 Buffer.toString(hex) from Uint8Array 362.00 ns/op 470.00 ns/op 0.77
bytes32 Buffer.toString(hex) + 0x 254.00 ns/op 288.00 ns/op 0.88
Object access 1 prop 0.13300 ns/op 0.20000 ns/op 0.67
Map access 1 prop 0.13000 ns/op 0.14100 ns/op 0.92
Object get x1000 5.8260 ns/op 6.2420 ns/op 0.93
Map get x1000 6.5750 ns/op 6.5660 ns/op 1.00
Object set x1000 32.101 ns/op 42.821 ns/op 0.75
Map set x1000 21.877 ns/op 30.148 ns/op 0.73
Return object 10000 times 0.28720 ns/op 0.31060 ns/op 0.92
Throw Error 10000 times 3.3149 us/op 3.6302 us/op 0.91
toHex 147.14 ns/op 178.57 ns/op 0.82
Buffer.from 135.46 ns/op 158.32 ns/op 0.86
shared Buffer 83.356 ns/op 99.318 ns/op 0.84
fastMsgIdFn sha256 / 200 bytes 2.2020 us/op 2.3800 us/op 0.93
fastMsgIdFn h32 xxhash / 200 bytes 243.00 ns/op 292.00 ns/op 0.83
fastMsgIdFn h64 xxhash / 200 bytes 271.00 ns/op 283.00 ns/op 0.96
fastMsgIdFn sha256 / 1000 bytes 7.2910 us/op 7.8470 us/op 0.93
fastMsgIdFn h32 xxhash / 1000 bytes 369.00 ns/op 404.00 ns/op 0.91
fastMsgIdFn h64 xxhash / 1000 bytes 341.00 ns/op 360.00 ns/op 0.95
fastMsgIdFn sha256 / 10000 bytes 63.773 us/op 66.916 us/op 0.95
fastMsgIdFn h32 xxhash / 10000 bytes 1.8610 us/op 1.8780 us/op 0.99
fastMsgIdFn h64 xxhash / 10000 bytes 1.2410 us/op 1.2410 us/op 1.00
send data - 1000 256B messages 11.757 ms/op 13.163 ms/op 0.89
send data - 1000 512B messages 15.810 ms/op 17.538 ms/op 0.90
send data - 1000 1024B messages 25.784 ms/op 27.848 ms/op 0.93
send data - 1000 1200B messages 18.801 ms/op 28.765 ms/op 0.65
send data - 1000 2048B messages 31.275 ms/op 34.714 ms/op 0.90
send data - 1000 4096B messages 30.763 ms/op 33.672 ms/op 0.91
send data - 1000 16384B messages 68.481 ms/op 75.829 ms/op 0.90
send data - 1000 65536B messages 204.58 ms/op 226.25 ms/op 0.90
enrSubnets - fastDeserialize 64 bits 1.0370 us/op 1.2320 us/op 0.84
enrSubnets - ssz BitVector 64 bits 356.00 ns/op 416.00 ns/op 0.86
enrSubnets - fastDeserialize 4 bits 146.00 ns/op 178.00 ns/op 0.82
enrSubnets - ssz BitVector 4 bits 359.00 ns/op 439.00 ns/op 0.82
prioritizePeers score -10:0 att 32-0.1 sync 2-0 143.31 us/op 171.78 us/op 0.83
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 149.30 us/op 174.10 us/op 0.86
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 252.42 us/op 271.11 us/op 0.93
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 403.22 us/op 488.27 us/op 0.83
prioritizePeers score 0:0 att 64-1 sync 4-1 593.00 us/op 663.24 us/op 0.89
array of 16000 items push then shift 1.6312 us/op 1.6774 us/op 0.97
LinkedList of 16000 items push then shift 7.0890 ns/op 7.9920 ns/op 0.89
array of 16000 items push then pop 104.24 ns/op 128.96 ns/op 0.81
LinkedList of 16000 items push then pop 6.9310 ns/op 7.7530 ns/op 0.89
array of 24000 items push then shift 2.3920 us/op 2.4967 us/op 0.96
LinkedList of 24000 items push then shift 7.1290 ns/op 8.6550 ns/op 0.82
array of 24000 items push then pop 134.08 ns/op 174.31 ns/op 0.77
LinkedList of 24000 items push then pop 6.7840 ns/op 8.6110 ns/op 0.79
intersect bitArray bitLen 8 6.3410 ns/op 7.1120 ns/op 0.89
intersect array and set length 8 44.981 ns/op 57.282 ns/op 0.79
intersect bitArray bitLen 128 29.384 ns/op 31.722 ns/op 0.93
intersect array and set length 128 656.26 ns/op 848.98 ns/op 0.77
bitArray.getTrueBitIndexes() bitLen 128 1.7290 us/op 1.6110 us/op 1.07
bitArray.getTrueBitIndexes() bitLen 248 3.0580 us/op 2.8010 us/op 1.09
bitArray.getTrueBitIndexes() bitLen 512 6.0690 us/op 6.1080 us/op 0.99
Buffer.concat 32 items 924.00 ns/op 1.0810 us/op 0.85
Uint8Array.set 32 items 1.7320 us/op 2.2080 us/op 0.78
Buffer.copy 1.7930 us/op 2.4250 us/op 0.74
Uint8Array.set - with subarray 2.5340 us/op 3.3440 us/op 0.76
Uint8Array.set - without subarray 1.8030 us/op 1.6840 us/op 1.07
getUint32 - dataview 234.00 ns/op 298.00 ns/op 0.79
getUint32 - manual 162.00 ns/op 233.00 ns/op 0.70
Set add up to 64 items then delete first 2.1953 us/op 2.5983 us/op 0.84
OrderedSet add up to 64 items then delete first 3.3274 us/op 3.9284 us/op 0.85
Set add up to 64 items then delete last 2.4914 us/op 3.1416 us/op 0.79
OrderedSet add up to 64 items then delete last 3.7592 us/op 4.8114 us/op 0.78
Set add up to 64 items then delete middle 2.5905 us/op 3.1527 us/op 0.82
OrderedSet add up to 64 items then delete middle 5.1950 us/op 5.7934 us/op 0.90
Set add up to 128 items then delete first 5.0666 us/op 6.4026 us/op 0.79
OrderedSet add up to 128 items then delete first 7.5457 us/op 9.7599 us/op 0.77
Set add up to 128 items then delete last 5.0147 us/op 6.2224 us/op 0.81
OrderedSet add up to 128 items then delete last 7.4459 us/op 9.1490 us/op 0.81
Set add up to 128 items then delete middle 4.9426 us/op 6.0866 us/op 0.81
OrderedSet add up to 128 items then delete middle 13.694 us/op 16.456 us/op 0.83
Set add up to 256 items then delete first 10.261 us/op 12.862 us/op 0.80
OrderedSet add up to 256 items then delete first 15.997 us/op 20.081 us/op 0.80
Set add up to 256 items then delete last 10.001 us/op 11.574 us/op 0.86
OrderedSet add up to 256 items then delete last 14.922 us/op 17.467 us/op 0.85
Set add up to 256 items then delete middle 10.020 us/op 11.422 us/op 0.88
OrderedSet add up to 256 items then delete middle 41.182 us/op 46.571 us/op 0.88
transfer serialized Status (84 B) 1.4040 us/op 1.6230 us/op 0.87
copy serialized Status (84 B) 1.1580 us/op 1.3300 us/op 0.87
transfer serialized SignedVoluntaryExit (112 B) 1.4910 us/op 1.7150 us/op 0.87
copy serialized SignedVoluntaryExit (112 B) 1.2620 us/op 1.4230 us/op 0.89
transfer serialized ProposerSlashing (416 B) 2.2160 us/op 2.1350 us/op 1.04
copy serialized ProposerSlashing (416 B) 1.7160 us/op 2.5770 us/op 0.67
transfer serialized Attestation (485 B) 2.0130 us/op 2.4090 us/op 0.84
copy serialized Attestation (485 B) 1.6490 us/op 2.6450 us/op 0.62
transfer serialized AttesterSlashing (33232 B) 2.6030 us/op 2.7110 us/op 0.96
copy serialized AttesterSlashing (33232 B) 6.3300 us/op 8.0310 us/op 0.79
transfer serialized Small SignedBeaconBlock (128000 B) 2.8090 us/op 2.5170 us/op 1.12
copy serialized Small SignedBeaconBlock (128000 B) 15.344 us/op 15.688 us/op 0.98
transfer serialized Avg SignedBeaconBlock (200000 B) 2.4640 us/op 3.0360 us/op 0.81
copy serialized Avg SignedBeaconBlock (200000 B) 20.569 us/op 22.966 us/op 0.90
transfer serialized BlobsSidecar (524380 B) 2.1330 us/op 3.5780 us/op 0.60
copy serialized BlobsSidecar (524380 B) 81.000 us/op 75.650 us/op 1.07
transfer serialized Big SignedBeaconBlock (1000000 B) 2.5500 us/op 4.2210 us/op 0.60
copy serialized Big SignedBeaconBlock (1000000 B) 241.94 us/op 171.55 us/op 1.41
pass gossip attestations to forkchoice per slot 2.8049 ms/op 3.0034 ms/op 0.93
forkChoice updateHead vc 100000 bc 64 eq 0 447.06 us/op 480.74 us/op 0.93
forkChoice updateHead vc 600000 bc 64 eq 0 2.8144 ms/op 3.8343 ms/op 0.73
forkChoice updateHead vc 1000000 bc 64 eq 0 5.0032 ms/op 5.1756 ms/op 0.97
forkChoice updateHead vc 600000 bc 320 eq 0 2.7445 ms/op 3.0472 ms/op 0.90
forkChoice updateHead vc 600000 bc 1200 eq 0 2.8357 ms/op 2.9577 ms/op 0.96
forkChoice updateHead vc 600000 bc 7200 eq 0 3.7908 ms/op 5.6023 ms/op 0.68
forkChoice updateHead vc 600000 bc 64 eq 1000 10.120 ms/op 10.512 ms/op 0.96
forkChoice updateHead vc 600000 bc 64 eq 10000 10.150 ms/op 10.411 ms/op 0.97
forkChoice updateHead vc 600000 bc 64 eq 300000 13.818 ms/op 14.587 ms/op 0.95
computeDeltas 500000 validators 300 proto nodes 3.9190 ms/op 4.2527 ms/op 0.92
computeDeltas 500000 validators 1200 proto nodes 3.9318 ms/op 4.2477 ms/op 0.93
computeDeltas 500000 validators 7200 proto nodes 3.9285 ms/op 4.2624 ms/op 0.92
computeDeltas 750000 validators 300 proto nodes 5.8902 ms/op 6.1556 ms/op 0.96
computeDeltas 750000 validators 1200 proto nodes 6.9496 ms/op 6.1428 ms/op 1.13
computeDeltas 750000 validators 7200 proto nodes 5.8821 ms/op 6.2998 ms/op 0.93
computeDeltas 1400000 validators 300 proto nodes 10.872 ms/op 11.790 ms/op 0.92
computeDeltas 1400000 validators 1200 proto nodes 11.019 ms/op 11.638 ms/op 0.95
computeDeltas 1400000 validators 7200 proto nodes 11.052 ms/op 11.521 ms/op 0.96
computeDeltas 2100000 validators 300 proto nodes 16.445 ms/op 16.647 ms/op 0.99
computeDeltas 2100000 validators 1200 proto nodes 16.544 ms/op 16.560 ms/op 1.00
computeDeltas 2100000 validators 7200 proto nodes 16.710 ms/op 16.483 ms/op 1.01
altair processAttestation - 250000 vs - 7PWei normalcase 1.7022 ms/op 1.7019 ms/op 1.00
altair processAttestation - 250000 vs - 7PWei worstcase 2.5789 ms/op 2.5084 ms/op 1.03
altair processAttestation - setStatus - 1/6 committees join 91.291 us/op 84.545 us/op 1.08
altair processAttestation - setStatus - 1/3 committees join 181.14 us/op 171.03 us/op 1.06
altair processAttestation - setStatus - 1/2 committees join 251.88 us/op 238.41 us/op 1.06
altair processAttestation - setStatus - 2/3 committees join 341.89 us/op 308.21 us/op 1.11
altair processAttestation - setStatus - 4/5 committees join 496.35 us/op 454.40 us/op 1.09
altair processAttestation - setStatus - 100% committees join 591.00 us/op 537.41 us/op 1.10
altair processBlock - 250000 vs - 7PWei normalcase 4.9266 ms/op 3.7211 ms/op 1.32
altair processBlock - 250000 vs - 7PWei normalcase hashState 25.208 ms/op 26.016 ms/op 0.97
altair processBlock - 250000 vs - 7PWei worstcase 32.585 ms/op 36.113 ms/op 0.90
altair processBlock - 250000 vs - 7PWei worstcase hashState 64.599 ms/op 65.995 ms/op 0.98
phase0 processBlock - 250000 vs - 7PWei normalcase 1.6899 ms/op 1.6803 ms/op 1.01
phase0 processBlock - 250000 vs - 7PWei worstcase 20.152 ms/op 19.411 ms/op 1.04
altair processEth1Data - 250000 vs - 7PWei normalcase 316.71 us/op 301.64 us/op 1.05
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 5.7300 us/op 4.6350 us/op 1.24
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 27.841 us/op 26.285 us/op 1.06
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 8.1920 us/op 7.9790 us/op 1.03
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 5.5830 us/op 4.7920 us/op 1.17
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 142.56 us/op 111.10 us/op 1.28
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 1.1112 ms/op 1.0840 ms/op 1.03
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 1.4980 ms/op 1.4656 ms/op 1.02
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 1.5454 ms/op 1.5203 ms/op 1.02
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 3.6506 ms/op 3.6401 ms/op 1.00
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 1.5884 ms/op 1.4701 ms/op 1.08
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 3.6979 ms/op 3.4920 ms/op 1.06
Tree 40 250000 create 211.93 ms/op 224.07 ms/op 0.95
Tree 40 250000 get(125000) 147.57 ns/op 147.44 ns/op 1.00
Tree 40 250000 set(125000) 673.11 ns/op 605.79 ns/op 1.11
Tree 40 250000 toArray() 17.409 ms/op 14.249 ms/op 1.22
Tree 40 250000 iterate all - toArray() + loop 18.824 ms/op 14.330 ms/op 1.31
Tree 40 250000 iterate all - get(i) 52.161 ms/op 50.218 ms/op 1.04
Array 250000 create 2.9204 ms/op 2.7128 ms/op 1.08
Array 250000 clone - spread 1.4894 ms/op 1.3091 ms/op 1.14
Array 250000 get(125000) 0.41400 ns/op 0.40300 ns/op 1.03
Array 250000 set(125000) 0.44200 ns/op 0.41500 ns/op 1.07
Array 250000 iterate all - loop 102.68 us/op 101.67 us/op 1.01
phase0 afterProcessEpoch - 250000 vs - 7PWei 51.432 ms/op 49.259 ms/op 1.04
Array.fill - length 1000000 3.7109 ms/op 3.4132 ms/op 1.09
Array push - length 1000000 17.515 ms/op 12.149 ms/op 1.44
Array.get 0.29511 ns/op 0.26555 ns/op 1.11
Uint8Array.get 0.44983 ns/op 0.41810 ns/op 1.08
phase0 beforeProcessEpoch - 250000 vs - 7PWei 20.231 ms/op 17.489 ms/op 1.16
altair processEpoch - mainnet_e81889 265.15 ms/op 276.35 ms/op 0.96
mainnet_e81889 - altair beforeProcessEpoch 18.915 ms/op 17.980 ms/op 1.05
mainnet_e81889 - altair processJustificationAndFinalization 12.260 us/op 12.355 us/op 0.99
mainnet_e81889 - altair processInactivityUpdates 5.6416 ms/op 4.8404 ms/op 1.17
mainnet_e81889 - altair processRewardsAndPenalties 46.189 ms/op 40.039 ms/op 1.15
mainnet_e81889 - altair processRegistryUpdates 1.7460 us/op 1.7880 us/op 0.98
mainnet_e81889 - altair processSlashings 419.00 ns/op 405.00 ns/op 1.03
mainnet_e81889 - altair processEth1DataReset 341.00 ns/op 335.00 ns/op 1.02
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.9343 ms/op 1.8790 ms/op 1.03
mainnet_e81889 - altair processSlashingsReset 3.3000 us/op 2.5660 us/op 1.29
mainnet_e81889 - altair processRandaoMixesReset 3.8250 us/op 4.0640 us/op 0.94
mainnet_e81889 - altair processHistoricalRootsUpdate 584.00 ns/op 659.00 ns/op 0.89
mainnet_e81889 - altair processParticipationFlagUpdates 2.4750 us/op 1.7330 us/op 1.43
mainnet_e81889 - altair processSyncCommitteeUpdates 444.00 ns/op 427.00 ns/op 1.04
mainnet_e81889 - altair afterProcessEpoch 53.221 ms/op 50.772 ms/op 1.05
capella processEpoch - mainnet_e217614 1.1064 s/op 1.0135 s/op 1.09
mainnet_e217614 - capella beforeProcessEpoch 73.714 ms/op 82.383 ms/op 0.89
mainnet_e217614 - capella processJustificationAndFinalization 17.003 us/op 15.842 us/op 1.07
mainnet_e217614 - capella processInactivityUpdates 18.773 ms/op 17.543 ms/op 1.07
mainnet_e217614 - capella processRewardsAndPenalties 220.31 ms/op 223.33 ms/op 0.99
mainnet_e217614 - capella processRegistryUpdates 14.091 us/op 13.418 us/op 1.05
mainnet_e217614 - capella processSlashings 380.00 ns/op 452.00 ns/op 0.84
mainnet_e217614 - capella processEth1DataReset 300.00 ns/op 354.00 ns/op 0.85
mainnet_e217614 - capella processEffectiveBalanceUpdates 15.273 ms/op 14.621 ms/op 1.04
mainnet_e217614 - capella processSlashingsReset 5.8880 us/op 4.1750 us/op 1.41
mainnet_e217614 - capella processRandaoMixesReset 4.9550 us/op 4.7530 us/op 1.04
mainnet_e217614 - capella processHistoricalRootsUpdate 551.00 ns/op 964.00 ns/op 0.57
mainnet_e217614 - capella processParticipationFlagUpdates 2.0990 us/op 2.1010 us/op 1.00
mainnet_e217614 - capella afterProcessEpoch 125.61 ms/op 127.70 ms/op 0.98
phase0 processEpoch - mainnet_e58758 325.59 ms/op 326.50 ms/op 1.00
mainnet_e58758 - phase0 beforeProcessEpoch 71.437 ms/op 77.405 ms/op 0.92
mainnet_e58758 - phase0 processJustificationAndFinalization 16.320 us/op 16.775 us/op 0.97
mainnet_e58758 - phase0 processRewardsAndPenalties 35.489 ms/op 28.938 ms/op 1.23
mainnet_e58758 - phase0 processRegistryUpdates 7.0920 us/op 9.8060 us/op 0.72
mainnet_e58758 - phase0 processSlashings 453.00 ns/op 466.00 ns/op 0.97
mainnet_e58758 - phase0 processEth1DataReset 292.00 ns/op 366.00 ns/op 0.80
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.2013 ms/op 1.2291 ms/op 0.98
mainnet_e58758 - phase0 processSlashingsReset 2.0740 us/op 2.5480 us/op 0.81
mainnet_e58758 - phase0 processRandaoMixesReset 3.4770 us/op 3.7430 us/op 0.93
mainnet_e58758 - phase0 processHistoricalRootsUpdate 304.00 ns/op 376.00 ns/op 0.81
mainnet_e58758 - phase0 processParticipationRecordUpdates 3.1800 us/op 3.1270 us/op 1.02
mainnet_e58758 - phase0 afterProcessEpoch 43.113 ms/op 43.937 ms/op 0.98
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.3984 ms/op 1.9365 ms/op 0.72
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 2.4809 ms/op 2.2963 ms/op 1.08
altair processInactivityUpdates - 250000 normalcase 15.379 ms/op 14.566 ms/op 1.06
altair processInactivityUpdates - 250000 worstcase 16.146 ms/op 16.141 ms/op 1.00
phase0 processRegistryUpdates - 250000 normalcase 6.3220 us/op 7.0250 us/op 0.90
phase0 processRegistryUpdates - 250000 badcase_full_deposits 300.69 us/op 312.36 us/op 0.96
phase0 processRegistryUpdates - 250000 worstcase 0.5 105.24 ms/op 127.93 ms/op 0.82
altair processRewardsAndPenalties - 250000 normalcase 39.455 ms/op 37.573 ms/op 1.05
altair processRewardsAndPenalties - 250000 worstcase 38.195 ms/op 35.955 ms/op 1.06
phase0 getAttestationDeltas - 250000 normalcase 7.7095 ms/op 7.7508 ms/op 0.99
phase0 getAttestationDeltas - 250000 worstcase 7.3155 ms/op 7.4666 ms/op 0.98
phase0 processSlashings - 250000 worstcase 78.747 us/op 89.296 us/op 0.88
altair processSyncCommitteeUpdates - 250000 120.32 ms/op 124.33 ms/op 0.97
BeaconState.hashTreeRoot - No change 240.00 ns/op 267.00 ns/op 0.90
BeaconState.hashTreeRoot - 1 full validator 126.21 us/op 93.586 us/op 1.35
BeaconState.hashTreeRoot - 32 full validator 1.1844 ms/op 1.1361 ms/op 1.04
BeaconState.hashTreeRoot - 512 full validator 10.218 ms/op 10.097 ms/op 1.01
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 149.54 us/op 114.49 us/op 1.31
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 1.8669 ms/op 1.4589 ms/op 1.28
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 19.038 ms/op 20.835 ms/op 0.91
BeaconState.hashTreeRoot - 1 balances 85.789 us/op 93.184 us/op 0.92
BeaconState.hashTreeRoot - 32 balances 760.55 us/op 840.87 us/op 0.90
BeaconState.hashTreeRoot - 512 balances 6.8998 ms/op 7.6803 ms/op 0.90
BeaconState.hashTreeRoot - 250000 balances 135.74 ms/op 153.77 ms/op 0.88
aggregationBits - 2048 els - zipIndexesInBitList 24.424 us/op 26.247 us/op 0.93
byteArrayEquals 32 54.155 ns/op 54.540 ns/op 0.99
Buffer.compare 32 17.961 ns/op 17.373 ns/op 1.03
byteArrayEquals 1024 1.6179 us/op 1.6156 us/op 1.00
Buffer.compare 1024 24.754 ns/op 24.840 ns/op 1.00
byteArrayEquals 16384 25.386 us/op 25.658 us/op 0.99
Buffer.compare 16384 203.51 ns/op 194.48 ns/op 1.05
byteArrayEquals 123687377 191.11 ms/op 194.38 ms/op 0.98
Buffer.compare 123687377 6.2103 ms/op 7.5644 ms/op 0.82
byteArrayEquals 32 - diff last byte 52.456 ns/op 53.624 ns/op 0.98
Buffer.compare 32 - diff last byte 17.242 ns/op 17.465 ns/op 0.99
byteArrayEquals 1024 - diff last byte 1.5802 us/op 1.6308 us/op 0.97
Buffer.compare 1024 - diff last byte 26.101 ns/op 25.450 ns/op 1.03
byteArrayEquals 16384 - diff last byte 25.187 us/op 25.829 us/op 0.98
Buffer.compare 16384 - diff last byte 194.78 ns/op 202.71 ns/op 0.96
byteArrayEquals 123687377 - diff last byte 190.56 ms/op 189.78 ms/op 1.00
Buffer.compare 123687377 - diff last byte 6.3332 ms/op 6.1649 ms/op 1.03
byteArrayEquals 32 - random bytes 5.1250 ns/op 5.0800 ns/op 1.01
Buffer.compare 32 - random bytes 19.072 ns/op 17.132 ns/op 1.11
byteArrayEquals 1024 - random bytes 5.6210 ns/op 5.1070 ns/op 1.10
Buffer.compare 1024 - random bytes 17.191 ns/op 17.092 ns/op 1.01
byteArrayEquals 16384 - random bytes 5.1240 ns/op 5.0930 ns/op 1.01
Buffer.compare 16384 - random bytes 17.159 ns/op 17.412 ns/op 0.99
byteArrayEquals 123687377 - random bytes 6.5000 ns/op 6.4500 ns/op 1.01
Buffer.compare 123687377 - random bytes 18.530 ns/op 18.490 ns/op 1.00
regular array get 100000 times 41.642 us/op 34.731 us/op 1.20
wrappedArray get 100000 times 32.674 us/op 33.183 us/op 0.98
arrayWithProxy get 100000 times 13.152 ms/op 13.341 ms/op 0.99
ssz.Root.equals 45.703 ns/op 45.720 ns/op 1.00
byteArrayEquals 45.128 ns/op 45.116 ns/op 1.00
Buffer.compare 10.296 ns/op 10.330 ns/op 1.00
processSlot - 1 slots 15.584 us/op 11.679 us/op 1.33
processSlot - 32 slots 2.8757 ms/op 2.1561 ms/op 1.33
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 37.473 ms/op 36.599 ms/op 1.02
getCommitteeAssignments - req 1 vs - 250000 vc 2.1068 ms/op 2.1613 ms/op 0.97
getCommitteeAssignments - req 100 vs - 250000 vc 4.0844 ms/op 4.2952 ms/op 0.95
getCommitteeAssignments - req 1000 vs - 250000 vc 4.3444 ms/op 4.4900 ms/op 0.97
findModifiedValidators - 10000 modified validators 243.67 ms/op 258.03 ms/op 0.94
findModifiedValidators - 1000 modified validators 178.79 ms/op 176.68 ms/op 1.01
findModifiedValidators - 100 modified validators 160.75 ms/op 160.38 ms/op 1.00
findModifiedValidators - 10 modified validators 167.62 ms/op 152.13 ms/op 1.10
findModifiedValidators - 1 modified validators 149.33 ms/op 153.14 ms/op 0.98
findModifiedValidators - no difference 159.77 ms/op 167.39 ms/op 0.95
compare ViewDUs 2.9209 s/op 3.3091 s/op 0.88
compare each validator Uint8Array 1.4269 s/op 1.4704 s/op 0.97
compare ViewDU to Uint8Array 1.0708 s/op 1.2361 s/op 0.87
migrate state 1000000 validators, 24 modified, 0 new 755.04 ms/op 757.73 ms/op 1.00
migrate state 1000000 validators, 1700 modified, 1000 new 996.82 ms/op 923.05 ms/op 1.08
migrate state 1000000 validators, 3400 modified, 2000 new 1.1903 s/op 1.1167 s/op 1.07
migrate state 1500000 validators, 24 modified, 0 new 757.76 ms/op 750.72 ms/op 1.01
migrate state 1500000 validators, 1700 modified, 1000 new 998.54 ms/op 994.39 ms/op 1.00
migrate state 1500000 validators, 3400 modified, 2000 new 1.1441 s/op 1.1480 s/op 1.00
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 4.2600 ns/op 4.3200 ns/op 0.99
state getBlockRootAtSlot - 250000 vs - 7PWei 575.31 ns/op 449.20 ns/op 1.28
computeProposers - vc 250000 6.7214 ms/op 7.8054 ms/op 0.86
computeEpochShuffling - vc 250000 42.410 ms/op 42.055 ms/op 1.01
getNextSyncCommittee - vc 250000 118.14 ms/op 124.04 ms/op 0.95
computeSigningRoot for AttestationData 19.085 us/op 16.864 us/op 1.13
hash AttestationData serialized data then Buffer.toString(base64) 1.6229 us/op 1.5935 us/op 1.02
toHexString serialized data 949.97 ns/op 904.86 ns/op 1.05
Buffer.toString(base64) 171.62 ns/op 185.40 ns/op 0.93
nodejs block root to RootHex using toHex 162.48 ns/op 150.48 ns/op 1.08
nodejs block root to RootHex using toRootHex 98.310 ns/op 95.790 ns/op 1.03
browser block root to RootHex using the deprecated toHexString 245.92 ns/op 228.65 ns/op 1.08
browser block root to RootHex using toHex 180.56 ns/op 183.14 ns/op 0.99
browser block root to RootHex using toRootHex 161.71 ns/op 163.18 ns/op 0.99

by benchmarkbot/action

wemeetagain
wemeetagain previously approved these changes Nov 2, 2024
View reviewed changes
@nflaig nflaig requested a review from wemeetagain November 3, 2024 07:21
@nflaig nflaig merged commit abe6751 into unstable Nov 3, 2024
20 checks passed
@nflaig nflaig deleted the nflaig/fix-local-keys branch November 3, 2024 07:25
@nflaig nflaig mentioned this pull request Nov 3, 2024
Closed
wemeetagain added a commit that referenced this pull request Dec 20, 2024
@wemeetagain @nflaig
@nazarhussain @g11tech @matthewkeil @ensi321 @twoeths @philknows @dependabot @acolytec3 @varunguleriaCodes @ClockworkYuzu
chore: release v1.24.0 (#7325)
11f35a8 
* feat: add keymanager endpoint to retrieve proposer config (#7210)

* feat: add keymanager endpoint to retrieve proposer config

* Do not return empty builder config

* Check all builder proposer config values

* Fix settings builder config if undefined

* Fix builder config parsing

* Use ssz type to handle json serialization

Default parsing can't handle BigInt

* Revert "Use ssz type to handle json serialization"

This reverts commit 01fcea7.

* Fix boost factor json serialization

* Remove unused import

* Update test data

* Update proposer config test

* feat: add mekong network option (#7212)

* chore: fix import order with biome syntax (#7211)

Fix import order

* fix: consistently validate pubkey and throw 404 if not found (#7214)

* Throw error if pubkey is unknown when getting graffiti

* Consistently validate pubkey and throw 404 if not found

* fix: only return local keys from /eth/v1/keystores (#7215)

* fix: only return local keys from /eth/v1/keystores

* Fix fetching remote keys in node assertion

* feat: add and use getBlobsV1 to expedite gossip import (#7134)

* hookup the getblobs api to get bob and proof data from el

remove unused

fix import

metrics overhault, test, debugging testing, some feeback

fix

add nethermind bug dicussion link

fix

resolve conflicts

* deblobs timeout

* fix metric

* chore: revert async aggregate with randomness (#7218)

Revert "feat: asyncAggregateWithRandomness (#7204)"

This reverts commit e31d535.

* fix: update config for relaunched mekong network (#7220)

* fix: light client generating `LightClientUpdate` with wrong length of branches (#7187)

* initial commit

* Rewrite SyncCommitteeWitnessRepository

* Fix finality branch

* Update unit test

* fix e2e

* Review PR

---------

Co-authored-by: Nico Flaig <[email protected]>

* fix: archive finalized state when shutting down beacon node (#7221)

* Fix typo

* feat: remove unfinalized pubkey cache (#7230)

* Remove unfinalized pubkey cache

* lint

* Fix unit test

* chore: skip web3_provider unit tests (#7252)

* fix: prune checkpoint states at syncing time (#7241)

* fix: prune checkpoint states at syncing time

* fix: lint

* fix: check-types in test

* fix: sync cached isCompoundingValidatorArr at epoch transition (#7247)

* fix: handle outOfRangeData when range sync Deneb (#7249)

* fix: handle outOfRangeData for beaconBlocksMaybeBlobsByRange()

* fix: lint

* fix: archiveBlocks - handle deneb outOfRangeData block

* fix: sync cached balance when adding new validator to registry (#7255)

* fix: sync cached balance when adding new validator to registry

* chore: add more comments

* fix: remove persisted checkpoint states from the previous run at startup

* fix: do not throw error when trying to prune missing directory (#7257)

* docs: update documentation Oct 2024 (#7178)

* docs update oct 2024 init

* Reconfig quickstart nav and minor fixes

* fix lint

* spelling fixes

* minor fixes and add to wordlist

* prettier fix

* add to wordlist

* sort wordlist

* modify dominance to include lighthouse

* fix typescript casing and add recommendation

* add selection and boost_factor with keymanager notice

* update wordlist

* remove builder enabled and add keymanager api

* spelling

---------

Co-authored-by: Nico Flaig <[email protected]>

* chore(deps): bump cross-spawn from 7.0.3 to 7.0.6 in /docs (#7268)

Bumps [cross-spawn](https://github.com/moxystudio/node-cross-spawn) from 7.0.3 to 7.0.6.
- [Changelog](https://github.com/moxystudio/node-cross-spawn/blob/master/CHANGELOG.md)
- [Commits](moxystudio/node-cross-spawn@v7.0.3...v7.0.6)

---
updated-dependencies:
- dependency-name: cross-spawn
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat: add error log to notifier if execution client auth failed (#7239)

* feat: add error log to notifier if execution client auth failed

* Update packages/beacon-node/src/node/notifier.ts

---------

Co-authored-by: NC <[email protected]>

* docs: display rcConfig flag on CLI reference page (#7270)

* docs: display rcConfig flag on CLI reference page

* Update word list

* chore: remove prettier as default formatter for all file types (#7275)

* chore: unhide flags relevant for devnets / testing (#7271)

* feat: debug too many shuffling promises (#7251)

* feat: add asyncShufflingCalculation to StateTransitionOpts

* feat: add asyncShufflingCalculation to all regen / processSlots consumers

* fix: default to false for async shuffling and remove unnecessary props

* fix: remove unnecessary flags from stateTransition

* feat: implement conditional build of shuffling for prepareNextSlot

* fix: spec test bug where shufflingCache is present from BeaconChain constructor

* feat: sync build next shuffling if not queued async

* fix: use getSync to pull next shuffling correctly

* docs: add comment to prepareNextSlot

* refactor: rename StateCloneOpts to StateRegenerationOpts

* feat: pass asyncShufflingCalculation through to afterProcessEpoch and refactor conditional to run purely sync

* docs: add issue number to comment

* chore: lint

* chore: unpin nodejs version from 22.4 (#6982)

* Revert "chore: pin nodejs version to 22.4 (#6964)"

This reverts commit f20484b.

* Don't revert formatting changes

---------

Co-authored-by: Nico Flaig <[email protected]>
Co-authored-by: Cayman <[email protected]>

* chore: update bootnodes file url for holesky and sepolia (#7276)

* feat: add `debug_getHistoricalSummaries` endpoint (#7245)

* feat: add new getHistoricalSummaries endpoint to debug namespace

* Add JSON response

* Restructure to use stateId and add proof to response

* add test scaffolding

* Address feedback

* Move getHistoricalSummaries to lodestar namespace

* add lodestar namespace unit test

* update route name to lodestar namespace

* cast state object as Capella state

* Lint

* json properties need to be lower case

* Make it v1 since it's now part of lodestar namespace

* Group with other /lodestar endpoints

* Simplify beacon node impl

* Rename return type

* Update test description

* Fix variable name

---------

Co-authored-by: Nico Flaig <[email protected]>

* chore: log sync committee signature errors as `error` (#7283)

* fix: update engine_getClientVersionV1 commit encoding (#7282)

* fix: check pubkey or validator index known to a state (#7284)

* fix: check pubkey or validator index known to a state

* chore: add more comments

* feat: lodestar script setup (#7254)

* feat: lodestar_setup

* feat: script_updates + docs

* feat: script_addition_in_docs + command_update

* Remove duplicate script from docs folder

* Minor script updates

* Update script to prepare docs and ignore copied file

* Update installation page

* Wording

---------

Co-authored-by: Nico Flaig <[email protected]>

* feat: add terminal-sized Electra giraffe banner (#7286)

* Create giraffeBanners.ts

* Wire in banner

* Fix file name

* lint

* Address @nflaig's comment

---------

Co-authored-by: NC <[email protected]>

* chore: pin nodejs version to 22.4 (#7291)

Revert "chore: unpin nodejs version from 22.4 (#6982)"

This reverts commit 69ae688.

* feat: expose `DOMAIN_APPLICATION_MASK` in config/spec api (#7296)

* feat: expose DOMAIN_APPLICATION_MASK in config/spec api

* Lint

* feat: make `MAX_REQUEST_BLOB_SIDECARS` and `MAX_BLOBS_PER_BLOCK` configurable (#7294)

* Init commit

* Fix check-types

* Add comment on how MAX_REQUEST_BLOB_SIDECARS is calculated

* Ensure proper config object is passed

* Address comment

---------

Co-authored-by: Nico Flaig <[email protected]>

* feat: use `BLOB_SIDECAR_SUBNET_COUNT` to configure blob subnets (#7297)

feat: use BLOB_SIDECAR_SUBNET_COUNT to configure blob subnets

* chore: log sync aggregate participants when producing beacon block body (#7300)

* chore: log sync aggregate participants when producing beacon block body

* Use isForkLightClient instead of ForkSeq

* Fix produce block unit tests

* chore: print graffiti when producing beacon block body (#7303)

* fix: warn if engine / builder failed to produce block within cutoff time (#7305)

* feat: add kzg commitment length check when validating gossip blocks (#7302)

* feat: add blob sidecar index check (#7313)

Validate blobSidecar index

* fix: fix blob sidecar index check (#7315)

Fix index check

* chore: fix format of printed graffiti from hex to utf-8 (#7306)

* chore: fix format of printed graffiti from hex to utf-8

* Use Buffer.from no copy with offset

* docs: batch commit typos and update contributor readme (#7312)

* batch commit typos and update contributor readme

* update donation text

Co-authored-by: Nico Flaig <[email protected]>

* correct spelling

Co-authored-by: Nico Flaig <[email protected]>

---------

Co-authored-by: Nico Flaig <[email protected]>

* chore: remove trailing null bytes from printed graffiti (#7320)

* chore: remove trailing null bytes from printed graffiti

* Use replaceAll instead of regex

* chore: unpin nodejs version from 22.4 (#7324)

Revert "chore: pin nodejs version to 22.4 (#7291)"

This reverts commit 99794d3.

* chore: bump package versions to 1.24.0

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Nico Flaig <[email protected]>
Co-authored-by: Nazar Hussain <[email protected]>
Co-authored-by: g11tech <[email protected]>
Co-authored-by: Matthew Keil <[email protected]>
Co-authored-by: NC <[email protected]>
Co-authored-by: twoeths <[email protected]>
Co-authored-by: Phil Ngo <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: acolytec3 <[email protected]>
Co-authored-by: Varun Guleria <[email protected]>
Co-authored-by: ClockworkYuzu <[email protected]>
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.24.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wemeetagain wemeetagain wemeetagain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nflaig @wemeetagain