Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: revert skipping one benchmark #7415

Merged
merged 1 commit into from
Jan 31, 2025
Merged

chore: revert skipping one benchmark #7415

merged 1 commit into from
Jan 31, 2025

Conversation

nazarhussain
Copy link
Contributor

@nazarhussain nazarhussain commented Jan 31, 2025 •
edited by nflaig
Loading

Motivation

Revert changes to the benchmark, so all tests are included.

Description

  • Revert changes to the benchmark skip

Steps to test or reproduce

  • Run all tests

Closes #7380

@nazarhussain nazarhussain requested a review from a team as a code owner January 31, 2025 09:27
@codecov Codecov
Copy link

codecov bot commented Jan 31, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.28%. Comparing base (c43b070) to head (51182e5).
Report is 4 commits behind head on unstable.

Additional details and impacted files 
@@            Coverage Diff            @@
##           unstable    #7415   +/-   ##
=========================================
  Coverage     50.28%   50.28%           
=========================================
  Files           602      602           
  Lines         40355    40355           
  Branches       2206     2206           
=========================================
  Hits          20293    20293           
  Misses        20022    20022           
  Partials         40       40

@github-actions GitHub Actions
Copy link
Contributor

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: b8a8f00 Previous: c43b070 Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 1.6548 ms/op 749.50 us/op 2.21
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 47.851 us/op 29.973 us/op 1.60
BLS verify - blst 1.0006 ms/op 892.07 us/op 1.12
BLS verifyMultipleSignatures 3 - blst 1.3369 ms/op 1.3042 ms/op 1.03
BLS verifyMultipleSignatures 8 - blst 2.4624 ms/op 2.0867 ms/op 1.18
BLS verifyMultipleSignatures 32 - blst 6.8269 ms/op 4.5189 ms/op 1.51
BLS verifyMultipleSignatures 64 - blst 13.076 ms/op 8.4002 ms/op 1.56
BLS verifyMultipleSignatures 128 - blst 20.863 ms/op 16.010 ms/op 1.30
BLS deserializing 10000 signatures 780.37 ms/op 594.65 ms/op 1.31
BLS deserializing 100000 signatures 7.4531 s/op 6.0440 s/op 1.23
BLS verifyMultipleSignatures - same message - 3 - blst 1.0443 ms/op 945.02 us/op 1.11
BLS verifyMultipleSignatures - same message - 8 - blst 1.2020 ms/op 1.0763 ms/op 1.12
BLS verifyMultipleSignatures - same message - 32 - blst 1.9279 ms/op 1.6872 ms/op 1.14
BLS verifyMultipleSignatures - same message - 64 - blst 2.8138 ms/op 2.5078 ms/op 1.12
BLS verifyMultipleSignatures - same message - 128 - blst 4.6846 ms/op 4.0633 ms/op 1.15
BLS aggregatePubkeys 32 - blst 20.111 us/op 17.367 us/op 1.16
BLS aggregatePubkeys 128 - blst 72.793 us/op 61.145 us/op 1.19
notSeenSlots=1 numMissedVotes=1 numBadVotes=10 65.585 ms/op 39.819 ms/op 1.65
notSeenSlots=1 numMissedVotes=0 numBadVotes=4 61.852 ms/op 46.088 ms/op 1.34
notSeenSlots=2 numMissedVotes=1 numBadVotes=10 50.861 ms/op 34.808 ms/op 1.46
getSlashingsAndExits - default max 87.670 us/op 58.912 us/op 1.49
getSlashingsAndExits - 2k 381.30 us/op 203.28 us/op 1.88
proposeBlockBody type=full, size=empty 7.1255 ms/op 4.6684 ms/op 1.53
isKnown best case - 1 super set check 216.00 ns/op 387.00 ns/op 0.56
isKnown normal case - 2 super set checks 206.00 ns/op 386.00 ns/op 0.53
isKnown worse case - 16 super set checks 206.00 ns/op 387.00 ns/op 0.53
InMemoryCheckpointStateCache - add get delete 2.4900 us/op 2.4130 us/op 1.03
validate api signedAggregateAndProof - struct 1.8677 ms/op 1.9270 ms/op 0.97
validate gossip signedAggregateAndProof - struct 1.5349 ms/op 1.9389 ms/op 0.79
batch validate gossip attestation - vc 640000 - chunk 32 140.93 us/op 111.36 us/op 1.27
batch validate gossip attestation - vc 640000 - chunk 64 118.22 us/op 94.188 us/op 1.26
batch validate gossip attestation - vc 640000 - chunk 128 117.11 us/op 87.395 us/op 1.34
batch validate gossip attestation - vc 640000 - chunk 256 114.86 us/op 90.324 us/op 1.27
pickEth1Vote - no votes 1.0280 ms/op 723.65 us/op 1.42
pickEth1Vote - max votes 10.018 ms/op 7.0104 ms/op 1.43
pickEth1Vote - Eth1Data hashTreeRoot value x2048 14.811 ms/op 14.933 ms/op 0.99
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 27.608 ms/op 20.980 ms/op 1.32
pickEth1Vote - Eth1Data fastSerialize value x2048 445.71 us/op 366.01 us/op 1.22
pickEth1Vote - Eth1Data fastSerialize tree x2048 4.7163 ms/op 4.2346 ms/op 1.11
bytes32 toHexString 365.00 ns/op 539.00 ns/op 0.68
bytes32 Buffer.toString(hex) 239.00 ns/op 421.00 ns/op 0.57
bytes32 Buffer.toString(hex) from Uint8Array 336.00 ns/op 494.00 ns/op 0.68
bytes32 Buffer.toString(hex) + 0x 235.00 ns/op 411.00 ns/op 0.57
Object access 1 prop 0.11600 ns/op 0.30500 ns/op 0.38
Map access 1 prop 0.12200 ns/op 0.31600 ns/op 0.39
Object get x1000 6.0040 ns/op 5.3690 ns/op 1.12
Map get x1000 6.2880 ns/op 5.9770 ns/op 1.05
Object set x1000 30.019 ns/op 18.979 ns/op 1.58
Map set x1000 20.523 ns/op 16.598 ns/op 1.24
Return object 10000 times 0.28830 ns/op 0.29490 ns/op 0.98
Throw Error 10000 times 4.2814 us/op 3.5006 us/op 1.22
toHex 128.18 ns/op 94.292 ns/op 1.36
Buffer.from 124.14 ns/op 88.918 ns/op 1.40
shared Buffer 80.066 ns/op 58.675 ns/op 1.36
fastMsgIdFn sha256 / 200 bytes 2.1670 us/op 1.8170 us/op 1.19
fastMsgIdFn h32 xxhash / 200 bytes 196.00 ns/op 374.00 ns/op 0.52
fastMsgIdFn h64 xxhash / 200 bytes 264.00 ns/op 440.00 ns/op 0.60
fastMsgIdFn sha256 / 1000 bytes 7.3590 us/op 5.8450 us/op 1.26
fastMsgIdFn h32 xxhash / 1000 bytes 327.00 ns/op 508.00 ns/op 0.64
fastMsgIdFn h64 xxhash / 1000 bytes 431.00 ns/op 514.00 ns/op 0.84
fastMsgIdFn sha256 / 10000 bytes 64.234 us/op 50.844 us/op 1.26
fastMsgIdFn h32 xxhash / 10000 bytes 1.8070 us/op 1.8840 us/op 0.96
fastMsgIdFn h64 xxhash / 10000 bytes 1.2100 us/op 1.3230 us/op 0.91
send data - 1000 256B messages 13.111 ms/op 9.7099 ms/op 1.35
send data - 1000 512B messages 16.462 ms/op 13.502 ms/op 1.22
send data - 1000 1024B messages 24.954 ms/op 19.898 ms/op 1.25
send data - 1000 1200B messages 21.229 ms/op 14.960 ms/op 1.42
send data - 1000 2048B messages 26.907 ms/op 14.644 ms/op 1.84
send data - 1000 4096B messages 28.100 ms/op 17.713 ms/op 1.59
send data - 1000 16384B messages 76.394 ms/op 44.959 ms/op 1.70
send data - 1000 65536B messages 226.06 ms/op 241.76 ms/op 0.94
enrSubnets - fastDeserialize 64 bits 897.00 ns/op 1.8000 us/op 0.50
enrSubnets - ssz BitVector 64 bits 326.00 ns/op 496.00 ns/op 0.66
enrSubnets - fastDeserialize 4 bits 123.00 ns/op 322.00 ns/op 0.38
enrSubnets - ssz BitVector 4 bits 322.00 ns/op 500.00 ns/op 0.64
prioritizePeers score -10:0 att 32-0.1 sync 2-0 119.31 us/op 100.09 us/op 1.19
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 142.60 us/op 115.71 us/op 1.23
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 203.75 us/op 169.78 us/op 1.20
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 379.39 us/op 311.84 us/op 1.22
prioritizePeers score 0:0 att 64-1 sync 4-1 468.94 us/op 366.01 us/op 1.28
array of 16000 items push then shift 1.6482 us/op 1.1878 us/op 1.39
LinkedList of 16000 items push then shift 7.4830 ns/op 7.0030 ns/op 1.07
array of 16000 items push then pop 79.529 ns/op 62.282 ns/op 1.28
LinkedList of 16000 items push then pop 7.2950 ns/op 5.9780 ns/op 1.22
array of 24000 items push then shift 2.4006 us/op 1.7413 us/op 1.38
LinkedList of 24000 items push then shift 8.0100 ns/op 6.4170 ns/op 1.25
array of 24000 items push then pop 108.29 ns/op 85.181 ns/op 1.27
LinkedList of 24000 items push then pop 6.8830 ns/op 6.0270 ns/op 1.14
intersect bitArray bitLen 8 6.3310 ns/op 5.3950 ns/op 1.17
intersect array and set length 8 37.858 ns/op 33.345 ns/op 1.14
intersect bitArray bitLen 128 29.521 ns/op 26.486 ns/op 1.11
intersect array and set length 128 615.50 ns/op 553.74 ns/op 1.11
bitArray.getTrueBitIndexes() bitLen 128 1.0200 us/op 1.1190 us/op 0.91
bitArray.getTrueBitIndexes() bitLen 248 1.8390 us/op 1.7860 us/op 1.03
bitArray.getTrueBitIndexes() bitLen 512 3.7790 us/op 3.2820 us/op 1.15
Buffer.concat 32 items 590.00 ns/op 791.00 ns/op 0.75
Uint8Array.set 32 items 1.0620 us/op 1.2430 us/op 0.85
Buffer.copy 2.1700 us/op 2.1220 us/op 1.02
Uint8Array.set - with subarray 1.8810 us/op 1.6990 us/op 1.11
Uint8Array.set - without subarray 1.1040 us/op 1.0780 us/op 1.02
getUint32 - dataview 198.00 ns/op 367.00 ns/op 0.54
getUint32 - manual 120.00 ns/op 300.00 ns/op 0.40
Set add up to 64 items then delete first 2.1601 us/op 1.6558 us/op 1.30
OrderedSet add up to 64 items then delete first 3.3151 us/op 2.5669 us/op 1.29
Set add up to 64 items then delete last 2.4522 us/op 1.8872 us/op 1.30
OrderedSet add up to 64 items then delete last 3.6554 us/op 2.8443 us/op 1.29
Set add up to 64 items then delete middle 2.4447 us/op 1.8866 us/op 1.30
OrderedSet add up to 64 items then delete middle 5.6497 us/op 4.3067 us/op 1.31
Set add up to 128 items then delete first 6.6675 us/op 3.7423 us/op 1.78
OrderedSet add up to 128 items then delete first 8.7720 us/op 5.9197 us/op 1.48
Set add up to 128 items then delete last 5.0947 us/op 3.5889 us/op 1.42
OrderedSet add up to 128 items then delete last 7.4718 us/op 5.5388 us/op 1.35
Set add up to 128 items then delete middle 5.0207 us/op 3.5991 us/op 1.40
OrderedSet add up to 128 items then delete middle 14.579 us/op 11.274 us/op 1.29
Set add up to 256 items then delete first 10.984 us/op 7.3338 us/op 1.50
OrderedSet add up to 256 items then delete first 16.623 us/op 11.796 us/op 1.41
Set add up to 256 items then delete last 10.111 us/op 7.1036 us/op 1.42
OrderedSet add up to 256 items then delete last 15.400 us/op 11.197 us/op 1.38
Set add up to 256 items then delete middle 11.494 us/op 7.1072 us/op 1.62
OrderedSet add up to 256 items then delete middle 46.438 us/op 32.927 us/op 1.41
transfer serialized Status (84 B) 2.4380 us/op 2.0460 us/op 1.19
copy serialized Status (84 B) 1.3260 us/op 1.3050 us/op 1.02
transfer serialized SignedVoluntaryExit (112 B) 2.7530 us/op 1.9900 us/op 1.38
copy serialized SignedVoluntaryExit (112 B) 1.2950 us/op 1.2290 us/op 1.05
transfer serialized ProposerSlashing (416 B) 2.4650 us/op 2.1210 us/op 1.16
copy serialized ProposerSlashing (416 B) 1.4460 us/op 1.6750 us/op 0.86
transfer serialized Attestation (485 B) 2.4660 us/op 2.1340 us/op 1.16
copy serialized Attestation (485 B) 1.5260 us/op 1.3830 us/op 1.10
transfer serialized AttesterSlashing (33232 B) 2.7940 us/op 3.0010 us/op 0.93
copy serialized AttesterSlashing (33232 B) 4.4210 us/op 4.1940 us/op 1.05
transfer serialized Small SignedBeaconBlock (128000 B) 3.5770 us/op 2.9180 us/op 1.23
copy serialized Small SignedBeaconBlock (128000 B) 11.179 us/op 8.9880 us/op 1.24
transfer serialized Avg SignedBeaconBlock (200000 B) 4.1280 us/op 2.9290 us/op 1.41
copy serialized Avg SignedBeaconBlock (200000 B) 16.438 us/op 12.681 us/op 1.30
transfer serialized BlobsSidecar (524380 B) 4.0950 us/op 3.3090 us/op 1.24
copy serialized BlobsSidecar (524380 B) 85.102 us/op 54.829 us/op 1.55
transfer serialized Big SignedBeaconBlock (1000000 B) 4.5810 us/op 3.6640 us/op 1.25
copy serialized Big SignedBeaconBlock (1000000 B) 121.42 us/op 167.50 us/op 0.72
pass gossip attestations to forkchoice per slot 2.7545 ms/op 2.3013 ms/op 1.20
forkChoice updateHead vc 100000 bc 64 eq 0 511.06 us/op 347.98 us/op 1.47
forkChoice updateHead vc 600000 bc 64 eq 0 3.6713 ms/op 2.1672 ms/op 1.69
forkChoice updateHead vc 1000000 bc 64 eq 0 4.8167 ms/op 3.7719 ms/op 1.28
forkChoice updateHead vc 600000 bc 320 eq 0 2.7710 ms/op 2.1259 ms/op 1.30
forkChoice updateHead vc 600000 bc 1200 eq 0 2.9308 ms/op 2.1320 ms/op 1.37
forkChoice updateHead vc 600000 bc 7200 eq 0 3.1608 ms/op 2.4135 ms/op 1.31
forkChoice updateHead vc 600000 bc 64 eq 1000 10.592 ms/op 9.1754 ms/op 1.15
forkChoice updateHead vc 600000 bc 64 eq 10000 10.303 ms/op 9.0711 ms/op 1.14
forkChoice updateHead vc 600000 bc 64 eq 300000 13.724 ms/op 10.936 ms/op 1.25
computeDeltas 500000 validators 300 proto nodes 3.9102 ms/op 3.1029 ms/op 1.26
computeDeltas 500000 validators 1200 proto nodes 3.9847 ms/op 3.1632 ms/op 1.26
computeDeltas 500000 validators 7200 proto nodes 4.0660 ms/op 3.2355 ms/op 1.26
computeDeltas 750000 validators 300 proto nodes 5.8321 ms/op 4.8869 ms/op 1.19
computeDeltas 750000 validators 1200 proto nodes 5.8372 ms/op 4.5519 ms/op 1.28
computeDeltas 750000 validators 7200 proto nodes 5.9154 ms/op 4.6906 ms/op 1.26
computeDeltas 1400000 validators 300 proto nodes 11.029 ms/op 8.7767 ms/op 1.26
computeDeltas 1400000 validators 1200 proto nodes 10.950 ms/op 8.7171 ms/op 1.26
computeDeltas 1400000 validators 7200 proto nodes 10.695 ms/op 8.6016 ms/op 1.24
computeDeltas 2100000 validators 300 proto nodes 15.998 ms/op 12.655 ms/op 1.26
computeDeltas 2100000 validators 1200 proto nodes 16.066 ms/op 12.797 ms/op 1.26
computeDeltas 2100000 validators 7200 proto nodes 16.039 ms/op 12.841 ms/op 1.25
altair processAttestation - 250000 vs - 7PWei normalcase 2.0204 ms/op 1.6911 ms/op 1.19
altair processAttestation - 250000 vs - 7PWei worstcase 2.8857 ms/op 2.5342 ms/op 1.14
altair processAttestation - setStatus - 1/6 committees join 125.01 us/op 93.804 us/op 1.33
altair processAttestation - setStatus - 1/3 committees join 239.85 us/op 187.46 us/op 1.28
altair processAttestation - setStatus - 1/2 committees join 345.33 us/op 278.95 us/op 1.24
altair processAttestation - setStatus - 2/3 committees join 445.68 us/op 341.71 us/op 1.30
altair processAttestation - setStatus - 4/5 committees join 610.01 us/op 510.93 us/op 1.19
altair processAttestation - setStatus - 100% committees join 723.69 us/op 599.04 us/op 1.21
altair processBlock - 250000 vs - 7PWei normalcase 5.8849 ms/op 3.8238 ms/op 1.54
altair processBlock - 250000 vs - 7PWei normalcase hashState 30.743 ms/op 33.493 ms/op 0.92
altair processBlock - 250000 vs - 7PWei worstcase 38.244 ms/op 40.801 ms/op 0.94
altair processBlock - 250000 vs - 7PWei worstcase hashState 85.973 ms/op 86.163 ms/op 1.00
phase0 processBlock - 250000 vs - 7PWei normalcase 1.6262 ms/op 1.9932 ms/op 0.82
phase0 processBlock - 250000 vs - 7PWei worstcase 21.050 ms/op 25.865 ms/op 0.81
altair processEth1Data - 250000 vs - 7PWei normalcase 304.82 us/op 257.31 us/op 1.18
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 4.5490 us/op 5.0580 us/op 0.90
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 25.150 us/op 24.138 us/op 1.04
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 7.0310 us/op 7.4970 us/op 0.94
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 4.4660 us/op 7.3410 us/op 0.61
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 97.878 us/op 106.06 us/op 0.92
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 928.90 us/op 1.1193 ms/op 0.83
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 1.3735 ms/op 986.18 us/op 1.39
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 2.0040 ms/op 1.0155 ms/op 1.97
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 5.9553 ms/op 2.4592 ms/op 2.42
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 1.4626 ms/op 999.14 us/op 1.46
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 3.7886 ms/op 2.5734 ms/op 1.47
Tree 40 250000 create 475.31 ms/op 371.24 ms/op 1.28
Tree 40 250000 get(125000) 161.35 ns/op 118.38 ns/op 1.36
Tree 40 250000 set(125000) 1.5913 us/op 1.2886 us/op 1.23
Tree 40 250000 toArray() 18.634 ms/op 9.9550 ms/op 1.87
Tree 40 250000 iterate all - toArray() + loop 19.530 ms/op 10.022 ms/op 1.95
Tree 40 250000 iterate all - get(i) 56.123 ms/op 38.922 ms/op 1.44
Array 250000 create 2.5324 ms/op 2.3702 ms/op 1.07
Array 250000 clone - spread 833.01 us/op 649.32 us/op 1.28
Array 250000 get(125000) 0.40300 ns/op 0.57700 ns/op 0.70
Array 250000 set(125000) 0.42500 ns/op 0.58400 ns/op 0.73
Array 250000 iterate all - loop 111.98 us/op 76.877 us/op 1.46
phase0 afterProcessEpoch - 250000 vs - 7PWei 50.404 ms/op 40.374 ms/op 1.25
Array.fill - length 1000000 3.5839 ms/op 2.3988 ms/op 1.49
Array push - length 1000000 13.426 ms/op 11.285 ms/op 1.19
Array.get 0.28472 ns/op 0.26129 ns/op 1.09
Uint8Array.get 0.44951 ns/op 0.34540 ns/op 1.30
phase0 beforeProcessEpoch - 250000 vs - 7PWei 23.941 ms/op 12.893 ms/op 1.86
altair processEpoch - mainnet_e81889 285.16 ms/op 273.18 ms/op 1.04
mainnet_e81889 - altair beforeProcessEpoch 21.108 ms/op 16.191 ms/op 1.30
mainnet_e81889 - altair processJustificationAndFinalization 5.5340 us/op 4.5950 us/op 1.20
mainnet_e81889 - altair processInactivityUpdates 6.5537 ms/op 3.3280 ms/op 1.97
mainnet_e81889 - altair processRewardsAndPenalties 44.406 ms/op 48.600 ms/op 0.91
mainnet_e81889 - altair processRegistryUpdates 853.00 ns/op 816.00 ns/op 1.05
mainnet_e81889 - altair processSlashings 240.00 ns/op 399.00 ns/op 0.60
mainnet_e81889 - altair processEth1DataReset 180.00 ns/op 396.00 ns/op 0.45
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.2989 ms/op 941.91 us/op 1.38
mainnet_e81889 - altair processSlashingsReset 907.00 ns/op 1.0960 us/op 0.83
mainnet_e81889 - altair processRandaoMixesReset 1.6660 us/op 1.5170 us/op 1.10
mainnet_e81889 - altair processHistoricalRootsUpdate 218.00 ns/op 412.00 ns/op 0.53
mainnet_e81889 - altair processParticipationFlagUpdates 521.00 ns/op 847.00 ns/op 0.62
mainnet_e81889 - altair processSyncCommitteeUpdates 141.00 ns/op 365.00 ns/op 0.39
mainnet_e81889 - altair afterProcessEpoch 54.104 ms/op 41.137 ms/op 1.32
capella processEpoch - mainnet_e217614 950.94 ms/op 901.94 ms/op 1.05
mainnet_e217614 - capella beforeProcessEpoch 69.455 ms/op 67.211 ms/op 1.03
mainnet_e217614 - capella processJustificationAndFinalization 5.2410 us/op 5.0100 us/op 1.05
mainnet_e217614 - capella processInactivityUpdates 18.465 ms/op 15.842 ms/op 1.17
mainnet_e217614 - capella processRewardsAndPenalties 180.20 ms/op 183.89 ms/op 0.98
mainnet_e217614 - capella processRegistryUpdates 6.5620 us/op 6.8570 us/op 0.96
mainnet_e217614 - capella processSlashings 174.00 ns/op 459.00 ns/op 0.38
mainnet_e217614 - capella processEth1DataReset 173.00 ns/op 395.00 ns/op 0.44
mainnet_e217614 - capella processEffectiveBalanceUpdates 14.056 ms/op 11.715 ms/op 1.20
mainnet_e217614 - capella processSlashingsReset 905.00 ns/op 1.2090 us/op 0.75
mainnet_e217614 - capella processRandaoMixesReset 1.1780 us/op 1.2620 us/op 0.93
mainnet_e217614 - capella processHistoricalRootsUpdate 176.00 ns/op 397.00 ns/op 0.44
mainnet_e217614 - capella processParticipationFlagUpdates 516.00 ns/op 735.00 ns/op 0.70
mainnet_e217614 - capella afterProcessEpoch 125.77 ms/op 105.42 ms/op 1.19
phase0 processEpoch - mainnet_e58758 293.14 ms/op 300.56 ms/op 0.98
mainnet_e58758 - phase0 beforeProcessEpoch 70.984 ms/op 86.306 ms/op 0.82
mainnet_e58758 - phase0 processJustificationAndFinalization 5.6170 us/op 5.9160 us/op 0.95
mainnet_e58758 - phase0 processRewardsAndPenalties 34.751 ms/op 41.483 ms/op 0.84
mainnet_e58758 - phase0 processRegistryUpdates 3.0710 us/op 2.7940 us/op 1.10
mainnet_e58758 - phase0 processSlashings 170.00 ns/op 405.00 ns/op 0.42
mainnet_e58758 - phase0 processEth1DataReset 170.00 ns/op 401.00 ns/op 0.42
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.0257 ms/op 840.16 us/op 1.22
mainnet_e58758 - phase0 processSlashingsReset 921.00 ns/op 1.1550 us/op 0.80
mainnet_e58758 - phase0 processRandaoMixesReset 1.2010 us/op 1.5880 us/op 0.76
mainnet_e58758 - phase0 processHistoricalRootsUpdate 172.00 ns/op 407.00 ns/op 0.42
mainnet_e58758 - phase0 processParticipationRecordUpdates 841.00 ns/op 1.2960 us/op 0.65
mainnet_e58758 - phase0 afterProcessEpoch 41.570 ms/op 35.591 ms/op 1.17
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.2994 ms/op 977.63 us/op 1.33
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 2.0834 ms/op 2.3424 ms/op 0.89
altair processInactivityUpdates - 250000 normalcase 16.461 ms/op 17.057 ms/op 0.97
altair processInactivityUpdates - 250000 worstcase 16.530 ms/op 18.277 ms/op 0.90
phase0 processRegistryUpdates - 250000 normalcase 6.5640 us/op 3.5640 us/op 1.84
phase0 processRegistryUpdates - 250000 badcase_full_deposits 259.66 us/op 309.42 us/op 0.84
phase0 processRegistryUpdates - 250000 worstcase 0.5 99.453 ms/op 106.82 ms/op 0.93
altair processRewardsAndPenalties - 250000 normalcase 45.631 ms/op 32.511 ms/op 1.40
altair processRewardsAndPenalties - 250000 worstcase 38.833 ms/op 51.066 ms/op 0.76
phase0 getAttestationDeltas - 250000 normalcase 5.9862 ms/op 4.9848 ms/op 1.20
phase0 getAttestationDeltas - 250000 worstcase 5.9202 ms/op 6.5717 ms/op 0.90
phase0 processSlashings - 250000 worstcase 92.101 us/op 98.931 us/op 0.93
altair processSyncCommitteeUpdates - 250000 149.11 ms/op 112.26 ms/op 1.33
BeaconState.hashTreeRoot - No change 218.00 ns/op 447.00 ns/op 0.49
BeaconState.hashTreeRoot - 1 full validator 112.09 us/op 89.500 us/op 1.25
BeaconState.hashTreeRoot - 32 full validator 1.4072 ms/op 1.1925 ms/op 1.18
BeaconState.hashTreeRoot - 512 full validator 12.457 ms/op 12.112 ms/op 1.03
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 120.45 us/op 111.69 us/op 1.08
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 1.9536 ms/op 1.7367 ms/op 1.12
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 23.200 ms/op 28.048 ms/op 0.83
BeaconState.hashTreeRoot - 1 balances 70.383 us/op 72.065 us/op 0.98
BeaconState.hashTreeRoot - 32 balances 653.17 us/op 830.33 us/op 0.79
BeaconState.hashTreeRoot - 512 balances 7.5555 ms/op 9.8756 ms/op 0.77
BeaconState.hashTreeRoot - 250000 balances 175.38 ms/op 171.93 ms/op 1.02
aggregationBits - 2048 els - zipIndexesInBitList 22.737 us/op 18.602 us/op 1.22
byteArrayEquals 32 55.347 ns/op 46.405 ns/op 1.19
Buffer.compare 32 17.779 ns/op 16.501 ns/op 1.08
byteArrayEquals 1024 1.6357 us/op 1.2831 us/op 1.27
Buffer.compare 1024 25.397 ns/op 32.906 ns/op 0.77
byteArrayEquals 16384 26.063 us/op 20.400 us/op 1.28
Buffer.compare 16384 209.91 ns/op 193.53 ns/op 1.08
byteArrayEquals 123687377 200.32 ms/op 150.00 ms/op 1.34
Buffer.compare 123687377 7.9418 ms/op 5.8404 ms/op 1.36
byteArrayEquals 32 - diff last byte 52.523 ns/op 44.958 ns/op 1.17
Buffer.compare 32 - diff last byte 16.977 ns/op 15.206 ns/op 1.12
byteArrayEquals 1024 - diff last byte 1.6026 us/op 1.2269 us/op 1.31
Buffer.compare 1024 - diff last byte 26.517 ns/op 23.352 ns/op 1.14
byteArrayEquals 16384 - diff last byte 26.006 us/op 19.475 us/op 1.34
Buffer.compare 16384 - diff last byte 206.61 ns/op 170.00 ns/op 1.22
byteArrayEquals 123687377 - diff last byte 185.54 ms/op 152.85 ms/op 1.21
Buffer.compare 123687377 - diff last byte 6.0713 ms/op 3.9317 ms/op 1.54
byteArrayEquals 32 - random bytes 4.8980 ns/op 4.9300 ns/op 0.99
Buffer.compare 32 - random bytes 16.428 ns/op 16.923 ns/op 0.97
byteArrayEquals 1024 - random bytes 4.9670 ns/op 4.9250 ns/op 1.01
Buffer.compare 1024 - random bytes 16.702 ns/op 17.037 ns/op 0.98
byteArrayEquals 16384 - random bytes 4.9790 ns/op 4.8750 ns/op 1.02
Buffer.compare 16384 - random bytes 16.723 ns/op 17.061 ns/op 0.98
byteArrayEquals 123687377 - random bytes 6.1400 ns/op 7.8000 ns/op 0.79
Buffer.compare 123687377 - random bytes 17.600 ns/op 19.600 ns/op 0.90
regular array get 100000 times 31.312 us/op 30.739 us/op 1.02
wrappedArray get 100000 times 37.768 us/op 30.610 us/op 1.23
arrayWithProxy get 100000 times 13.586 ms/op 11.019 ms/op 1.23
ssz.Root.equals 44.322 ns/op 42.515 ns/op 1.04
byteArrayEquals 43.428 ns/op 43.225 ns/op 1.00
Buffer.compare 9.9530 ns/op 10.551 ns/op 0.94
processSlot - 1 slots 10.446 us/op 8.9470 us/op 1.17
processSlot - 32 slots 2.7460 ms/op 2.1582 ms/op 1.27
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 48.930 ms/op 59.684 ms/op 0.82
getCommitteeAssignments - req 1 vs - 250000 vc 2.1367 ms/op 1.7046 ms/op 1.25
getCommitteeAssignments - req 100 vs - 250000 vc 4.0131 ms/op 3.3692 ms/op 1.19
getCommitteeAssignments - req 1000 vs - 250000 vc 4.2564 ms/op 3.5696 ms/op 1.19
findModifiedValidators - 10000 modified validators 738.93 ms/op
findModifiedValidators - 1000 modified validators 683.09 ms/op
findModifiedValidators - 100 modified validators 241.24 ms/op
findModifiedValidators - 10 modified validators 187.03 ms/op
findModifiedValidators - 1 modified validators 247.78 ms/op
findModifiedValidators - no difference 206.37 ms/op
compare ViewDUs 6.2433 s/op 6.0514 s/op 1.03
compare each validator Uint8Array 1.4936 s/op 863.10 ms/op 1.73
compare ViewDU to Uint8Array 1.1127 s/op 890.80 ms/op 1.25
migrate state 1000000 validators, 24 modified, 0 new 875.91 ms/op 793.03 ms/op 1.10
migrate state 1000000 validators, 1700 modified, 1000 new 1.2038 s/op 1.1929 s/op 1.01
migrate state 1000000 validators, 3400 modified, 2000 new 1.4427 s/op 1.1763 s/op 1.23
migrate state 1500000 validators, 24 modified, 0 new 869.02 ms/op 869.21 ms/op 1.00
migrate state 1500000 validators, 1700 modified, 1000 new 1.0677 s/op 1.0163 s/op 1.05
migrate state 1500000 validators, 3400 modified, 2000 new 1.2260 s/op 1.1690 s/op 1.05
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 4.3400 ns/op 5.6600 ns/op 0.77
state getBlockRootAtSlot - 250000 vs - 7PWei 386.97 ns/op 452.32 ns/op 0.86
computeProposers - vc 250000 6.3426 ms/op 6.9085 ms/op 0.92
computeEpochShuffling - vc 250000 43.042 ms/op 34.276 ms/op 1.26
getNextSyncCommittee - vc 250000 128.63 ms/op 98.239 ms/op 1.31
computeSigningRoot for AttestationData 25.238 us/op 21.912 us/op 1.15
hash AttestationData serialized data then Buffer.toString(base64) 1.5802 us/op 1.2096 us/op 1.31
toHexString serialized data 1.0472 us/op 725.45 ns/op 1.44
Buffer.toString(base64) 169.84 ns/op 114.65 ns/op 1.48
nodejs block root to RootHex using toHex 145.74 ns/op 113.96 ns/op 1.28
nodejs block root to RootHex using toRootHex 86.003 ns/op 74.577 ns/op 1.15
browser block root to RootHex using the deprecated toHexString 228.96 ns/op 195.20 ns/op 1.17
browser block root to RootHex using toHex 173.85 ns/op 160.01 ns/op 1.09
browser block root to RootHex using toRootHex 159.59 ns/op 147.10 ns/op 1.08

by benchmarkbot/action

nflaig
nflaig approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@nflaig nflaig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated the PR description to close #7380

@wemeetagain wemeetagain merged commit 7982031 into unstable Jan 31, 2025
21 checks passed
@wemeetagain wemeetagain deleted the nh/revert-skip-perf branch January 31, 2025 15:47
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.26.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wemeetagain wemeetagain wemeetagain approved these changes

@nflaig nflaig nflaig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Diagnose why findModifiedValidators benchmark failing after upgrading
3 participants
@nazarhussain @wemeetagain @nflaig