Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bin Preview #1093

Merged
merged 3 commits into from
Jun 7, 2021
Merged

Fix Bin Preview #1093

merged 3 commits into from
Jun 7, 2021

Conversation

FSM1
Copy link
Contributor

@FSM1 FSM1 commented Jun 4, 2021

Update to new api client and wire up download

@render
Copy link

render bot commented Jun 4, 2021

@FSM1 FSM1 requested review from tanmoyAtb, RyRy79261 and Tbaut and removed request for tanmoyAtb June 4, 2021 13:57
Copy link
Contributor

@tanmoyAtb tanmoyAtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels good to see the bucket implementations in action 🚀

Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pushed a commit to avoid having 2 different packages for cypress in the monorepo.
Looks good!

@Tbaut Tbaut added the Type: Bug Fix Added to PRs if they are addressing a bug label Jun 4, 2021
@Tbaut
Copy link
Collaborator

Tbaut commented Jun 4, 2021

Not sure why the Pr labeler didn't run here, maybe because of Github actioin down at that time because of payment 🤷‍♂️ Will keep it in mind it it doesn't work for the next ones.

@FSM1 FSM1 linked an issue Jun 6, 2021 that may be closed by this pull request
@FSM1 FSM1 merged commit 29488cc into dev Jun 7, 2021
@FSM1 FSM1 deleted the fix/bin-browser-preview-1071 branch June 7, 2021 21:13
@FSM1 FSM1 mentioned this pull request Jun 15, 2021
FSM1 added a commit that referenced this pull request Jun 15, 2021
* Updated-labels

* Removed Reference dev

* Update readme.md (#1083)

* Update readme.md

* Update readme.md

* Drop the last sentence from readme.md

Co-authored-by: Michael Yankelev <[email protected]>

* Survey v2 for product market fit (#1082)

* v2

* translatioin FR

* more

* lingui extract

* with gradient

* Update packages/files-ui/src/Components/SurveyBanner.tsx

Co-authored-by: Cindy Chau <[email protected]>

* lingui extract

* Update packages/files-ui/src/locales/fr/messages.po

* different gradient for better readability

Co-authored-by: GitHub Actions <[email protected]>
Co-authored-by: Cindy Chau <[email protected]>

* Storage app skeleton  (#1067)

* remove old chainsafe x package

* initial app skeleton and refactor

* fix api client issues

* remove old chainsafe x package

* initial app skeleton and refactor

* fix api client issues

* remove tests

* Apply suggestions from code review

Co-authored-by: Tanmoy Basak Anjan <[email protected]>

* Update packages/storage-ui/src/Contexts/StorageApiContext.tsx

Co-authored-by: Tanmoy Basak Anjan <[email protected]>

* make eslint :D again

* remove unneeded login methods

Co-authored-by: Tanmoy Basak Anjan <[email protected]>

* Update release-drafter with the new name (#1088)

* Update release-drafter.yml

* Update .github/release-drafter.yml

Co-authored-by: Michael Yankelev <[email protected]>

* Add page object pattern for ui tests (#1080)

* Add PR labeler based on the branch name (#1089)

* pr labeler

* with workflow

* for PR

* back to open

Co-authored-by: Michael Yankelev <[email protected]>

* passwordless login (#1072)

* UI ready

* UI ready and trans ready

* work in progress

* lingui extract

* passwordless login

* code and login

* loaders on passwordless login

* wallet names

* lingui extract

* Delete package.json

* feedback

* lingui extract

* Cleanup InitialScreen (#1092)

* cleanup

* spaces

* compile update

* fr translation and ternarry nits

Co-authored-by: GitHub Actions <[email protected]>
Co-authored-by: Thibaut Sardan <[email protected]>
Co-authored-by: Michael Yankelev <[email protected]>
Co-authored-by: Thibaut Sardan <[email protected]>

* Fix Bin Preview (#1093)

* update to new api client and wire up download

* cypress bump to avoid having 2 packages

Co-authored-by: Thibaut Sardan <[email protected]>

* Update pr-labeler.yml (#1099)

* Update pr-labeler.yml

* Update pr-labeler.yml

* Update pr-labeler.yml

* Update pr-labeler.yml

* Update pr-labeler.yml

* Apply suggestions from code review

* Update .github/workflows/pr-labeler.yml

Co-authored-by: Michael Yankelev <[email protected]>

* removed redundant stage & prod release which is replaced by release drafter; updated readme (#1102)

Co-authored-by: Thibaut Sardan <[email protected]>

* Fix InitialScreen.tsx Error messages (#1100)

* Update InitialScreen.tsx

* Update packages/files-ui/src/Components/Modules/LoginModule/InitialScreen.tsx

Co-authored-by: Michael Yankelev <[email protected]>

* Deprecate all `files/` endpoints (#1095)

* deprecate all `files/` endpoints

* clean up remaining todos

* Update packages/files-ui/src/Components/Modules/FileBrowsers/BinFileBrowser.tsx

Co-authored-by: Tanmoy Basak Anjan <[email protected]>

* fix lint

* update to latest api client

Co-authored-by: Tanmoy Basak Anjan <[email protected]>

* Files API Client in Tests (#1097)

* use api client in tests

* fix detached from the Dom (#1096)

Co-authored-by: Thibaut Sardan <[email protected]>

* make eslint :D

* update yarn lock

* update commands

Co-authored-by: Thibaut Sardan <[email protected]>
Co-authored-by: Thibaut Sardan <[email protected]>

* Recover files with move file modal  (#1094)

* recover files in modal

* move file restructure

* lingui extract

* deprecate all `files/` endpoints

* clean up remaining todos

* Update packages/files-ui/src/Components/Modules/FileBrowsers/BinFileBrowser.tsx

Co-authored-by: Tanmoy Basak Anjan <[email protected]>

* fix lint

* move file update

* lint and installs

* Update packages/files-ui/src/Components/Modules/FileBrowsers/MoveFileModal.tsx

Co-authored-by: Thibaut Sardan <[email protected]>

* Update packages/files-ui/src/Components/Modules/FileBrowsers/MoveFileModal.tsx

Co-authored-by: Thibaut Sardan <[email protected]>

* Update packages/files-ui/src/locales/fr/messages.po

Co-authored-by: Thibaut Sardan <[email protected]>

* Update packages/files-ui/src/Components/Modules/FileBrowsers/MoveFileModal.tsx

Co-authored-by: Thibaut Sardan <[email protected]>

* Update packages/files-ui/src/locales/fr/messages.po

Co-authored-by: Thibaut Sardan <[email protected]>

Co-authored-by: GitHub Actions <[email protected]>
Co-authored-by: Michael Yankelev <[email protected]>
Co-authored-by: Michael Yankelev <[email protected]>
Co-authored-by: Thibaut Sardan <[email protected]>

* Update file management ui tests (#1113)

* Fix mistake

* Update homepage page object and file management tests

* Fix typo in test identifier

* update homePage object

* use api client in tests

* fix detached from the Dom (#1096)

Co-authored-by: Thibaut Sardan <[email protected]>

* wip

* Increase cypress page load timeout

* Rename element and update page object

* Update file management ui tests

* Remove white space

Co-authored-by: Thibaut Sardan <[email protected]>

* Revert to default page load timeout

Co-authored-by: Michael Yankelev <[email protected]>
Co-authored-by: Michael Yankelev <[email protected]>
Co-authored-by: Thibaut Sardan <[email protected]>
Co-authored-by: Thibaut Sardan <[email protected]>

* Wording for backup **secret** phrase (#1116)

* wording for secret phrase

* lingui extract

* Update packages/files-ui/src/locales/fr/messages.po

Co-authored-by: GitHub Actions <[email protected]>

* CIDs overview (#1117)

* wip

* v1.14

* v1.15-rc1

* show Cids

* buckets in nav bar

* cleanup

* cid instead of pin

* in menus

* login on refresh - storage ui (#1109)

* with local storage

* local or session

* v2 api spec

* v2.1

Co-authored-by: Thibaut Sardan <[email protected]>
Co-authored-by: Thibaut Sardan <[email protected]>
Co-authored-by: Tanmoy Basak Anjan <[email protected]>

* Put eslint at top level since it's shared by all packages (#1115)

* eslint at top level

* fix lint

Co-authored-by: Michael Yankelev <[email protected]>

* Allow to unpin a Cid (#1110)

* wip

* v1.14

* v1.15-rc1

* show Cids

* buckets in nav bar

* cleanup

* cid instead of pin

* in menus

* unpin and styling

* lint

* eslint 6.8 to make react-script happy (#1121)

* Add identifier for the upload status box (#1122)

Co-authored-by: Thibaut Sardan <[email protected]>

* tkey address in settings (#1112)

* key address added

* lingui extract

* Update packages/files-ui/src/Components/Modules/Settings/Profile.tsx

Co-authored-by: Thibaut Sardan <[email protected]>

* Update packages/files-ui/src/Components/Modules/Settings/Profile.tsx

Co-authored-by: Michael Yankelev <[email protected]>

* Update packages/files-ui/src/Components/Modules/Settings/Profile.tsx

Co-authored-by: Michael Yankelev <[email protected]>

* lingui extract

* renames

Co-authored-by: GitHub Actions <[email protected]>
Co-authored-by: Michael Yankelev <[email protected]>
Co-authored-by: Thibaut Sardan <[email protected]>

* Force refresh on buckets when deleting from bin (#1127)

* Force refresh

* Liniting

* Linting

* Added to upload

* Copied across styling (#1125)

Co-authored-by: Thibaut Sardan <[email protected]>

* Dnd Fix destination path (#1118)

* fix destination path

* Implement suggestion

Co-authored-by: Thibaut Sardan <[email protected]>

* Handle walletconnect signature request (#1124)

* handle walletconnect signature request

* Update packages/files-ui/src/Contexts/ThresholdKeyContext.tsx

Co-authored-by: Ryan Noble <[email protected]>

* fix lint

Co-authored-by: Thibaut Sardan <[email protected]>
Co-authored-by: Ryan Noble <[email protected]>

* Remove Facebook login (#1136)

* hide facebook login

* lingui extract

Co-authored-by: GitHub Actions <[email protected]>

* email button disabled like others (#1137)

Co-authored-by: Shiva <[email protected]>
Co-authored-by: Cindy Chau <[email protected]>
Co-authored-by: Thibaut Sardan <[email protected]>
Co-authored-by: GitHub Actions <[email protected]>
Co-authored-by: Tanmoy Basak Anjan <[email protected]>
Co-authored-by: Andrew Snaith <[email protected]>
Co-authored-by: Thibaut Sardan <[email protected]>
Co-authored-by: Priom Chowdhury <[email protected]>
Co-authored-by: Ryan Noble <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Fix Added to PRs if they are addressing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In the Bin: There was an error generating the preview
3 participants