Fix refresh token flow

[FSM1]

Closes #1224

Replace call to the session storage helper with direct browser Api calls to sessionStorage.getItem() inside the refresh token handler.

[render]

Your Render PR Server URL is https://storage-ui-stage-pr-1235.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c3hne6c7o9q2usc8i3mg.

[render]

Your Render PR Server URL is https://files-ui-stage-pr-1235.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c3hne6s7o9q2usc8i3v0.

[Tbaut]

Looks good, I had a look at the code, and I'm not sure I understand the withLocalStorage altogether. If you recall what this is @FSM1 and let me know, I'd be happy to add some comments about it.

[FSM1]

Looks good, I had a look at the code, and I'm not sure I understand the withLocalStorage altogether. If you recall what this is @FSM1 and let me know, I'd be happy to add some comments about it.

When the FilesApiContext was originally built, it was meant to be more generic component, and a flag could be passed in that would determine where the refresh token was stored (local or session).

The real issue this ticket solves is that the initialize useEffect (which we really only want to run once) did not have the sessionStorageGet and localStorageGet functions as part of the dependency array, and as such these were always resolving to undefined (in the context of the refresh token handling flow), and no token refresh was happening. Using the browser API directly solves this issue.

Since Files is only using session storage for the refresh token, I just removed the localStorage branch of the ternary.