DirectAuth updates for Storage #1248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyRy79261
added
Epic: Storage v0
Type: Feature
|
Your Render PR Server URL is https://files-ui-stage-pr-1248.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c3irutk7o9q2usc9k5r0. |
|
Your Render PR Server URL is https://storage-ui-stage-pr-1248.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c3iruu47o9q2usc9k6d0. |
… into feat/direct-auth-1207
… into feat/direct-auth-1207
… into feat/direct-auth-1207
RyRy79261
added
the
Status: Review Needed 👀
FSM1
approved these changes
Jul 9, 2021
Tbaut
approved these changes
Jul 9, 2021
packages/storage-ui/src/Components/Modules/LoginModule/PasswordlessEmail.tsx
Outdated
Show resolved
Hide resolved
packages/storage-ui/src/Components/Modules/LoginModule/PasswordlessEmail.tsx
Outdated
Show resolved
Hide resolved
packages/storage-ui/src/Components/Modules/LoginModule/PasswordlessEmail.tsx
Outdated
Show resolved
Hide resolved
packages/storage-ui/src/Components/Modules/LoginModule/PasswordlessEmail.tsx
Outdated
Show resolved
Hide resolved
packages/storage-ui/src/Components/Modules/LoginModule/PasswordlessEmail.tsx
Outdated
Show resolved
Hide resolved
| const getIdentityToken = async ( | ||
| loginType: IdentityProvider, | ||
| tokenInfo?: {token: IdentityToken; email: string} | ||
| ): Promise<{identityToken: IdentityToken; userInfo: any}> => { |
There was a problem hiding this comment.
Any way we can type this strongly?
There was a problem hiding this comment.
I played around with it and have not managed to come up with a type definition that works. Given the tiny surface area of this type, I would say we should leave it as is.
Co-authored-by: Thibaut Sardan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1207