Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Barebones gaming app #1256

Merged
merged 8 commits into from
Jul 13, 2021
Merged

Barebones gaming app #1256

merged 8 commits into from
Jul 13, 2021

Conversation

FSM1
Copy link
Contributor

@FSM1 FSM1 commented Jul 9, 2021

Closes #1205

@render
Copy link

render bot commented Jul 9, 2021

Your Render PR Server URL is https://gaming-ui-stage-pr-1256.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c3k6g646fj344vb94100.

@render
Copy link

render bot commented Jul 9, 2021

Your Render PR Server URL is https://storage-ui-stage-pr-1256.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c3k6g6k6fj344vb9418g.

@render
Copy link

render bot commented Jul 9, 2021

Your Render PR Server URL is https://files-ui-stage-pr-1256.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c3k6g7c6fj344vb941kg.

@github-actions github-actions bot added the Type: Feature Added to PRs to identify that the change is a new feature. label Jul 9, 2021
@FSM1 FSM1 self-assigned this Jul 9, 2021
@FSM1 FSM1 added the Status: Review Needed 👀 Added to PRs when they need more review label Jul 9, 2021
@lgtm-com
Copy link

lgtm-com bot commented Jul 9, 2021

This pull request introduces 12 alerts when merging 4b09434 into 32ec2c6 - view on LGTM.com

new alerts:

  • 8 for Duplicate character in character class
  • 4 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Jul 12, 2021

This pull request introduces 12 alerts when merging acb34f4 into 32ec2c6 - view on LGTM.com

new alerts:

  • 8 for Duplicate character in character class
  • 4 for Unused variable, import, function or class

RyRy79261
RyRy79261 reviewed Jul 12, 2021
View reviewed changes
Copy link
Contributor

@RyRy79261 RyRy79261 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor things, still need to run the code

packages/gaming-ui/src/Components/GamingRoutes.tsx Outdated Show resolved Hide resolved
packages/gaming-ui/src/Components/GamingRoutes.tsx Outdated Show resolved Hide resolved
packages/gaming-ui/src/Components/Modules/ApiKeys.tsx Outdated Show resolved Hide resolved
RyRy79261
RyRy79261 approved these changes Jul 12, 2021
View reviewed changes
Copy link
Contributor

@RyRy79261 RyRy79261 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like its working, just some Storage name artifacts lying around

@lgtm-com
Copy link

lgtm-com bot commented Jul 12, 2021

This pull request introduces 12 alerts when merging be9785b into 32ec2c6 - view on LGTM.com

new alerts:

  • 8 for Duplicate character in character class
  • 4 for Unused variable, import, function or class

tanmoyAtb
tanmoyAtb approved these changes Jul 12, 2021
View reviewed changes
Copy link
Contributor

@tanmoyAtb tanmoyAtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!
🎆

@lgtm-com
Copy link

lgtm-com bot commented Jul 13, 2021

This pull request introduces 12 alerts when merging 4740e5b into e51adc9 - view on LGTM.com

new alerts:

  • 8 for Duplicate character in character class
  • 4 for Unused variable, import, function or class

@FSM1 FSM1 merged commit 2de4dc5 into dev Jul 13, 2021
@FSM1 FSM1 deleted the feat/gaming-ui-setup-1205 branch July 13, 2021 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyRy79261 RyRy79261 RyRy79261 approved these changes

@tanmoyAtb tanmoyAtb tanmoyAtb approved these changes

Assignees

@FSM1 FSM1

Labels
Status: Review Needed 👀 Added to PRs when they need more review Type: Feature Added to PRs to identify that the change is a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gaming UI Setup
4 participants
@FSM1 @RyRy79261 @tanmoyAtb @actions-user