Fix to prevent from moving folders in sub-folders

[Tbaut]

closes #1276

My helper function involves some JS tricks that I commented, let me know if it's not clear.

[render]

Your Render PR Server URL is https://gaming-ui-stage-pr-1277.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c3o2ej2p7h3lv6b3lhbg.

[render]

Your Render PR Server URL is https://storage-ui-stage-pr-1277.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c3o2ejip7h3lv6b3lhl0.

[render]

Your Render PR Server URL is https://files-ui-stage-pr-1277.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c3o2ek2p7h3lv6b3li0g.

[FSM1]

It seems like there is something going wrong with the logic here:

See the screenshot above where I am trying to move /another parent into /parent but not being allowed to even though there is nothing that should be preventing the move. i.e. after the move the path should be

|-parent
|--Another parent
|--child of parent

[Tbaut]

Ah right, nice catch, I don't allow to move the folder into any subfolder of the current path. I'll adapt.

[Tbaut]

Ok this is turning into some dark magic.. I will probably not understand half of it any more in 2 weeks, hence the comments.
I tested the weirdest things and it look all right to me now.

[asnaith]

I just tested out the fix on Render (for Storage). It looks good for subfolders now, it's not possible to move a parent into a subfolder.

However, on a related note I just noticed you can move the parent into itself, "Folder1" to "Folder1", and loose access in the UI. Do you want to address in this PR or should I create a separate issue?

Video:

move-folder-issue.mov

[tanmoyAtb]

Amazing,
A few comments to resolve some of the problems.

[asnaith]

Top level seems good now, I cannot move a parent into a child folder or itself.

I know this is expanding the scope of the original ticket but I've found a couple of additional issues that are related to this, regarding child folders. You can cause a child folder to become unreachable in two scenarios

• When moving it into the parent folder that it is already in
• When when moving it to itself

Can we show the same error when trying to move child folders in this way too?

[Tbaut]

When moving it into the parent folder that it is already in
When when moving it to itself

I can't reproduce this, it's not allowed for me. Can you do another round of check @tanmoyAtb and @FSM1 when you have the chance? I'd love to get to the bottom of it today :)

Here's what I'm testing, at the root, and in a sub-folder, and it looks good.

move.mp4

[tanmoyAtb]

For me both of these cases are working as expected,
I'm not allowed to,

• move into one's parent folder
• move onto itself

[tanmoyAtb]

Tested out all the cases I could think of,
working for me 💯

[FSM1]

Also tested all the scenarios I could think of and seem unable to break it 🎉