Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance login screen with quicker email #1352

Merged
merged 6 commits into from
Jul 27, 2021
Merged

Enhance login screen with quicker email #1352

merged 6 commits into from
Jul 27, 2021

Conversation

Tbaut
Copy link
Collaborator

@Tbaut Tbaut commented Jul 27, 2021

  • closes New sign-in screen #1209
  • adds an ethereum logo
  • slight change in the copy of the original design to make it less redundant with the "Continue" being repeated.

@render
Copy link

render bot commented Jul 27, 2021

Your Render PR Server URL is https://gaming-ui-stage-pr-1352.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c400ns9g7hp1ulqcunt0.

@render
Copy link

render bot commented Jul 27, 2021

Your Render PR Server URL is https://storage-ui-stage-pr-1352.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c400nspg7hp1ulqcuo6g.

@render
Copy link

render bot commented Jul 27, 2021

Your Render PR Server URL is https://files-ui-stage-pr-1352.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c400nt1g7hp1ulqcuojg.

@github-actions github-actions bot added the Type: Feature Added to PRs to identify that the change is a new feature. label Jul 27, 2021
@Tbaut Tbaut marked this pull request as ready for review July 27, 2021 13:57
@Tbaut Tbaut requested review from tanmoyAtb, FSM1 and RyRy79261 and removed request for tanmoyAtb and FSM1 July 27, 2021 13:57
@Tbaut
Copy link
Collaborator Author

Tbaut commented Jul 27, 2021

it's already a big enough one, I'll create other PRs for Gaming and Storage once this one is reviewed. It'll be mostly copy/paste, and that's where a lot of errors get introduced 🙈

tanmoyAtb
tanmoyAtb approved these changes Jul 27, 2021
View reviewed changes
Copy link
Contributor

@tanmoyAtb tanmoyAtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! 👍

@Tbaut Tbaut added the Status: Review Needed 👀 Added to PRs when they need more review label Jul 27, 2021
@asnaith
Copy link
Contributor

asnaith commented Jul 27, 2021

Looking good on render. Really nice improvement to streamline the process.

Liking the addition of the ethereum logo on the web3 button too!

FSM1
FSM1 approved these changes Jul 27, 2021
View reviewed changes
Copy link
Contributor

@FSM1 FSM1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works great

@Tbaut Tbaut merged commit 7e53df1 into dev Jul 27, 2021
@Tbaut Tbaut deleted the feat/tbaut-rapid-email-1209 branch July 27, 2021 22:31
@Tbaut Tbaut mentioned this pull request Aug 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asnaith asnaith asnaith approved these changes

@tanmoyAtb tanmoyAtb tanmoyAtb approved these changes

@FSM1 FSM1 FSM1 approved these changes

@RyRy79261 RyRy79261 Awaiting requested review from RyRy79261

Assignees
No one assigned
Labels
Status: Review Needed 👀 Added to PRs when they need more review Type: Feature Added to PRs to identify that the change is a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New sign-in screen
5 participants
@Tbaut @asnaith @tanmoyAtb @FSM1 @actions-user