Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Files] Make sure DL as zip is sequential #1817

Merged
merged 4 commits into from
Dec 9, 2021
Merged

[Files] Make sure DL as zip is sequential #1817

merged 4 commits into from
Dec 9, 2021

Conversation

Tbaut
Copy link
Collaborator

@Tbaut Tbaut commented Dec 8, 2021 •
edited
Loading

Starting by awaiting the result of the previous reduce iteration makes sure the flow is sequential.

Submission checklist:

Layout

  • Change looks good in the desktop web ui
  • Change looks good in the mobile web ui

Theme

  • Components / elements inspected in light mode
  • Components / elements inspected in dark mode

@Tbaut Tbaut requested a review from tanmoyAtb December 8, 2021 11:53
@render
Copy link

render bot commented Dec 8, 2021

Your Render PR Server URL is https://storage-ui-stage-pr-1817.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c6o9plvd17cfv18rp8t0.

@render
Copy link

render bot commented Dec 8, 2021

Your Render PR Server URL is https://chainsafe-components-stage-pr-1817.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c6o9pmfd17cfv18rp99g.

@render
Copy link

render bot commented Dec 8, 2021

Your Render PR Server URL is https://files-ui-stage-pr-1817.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c6o9pmvd17cfv18rp9e0.

@github-actions github-actions bot added the Type: Bug Fix Added to PRs if they are addressing a bug label Dec 8, 2021
@Tbaut Tbaut changed the title [Files] ake sure DL as zip is sequential [Files] Make sure DL as zip is sequential Dec 8, 2021
@Tbaut Tbaut requested a review from FSM1 December 8, 2021 11:54
@Tbaut Tbaut added the Status: Review Needed 👀 Added to PRs when they need more review label Dec 8, 2021
@FSM1 FSM1 requested a review from asnaith December 8, 2021 12:57
@asnaith
Copy link
Contributor

asnaith commented Dec 8, 2021

Nice @Tbaut. This is working really well, a huge improvement over previous performance

@FSM1 FSM1 merged commit 53b9d71 into dev Dec 9, 2021
@FSM1 FSM1 deleted the fix/tbaut-dl-sequencial branch December 9, 2021 10:57
FSM1 added a commit that referenced this pull request Dec 9, 2021
@FSM1 @Tbaut @actions-user
Release - 2021-12-09 (#1823)
ea05f3e 
* Translated using Weblate (French)

Currently translated at 100.0% (310 of 310 strings)

Translation: ChainSafe Files/Chainsafe Files user interface
Translate-URL: https://hosted.weblate.org/projects/chainsafe-files/chainsafe-files-user-interface/fr/

* fix checkbox (#1805)

Co-authored-by: Michael Yankelev <[email protected]>

* [Files] Make sure DL as zip is sequential (#1817)

* make sure DL as zip is sequential

* Update packages/files-ui/src/Contexts/FilesContext.tsx

* lingui extract

Co-authored-by: Michael Yankelev <[email protected]>
Co-authored-by: GitHub Actions <[email protected]>

Co-authored-by: J. Lavoie <[email protected]>
Co-authored-by: Thibaut Sardan <[email protected]>
Co-authored-by: GitHub Actions <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asnaith asnaith asnaith approved these changes

@FSM1 FSM1 FSM1 approved these changes

@tanmoyAtb tanmoyAtb Awaiting requested review from tanmoyAtb

Assignees
No one assigned
Labels
Status: Review Needed 👀 Added to PRs when they need more review Type: Bug Fix Added to PRs if they are addressing a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Tbaut @asnaith @FSM1 @actions-user