-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plan details yearly monthly styles #1872
Conversation
Your Render PR Server URL is https://storage-ui-stage-pr-1872.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c7lc0u8nlki59c8ejcn0. |
Your Render PR Server URL is https://chainsafe-components-stage-pr-1872.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c7lc0uonlki59c8ejd3g. |
Your Render PR Server URL is https://files-ui-stage-pr-1872.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c7lc0v8nlki59c8ejd80. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is working well 👍
I noticed this branch had conflicts that needed resolving and it was because I'd just merged some tests to dev (after your pr submission) that related to the plan details. I was checking to make sure the label changed when the toggle was enabled etc.
I resolved the conflicts and updated the tests to reflect current behavior in this PR, thought it would be quicker for me to do it as I knew exactly what was going on.
Thanks a lot for taking care of this ! The changes look good 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just could we add the % discount next to the yearly billing as seen in the mock #1856 (comment)? That's very informative IMHO.
packages/files-ui/src/Components/Modules/Settings/SubscriptionTab/ChangePlan/PlanDetails.tsx
Outdated
Show resolved
Hide resolved
…Tab/ChangePlan/PlanDetails.tsx Co-authored-by: Thibaut Sardan <[email protected]>
…-change-billing-1856
…ui-monorepo into mnt/style-change-billing-1856
Thanks, what I meant is that we should calculate programmatically what percentage it is, we have both prices so that shouldn't be a problem to calculate, |
The percentage update is up ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, thanks a lot!
closes #1856
Submission checklist:
Layout
Theme