Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info messages before payment and on downgrade #1924

Merged
merged 8 commits into from
Feb 8, 2022

Conversation

Tbaut
Copy link
Collaborator

@Tbaut Tbaut commented Feb 8, 2022

closes #1912


Submission checklist:

Layout

  • Change looks good in the desktop web ui
  • Change looks good in the mobile web ui

Theme

  • Components / elements inspected in light mode
  • Components / elements inspected in dark mode

@Tbaut Tbaut requested review from tanmoyAtb and FSM1 February 8, 2022 14:54
@render
Copy link

render bot commented Feb 8, 2022

@render
Copy link

render bot commented Feb 8, 2022

@Tbaut Tbaut requested a review from asnaith February 8, 2022 14:54
@render
Copy link

render bot commented Feb 8, 2022

@github-actions github-actions bot added the Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes. label Feb 8, 2022
@FSM1
Copy link
Contributor

FSM1 commented Feb 8, 2022

Overall looks great, though I did notice that one of the info icons is grey while the other is red
image
image

@Tbaut
Copy link
Collaborator Author

Tbaut commented Feb 8, 2022

yeah I followed the design #1911 that's from another PR
but I agree we shouldn't do things differently. I'll make it the same.

@asnaith
Copy link
Contributor

asnaith commented Feb 8, 2022

I pushed a commit to this branch to update the tests to check for the presence of these additional elements (just the downgrade and change plan warnings, for now, I haven't automated the pay with crypto modal yet).

@Tbaut Tbaut merged commit 2e88ef8 into dev Feb 8, 2022
@Tbaut Tbaut deleted the mnt/tbaut-info-downgrade-1912 branch February 8, 2022 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Final Sale/Non-Refundable warnings to Billing Flow
4 participants