Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt Settings to the design and split the Display and Profile settings #1934

Merged
merged 6 commits into from
Feb 11, 2022

Conversation

Tbaut
Copy link
Collaborator

@Tbaut Tbaut commented Feb 10, 2022

closes #1907
The easiest is to play with it, and see if you find anything inconsistent.


Submission checklist:

Layout

  • Change looks good in the desktop web ui
  • Change looks good in the mobile web ui

Theme

  • Components / elements inspected in light mode
  • Components / elements inspected in dark mode

@render
Copy link

render bot commented Feb 10, 2022

@render
Copy link

render bot commented Feb 10, 2022

@render
Copy link

render bot commented Feb 10, 2022

@github-actions github-actions bot added the Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes. label Feb 10, 2022
Copy link
Contributor

@asnaith asnaith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and makes sense. It's nicer to use on mobile too 👍

Copy link
Contributor

@tanmoyAtb tanmoyAtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing amazing work, UX is much better.

Just found this small margin offset, we might not keep this section anyway, still putting it here.
The button on first and last name,

Screenshot 2022-02-11 at 8 23 19 PM

@Tbaut
Copy link
Collaborator Author

Tbaut commented Feb 11, 2022

Thanks, whether or not we keep it, I guess we would only comment it out, so I'll def fix that now

Copy link
Contributor

@FSM1 FSM1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, this feels much smoother an experience🎉

@Tbaut
Copy link
Collaborator Author

Tbaut commented Feb 11, 2022

Little heads up, I added a last minute small change to my settings PR, by removing the lock icon to the "Save change" button because IMHO a lock doesn't fit with saving a user name (this same icon is used on the security tab) and we don't use icons on buttons in general. lmk if you disagree. Also a note to myself, when disabled, this button has the same color as the background and looks totally out of place :)

image

@Tbaut Tbaut merged commit 06081bf into dev Feb 11, 2022
@Tbaut Tbaut deleted the mnt/tbaut-settings-1907 branch February 11, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consistent Header + Menu Font Sizing
5 participants