-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt Settings to the design and split the Display and Profile settings #1934
Conversation
Your Render PR Server URL is https://chainsafe-components-stage-pr-1934.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c82mnpn6d9kguk5p7hpg. |
Your Render PR Server URL is https://storage-ui-stage-pr-1934.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c82mnq76d9kguk5p7hu0. |
Your Render PR Server URL is https://files-ui-stage-pr-1934.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c82mnqv6d9kguk5p7iag. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great and makes sense. It's nicer to use on mobile too 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, whether or not we keep it, I guess we would only comment it out, so I'll def fix that now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, this feels much smoother an experience🎉
Little heads up, I added a last minute small change to my settings PR, by removing the lock icon to the "Save change" button because IMHO a lock doesn't fit with saving a user name (this same icon is used on the security tab) and we don't use icons on buttons in general. lmk if you disagree. Also a note to myself, when disabled, this button has the same color as the background and looks totally out of place :) |
closes #1907
The easiest is to play with it, and see if you find anything inconsistent.
Submission checklist:
Layout
Theme