Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Files Billing soft launch #1948

Merged
merged 10 commits into from
Feb 16, 2022
Merged

Files Billing soft launch #1948

merged 10 commits into from
Feb 16, 2022

Conversation

FSM1
Copy link
Contributor

@FSM1 FSM1 commented Feb 15, 2022 •
edited
Loading

Since the actual tab content does not get rendered, I decided not to mess with the router switch at all, as at worst a blank tab is rendered, if the user does decide to mess with the path directly.

closes #1930

Submission checklist:

Layout

  • Change looks good in the desktop web ui
  • Change looks good in the mobile web ui

Theme

  • Components / elements inspected in light mode
  • Components / elements inspected in dark mode

@render
Copy link

render bot commented Feb 15, 2022

Your Render PR Server URL is https://chainsafe-components-stage-pr-1948.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c85r7jvd17cc8bda7uc0.

@render
Copy link

render bot commented Feb 15, 2022

Your Render PR Server URL is https://storage-ui-stage-pr-1948.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c85r7kvd17cc8bda7ugg.

@render
Copy link

render bot commented Feb 15, 2022

Your Render PR Server URL is https://files-ui-stage-pr-1948.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c85r7lnd17cc8bda7ut0.

@FSM1 FSM1 requested review from Tbaut, tanmoyAtb and asnaith February 15, 2022 14:08
@github-actions github-actions bot added the Type: Feature Added to PRs to identify that the change is a new feature. label Feb 15, 2022
@FSM1 FSM1 self-assigned this Feb 15, 2022
@FSM1 FSM1 added the Status: Review Needed 👀 Added to PRs when they need more review label Feb 15, 2022
tanmoyAtb
tanmoyAtb approved these changes Feb 15, 2022
View reviewed changes
Copy link
Contributor

@tanmoyAtb tanmoyAtb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Having the tab conditionally rendered should do the trick without fiddling with the routes.

Tbaut
Tbaut reviewed Feb 15, 2022
View reviewed changes
Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a couple nits :)
Happy with not fiddling with the route either if it looks ok

packages/common-components/src/Tabs/Tabs.tsx Outdated Show resolved Hide resolved
packages/files-ui/src/Components/Modules/Settings/index.tsx Show resolved Hide resolved
packages/files-ui/src/Contexts/BillingContext.tsx Outdated Show resolved Hide resolved
@Tbaut Tbaut enabled auto-merge (squash) February 16, 2022 14:22
Tbaut
Tbaut approved these changes Feb 16, 2022
View reviewed changes
Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@Tbaut Tbaut merged commit e1701e7 into dev Feb 16, 2022
@Tbaut Tbaut deleted the feat/billing-soft-launch-1930 branch February 16, 2022 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanmoyAtb tanmoyAtb tanmoyAtb approved these changes

@Tbaut Tbaut Tbaut approved these changes

@asnaith asnaith Awaiting requested review from asnaith

Assignees

@FSM1 FSM1

Labels
Status: Review Needed 👀 Added to PRs when they need more review Type: Feature Added to PRs to identify that the change is a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Billing Soft Launch capability
4 participants
@FSM1 @tanmoyAtb @Tbaut @actions-user