Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove edit access user fix #1999

Merged
merged 3 commits into from
Mar 2, 2022
Merged

Remove edit access user fix #1999

merged 3 commits into from
Mar 2, 2022

Conversation

tanmoyAtb
Copy link
Contributor

closes #1997

Pointing this to the manage share refactor branch to avoid conflicts.

@github-actions github-actions bot added the Type: Bug Fix Added to PRs if they are addressing a bug label Mar 2, 2022
asnaith
asnaith approved these changes Mar 2, 2022
View reviewed changes
Copy link
Contributor

@asnaith asnaith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I tested this locally, the fix is working well 👍

@Tbaut
Copy link
Collaborator

Tbaut commented Mar 2, 2022

Oh and that's awesome because you did this on top of my PR already. Thank you so much :)

@Tbaut Tbaut merged commit 126f419 into fix/tbaut-address-overflow-1984 Mar 2, 2022
@Tbaut Tbaut deleted the fix/can-edit-delete-1997 branch March 2, 2022 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asnaith asnaith asnaith approved these changes

Assignees
No one assigned
Labels
Type: Bug Fix Added to PRs if they are addressing a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tanmoyAtb @Tbaut @asnaith