Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new session capability to storage tests #2045

Merged
merged 7 commits into from
Mar 31, 2022

Conversation

asnaith
Copy link
Contributor

@asnaith asnaith commented Mar 24, 2022

closes #2043

  • I just ported across the good work Thibaut had done for Files so we can use unique sessions for some tests (can help with CID pinning tests).

  • I've also stopped all uncaught exception errors from automatically failing tests (we made that change for Files a while back).

@asnaith asnaith added the Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes. label Mar 24, 2022
@asnaith asnaith requested review from tanmoyAtb, FSM1 and Tbaut March 24, 2022 22:36
@render
Copy link

render bot commented Mar 24, 2022

@render
Copy link

render bot commented Mar 24, 2022

@render
Copy link

render bot commented Mar 24, 2022

@asnaith
Copy link
Contributor Author

asnaith commented Mar 24, 2022

"Tested the tests" locally

metatest.mov

@asnaith asnaith enabled auto-merge (squash) March 25, 2022 17:23
Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@asnaith asnaith merged commit 27d5624 into dev Mar 31, 2022
@asnaith asnaith deleted the mnt/port-new-session-capability-2043 branch March 31, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port new session capability to storage tests
4 participants