-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pipeline for executing Storage on demand ui tests #2113
Conversation
Your Render PR Server URL is https://chainsafe-components-stage-pr-2113.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c9l9crirrk005kd9gbr0. |
Your Render PR Server URL is https://files-ui-stage-pr-2113.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c9l9csirrk005kd9gbvg. |
Your Render PR Server URL is https://storage-ui-stage-pr-2113.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c9l9ctirrk005kd9gch0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😃 @juans-chainsafe Nice work on the first PR :) 🚀
The configuration looks good. Lets make sure to run the job and ensure the slack notification works when this gets merged (it should be fine as very similar to the other on-demand config that we already know works well).
REACT_APP_FILES_VERIFIER_NAME: ${{ secrets.GH_REACT_APP_FILES_VERIFIER_NAME }} | ||
REACT_APP_FILES_UUID_VERIFIER_NAME: 'chainsafe-uuid-testnet' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is mostly a copy/past from the workflow for Files, but since I stumble upon this, I comment here.
I'm not sure exactly what those are used for. And whether or not we should keep the same id. Any clue @asnaith ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may have something to do with the Slack bot integration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from what I can see. No big issue in merging this and see if all goes well.
closes #2111
Submission checklist:
Created test-storage-on-demand.yml we will be able to see it once is in dev