Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline for executing Storage on demand ui tests #2113

Merged
merged 2 commits into from
May 3, 2022

Conversation

juans-chainsafe
Copy link
Contributor

closes #2111


Submission checklist:

Created test-storage-on-demand.yml we will be able to see it once is in dev

@juans-chainsafe juans-chainsafe added the Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes. label Apr 28, 2022
@render
Copy link

render bot commented Apr 28, 2022

@render
Copy link

render bot commented Apr 28, 2022

@render
Copy link

render bot commented Apr 28, 2022

@asnaith asnaith changed the title Pipeline for executing Storage on demand Pipeline for executing Storage on demand ui tests Apr 28, 2022
@CLAassistant
Copy link

CLAassistant commented Apr 28, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@asnaith asnaith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😃 @juans-chainsafe Nice work on the first PR :) 🚀

The configuration looks good. Lets make sure to run the job and ensure the slack notification works when this gets merged (it should be fine as very similar to the other on-demand config that we already know works well).

Comment on lines +28 to +29
REACT_APP_FILES_VERIFIER_NAME: ${{ secrets.GH_REACT_APP_FILES_VERIFIER_NAME }}
REACT_APP_FILES_UUID_VERIFIER_NAME: 'chainsafe-uuid-testnet'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is mostly a copy/past from the workflow for Files, but since I stumble upon this, I comment here.
I'm not sure exactly what those are used for. And whether or not we should keep the same id. Any clue @asnaith ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tbaut I'm not sure tbh, I myself took them from another job when creating the Files on-demand config 😅. Maybe @FSM1 has an idea what they are for? (If not needed we should remove it for clarity).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may have something to do with the Slack bot integration?

Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from what I can see. No big issue in merging this and see if all goes well.

@Tbaut Tbaut merged commit 15ac409 into dev May 3, 2022
@Tbaut Tbaut deleted the mtn/create-storage-on-demand-pipeline-2111 branch May 3, 2022 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create pipeline for executing storage ui tests on demand
6 participants