-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Right click on shared folder overview ans Storage bucket overview #2168
Conversation
Your Render PR Server URL is https://chainsafe-components-stage-pr-2168.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cafkd950mal94a1lt6m0. |
Your Render PR Server URL is https://files-ui-stage-pr-2168.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cafkda50mal94a1lt6qg. |
Your Render PR Server URL is https://storage-ui-stage-pr-2168.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cafkdbd0mal94a1lt7dg. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! the right click is working nice and clean.
I have a suggestion, maybe we can add a toast message when we delete a Shared folder or a Bucket to have the same behaviour that we have in Files in Home
yes I realized this as well, when testing, we need to add this. I'll create an issue for this since it's not related. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a clean implementation. working nicely.
Made me realise, we must add a "Confirmation dialogue" on storage before deleting buckets.
Deleting buckets is quite an impactful task.
Hehe yup, that's what Juan was saying, I created an issue :) |
closes #2153