-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
storage navigation refactor #2196
Conversation
Your Render PR Server URL is https://chainsafe-components-stage-pr-2196.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-caoadmj19n04h41ajf80. |
Your Render PR Server URL is https://files-ui-stage-pr-2196.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-caoado319n04h41ajfdg. |
Your Render PR Server URL is https://storage-ui-stage-pr-2196.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-caoadpj19n04h41ajfvg. |
The settings tests are failing. Going to add the updates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good. I have no strong opinion regarding the spacing, I'm undecided.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as Tbaut, I'm not so sure about the spacing, maybe @serenaho can help?
Regarding the changes, looks good! waiting for the fix of the tests to approve it
Included some options here on Figma! Options A, B, and C are pretty straightforward but options D and E have Docs and Billing separated as buttons because they don't quite fit under the category as a menu item like the others. Happy to discuss this during the planning meeting tmr :) |
This could be for another ticket but:
My suggestion would be all together but Docs at the bottom of the nav bar |
…i-monorepo into feat/storage-navigation-2091
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Subscription test were failing in Files, but was a problem with the API that was fixed, I rerun the tests and now they all passed.
Everything fine now! I guess we leave the spacing improvement for another ticket
closes #2091
We now have Api Keys and Billing nav items in place.
Settings are kept hidden.