[Storage] Allow renaming a bucket #2201
Conversation
|
Your Render PR Server URL is https://chainsafe-components-stage-pr-2201.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-caq889j19n0e1ep36dp0. |
|
Your Render PR Server URL is https://files-ui-stage-pr-2201.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-caq88ar19n0e1ep36dtg. |
|
Your Render PR Server URL is https://storage-ui-stage-pr-2201.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-caq88c319n0e1ep36ef0. |
|
it's ready to go now that https://github.com/ChainSafe/files-api/issues/2380 is in. |
There was a problem hiding this comment.
Great work! main functionality is working perfect, but I found some issues:
When you try to rename the bucket with an empty input,the dialog box is cut off in the screen:
Based on renaming an empty folder/file I think the box should say: "A name is required."
The second error, is when you try to rename the bucket with a bucket name that already exists, basically nothing happens, I see in the https://stage-api.chainsafe.io/api/v1/buckets/fef85ff2-23b1-4b53-bbf6-c83c022938ba API response that throw the error '...[E11000 duplicate key error collection...' so we have 2 possible solutions here:
- Show an error message that can't be renamed with an existing name
- Do the same that we do when renaming a folder: add '(1)' (or the corresponding number) at the end of the bucket name
Ah thanks for testing it, this is something that should be handled on the api level. I opened https://github.com/ChainSafe/files-api/issues/2500 I'll fix the other issue with the error |
|
The error message overflow is fixed now thanks for checking this out |
closes #2183