Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate account #834

Merged
merged 26 commits into from
Mar 28, 2021
Merged

Migrate account #834

merged 26 commits into from
Mar 28, 2021

Conversation

tanmoyAtb
Copy link
Contributor

closes #829

@render
Copy link

render bot commented Mar 23, 2021

@render
Copy link

render bot commented Mar 23, 2021

@render
Copy link

render bot commented Mar 23, 2021

@tanmoyAtb
Copy link
Contributor Author

Some instances where i'm confused and need clearing up

  • logout from encryption password screen should clear threshould key

  • submitting encryption password does not clear shouldInitializeAccount

  • refreshing the page after reaching migrate screen does not set shouldInitializeAccount to true on reload.

  • sidenote, on login with legacy account, MissingShares screen flashes for a bit

@tanmoyAtb tanmoyAtb requested review from FSM1, Tbaut and RyRy79261 March 23, 2021 19:59
@tanmoyAtb tanmoyAtb self-assigned this Mar 23, 2021
@tanmoyAtb tanmoyAtb added Status: Changes Requested ❌ Added to PRs that require further changes from the contributor. Status: Review Needed 👀 Added to PRs when they need more review labels Mar 23, 2021
@tanmoyAtb tanmoyAtb marked this pull request as ready for review March 23, 2021 19:59
@FSM1
Copy link
Contributor

FSM1 commented Mar 24, 2021

  • logout from encryption password screen should clear threshould key

Yeah that is correct. This will reset the tkey instance to a fresh one. There is a log out method exposed on tkey context that then cascades the logout to all the other layers

  • submitting encryption password does not clear shouldInitializeAccount

That needs to be rectified. Can probably call the setter just before returning from that submit function (inside the tkey context)

  • refreshing the page after reaching migrate screen does not set shouldInitializeAccount to true on reload.

This can be solved by adding another conditional for when the Migrate Account shoud be shown (isMasterPasswordSet && !secured)

  • sidenote, on login with legacy account, MissingShares screen flashes for a bit

Will need to do some digging. I actually need to create some accounts and test this flow out.

@tanmoyAtb tanmoyAtb removed the Status: Review Needed 👀 Added to PRs when they need more review label Mar 24, 2021
@tanmoyAtb tanmoyAtb added Status: Review Needed 👀 Added to PRs when they need more review and removed Status: Changes Requested ❌ Added to PRs that require further changes from the contributor. labels Mar 24, 2021
Copy link
Contributor

@FSM1 FSM1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments. Looking good overall

Copy link
Contributor

@FSM1 FSM1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some minor fixes

Copy link
Contributor

@FSM1 FSM1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @tanmoyAtb 🎉

Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a first fly-by, found some nits, I will test it now :)

@@ -14,6 +14,8 @@ export const ROUTE_LINKS = {
PrivacyPolicy: "https://files.chainsafe.io/privacy-policy",
Terms: "https://files.chainsafe.io/terms-of-service",
ChainSafe: "https://chainsafe.io/",
// TODO: update link
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm for creating an issue rather than adding this here, which we might ignore.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely better to have an issue

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added it #849

@tanmoyAtb tanmoyAtb requested a review from Tbaut March 26, 2021 15:53
Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works well!
I found 2/3 more nits:

  • the images are not aligned with the text, I show it for the first 2.
  • there's a space missing somehow after the link
  • I feel this modal should be a little bigger, so that it breathes a bit more (the mock design has it bigger)

image

@tanmoyAtb tanmoyAtb merged commit b1af868 into dev Mar 28, 2021
@tanmoyAtb tanmoyAtb deleted the feat/migrate-account-829 branch March 28, 2021 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Review Needed 👀 Added to PRs when they need more review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate legacy account
3 participants