-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate account #834
Migrate account #834
Conversation
Your Render PR Server URL is https://chainsafex-dev-pr-834.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c1cv9l5ua9vq4a1gnnu0. |
Your Render PR Server URL is https://files-ui-dev-pr-834.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c1cv9ldua9vq4a1gno3g. |
Your Render PR Server URL is https://files-landing-dev-pr-834.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c1cv9ltua9vq4a1gnomg. |
Some instances where i'm confused and need clearing up
|
Yeah that is correct. This will reset the tkey instance to a fresh one. There is a log out method exposed on tkey context that then cascades the logout to all the other layers
That needs to be rectified. Can probably call the setter just before returning from that submit function (inside the tkey context)
This can be solved by adding another conditional for when the Migrate Account shoud be shown (isMasterPasswordSet && !secured)
Will need to do some digging. I actually need to create some accounts and test this flow out. |
packages/files-ui/src/Components/Modules/LoginModule/MigrateAccount.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments. Looking good overall
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some minor fixes
packages/files-ui/src/Components/Modules/LoginModule/ConciseExplainer.tsx
Outdated
Show resolved
Hide resolved
packages/files-ui/src/Components/Modules/LoginModule/ConciseExplainer.tsx
Outdated
Show resolved
Hide resolved
…plainer.tsx Co-authored-by: Michael Yankelev <[email protected]>
…plainer.tsx Co-authored-by: Michael Yankelev <[email protected]>
…feat/migrate-account-829
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @tanmoyAtb 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a first fly-by, found some nits, I will test it now :)
packages/files-ui/src/Components/Modules/LoginModule/ConciseExplainer.tsx
Outdated
Show resolved
Hide resolved
packages/files-ui/src/Components/Modules/LoginModule/ConciseExplainer.tsx
Outdated
Show resolved
Hide resolved
packages/files-ui/src/Components/Modules/LoginModule/ConciseExplainer.tsx
Outdated
Show resolved
Hide resolved
packages/files-ui/src/Components/Modules/LoginModule/ConciseExplainer.tsx
Show resolved
Hide resolved
packages/files-ui/src/Components/Modules/LoginModule/ConciseExplainer.tsx
Outdated
Show resolved
Hide resolved
packages/files-ui/src/Components/Modules/LoginModule/MigrateAccount.tsx
Outdated
Show resolved
Hide resolved
@@ -14,6 +14,8 @@ export const ROUTE_LINKS = { | |||
PrivacyPolicy: "https://files.chainsafe.io/privacy-policy", | |||
Terms: "https://files.chainsafe.io/terms-of-service", | |||
ChainSafe: "https://chainsafe.io/", | |||
// TODO: update link |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm for creating an issue rather than adding this here, which we might ignore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely better to have an issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added it #849
…plainer.tsx Co-authored-by: Thibaut Sardan <[email protected]>
…count.tsx Co-authored-by: Thibaut Sardan <[email protected]>
…feat/migrate-account-829
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works well!
I found 2/3 more nits:
- the images are not aligned with the text, I show it for the first 2.
- there's a space missing somehow after the link
- I feel this modal should be a little bigger, so that it breathes a bit more (the mock design has it bigger)
closes #829