Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5596 Refactors #5

Merged
merged 5 commits into from
Nov 11, 2022
Merged

#5596 Refactors #5

merged 5 commits into from
Nov 11, 2022

Conversation

spacesailor24
Copy link
Contributor

This PR includes the code changes mentioned in my comment here

What This PR Does

  • Renames src/reexported_web3_objects.ts to src/reexported_web3_context.ts
    • This file only re-exports Web3Context now
  • Updates module augmentation done in src/chainlink_plugin.ts to only augment Web3Context
  • Updates Web3 module imports for the test

Copy link
Contributor

@Muhammad-Altabba Muhammad-Altabba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to augment only Web3Context.

However, did you try to use the plugin in a sample project? When I used this MR there is no intellisense for .chainlink.
image

So, I suggested the modifications in the comments below, in order to keep the following working:
image

@spacesailor24
Copy link
Contributor Author

@Muhammad-Altabba No I didn't test in a sample project, thank you for catching this!

I added the export { Web3Context }; you suggested and used the plugin in a sample project, and it seems to work as expected

image

spacesailor24 and others added 2 commits November 10, 2022 07:23
Co-authored-by: Muhammad Altabba <[email protected]>
Co-authored-by: Muhammad Altabba <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants