Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speech to text | Issue #21 #375

Merged
merged 5 commits into from
Oct 23, 2023
Merged

Conversation

mmnasser2000
Copy link
Contributor

No description provided.

@willydouhard
Copy link
Collaborator

Thank you for your contribution! Will review once we cut the auth release.

Copy link
Collaborator

@willydouhard willydouhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, there is a cursor problem that can be solved by wrapping the icons in a IconButton.

Also there is a new feature config. I think this should be configurable through that configuration.

Finally there are minor conflicts with the current main.

Thank you for your contribution!

@@ -105,6 +121,24 @@ const Input = ({ onSubmit, onReply }: Props) => {
</IconButton>
)}
<HistoryButton onClick={onHistoryClick} />
{browserSupportsSpeechRecognition &&
(isRecording ? (
<StopCircleIcon
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Icons should be wrapped in a IconButton (right now the cursor is incorrect)

@willydouhard
Copy link
Collaborator

let me know @mmnasser2000

@willydouhard
Copy link
Collaborator

Looks like there is a merge issue (this should not change 296 files)

@alimtunc alimtunc mentioned this pull request Oct 13, 2023
Requires checking for tests
Copy link
Collaborator

@willydouhard willydouhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Small comment on the config. Can you attach a small video demoing this new feature?

@@ -76,6 +76,9 @@
# The CSS file can be served from the public directory or via an external link.
# custom_css = "/public/test.css"

# Allows user to use speech to text
# speech_to_text = true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would put that config under features and not UI

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't have time to change that I can do it, let me know

@willydouhard
Copy link
Collaborator

Thank you for your contribution!

@willydouhard willydouhard merged commit 62192d9 into Chainlit:main Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants