-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speech to text | Issue #21 #375
Conversation
Thank you for your contribution! Will review once we cut the auth release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, there is a cursor problem that can be solved by wrapping the icons in a IconButton
.
Also there is a new feature config. I think this should be configurable through that configuration.
Finally there are minor conflicts with the current main.
Thank you for your contribution!
@@ -105,6 +121,24 @@ const Input = ({ onSubmit, onReply }: Props) => { | |||
</IconButton> | |||
)} | |||
<HistoryButton onClick={onHistoryClick} /> | |||
{browserSupportsSpeechRecognition && | |||
(isRecording ? ( | |||
<StopCircleIcon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Icons should be wrapped in a IconButton (right now the cursor is incorrect)
let me know @mmnasser2000 |
Looks like there is a merge issue (this should not change 296 files) |
Requires checking for tests
5c09774
to
1fc73f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! Small comment on the config. Can you attach a small video demoing this new feature?
backend/chainlit/config.py
Outdated
@@ -76,6 +76,9 @@ | |||
# The CSS file can be served from the public directory or via an external link. | |||
# custom_css = "/public/test.css" | |||
|
|||
# Allows user to use speech to text | |||
# speech_to_text = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would put that config under features and not UI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you don't have time to change that I can do it, let me know
Thank you for your contribution! |
No description provided.