Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean app #485

Merged
merged 23 commits into from
Oct 25, 2023
Merged

Clean app #485

merged 23 commits into from
Oct 25, 2023

Conversation

alimtunc
Copy link
Contributor

@alimtunc alimtunc commented Oct 17, 2023 •
edited
Loading

Goal of this PR is to improve the app performance doing :

  • - Clean warnings/Error
  • - Avoid frontend useless useEffects
  • - Split useChat hook
  • - Avoid useless re-render on messages
  • - Avoid useless re-render on input
  • - Check imports (Especially MUI and lodash)
  • - Refactor way messages handling
  • Known cleanable code :
    • HandleCompletion (Double fonction, same thing)
    • LLMProviders -> Should be in hook
    • Rest

@alimtunc alimtunc marked this pull request as draft October 17, 2023 15:16
@alimtunc alimtunc changed the title At/cha 429 improve app perf Clean app Oct 17, 2023
@alimtunc alimtunc force-pushed the at/CHA-429-improve-app-perf branch 6 times, most recently from db09a2b to 2ff9396 Compare October 18, 2023 16:26
@alimtunc alimtunc force-pushed the at/CHA-429-improve-app-perf branch 5 times, most recently from 42521c3 to a2af914 Compare October 23, 2023 14:53
@alimtunc alimtunc marked this pull request as ready for review October 23, 2023 15:12
willydouhard
willydouhard requested changes Oct 24, 2023
View reviewed changes
frontend/src/components/organisms/chat/Messages/container.tsx

const enableFeedback = !!projectSettings?.dataPersistence;

const navigate = useNavigate();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we get rid of this one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately... tried the 3 options of react-router and none of them worked.

frontend/src/components/organisms/chat/Messages/container.tsx Outdated Show resolved Hide resolved
libs/components/hooks/useChat/useChatSession.ts Outdated Show resolved Hide resolved
libs/components/src/messages/components/FeedbackButtons.tsx Outdated Show resolved Hide resolved
@alimtunc alimtunc force-pushed the at/CHA-429-improve-app-perf branch 2 times, most recently from 874c02e to 776a1d0 Compare October 24, 2023 13:39
@alimtunc alimtunc force-pushed the at/CHA-429-improve-app-perf branch 2 times, most recently from 510ae2c to 067ce51 Compare October 25, 2023 07:32
@alimtunc alimtunc force-pushed the at/CHA-429-improve-app-perf branch from 067ce51 to 1304c98 Compare October 25, 2023 07:39
@willydouhard willydouhard merged commit 300d372 into main Oct 25, 2023
6 checks passed
@willydouhard willydouhard deleted the at/CHA-429-improve-app-perf branch October 25, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willydouhard willydouhard willydouhard approved these changes

@tpatel tpatel Awaiting requested review from tpatel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alimtunc @willydouhard