Skip to content

Commit

Permalink
refactor: Remove unnecessary build args in example go app (runfinch#36)
Browse files Browse the repository at this point in the history
The removed args solved a common static linking problem in old versions
of go, per
golang/go#9344 (comment)

Signed-off-by: Alexander Else <[email protected]>

Issue #, if available:

*Description of changes:*

Remove build flags relating to old go versions from example go app

*Testing done:*

Built and ran container derived from updated code, using `finch build`
and `finch run`

- [ x ] I've reviewed the guidance in CONTRIBUTING.md


#### License Acceptance

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

Signed-off-by: Alexander Else <[email protected]>
Co-authored-by: Weike Qu <[email protected]>
  • Loading branch information
aelse and weikequ authored Nov 25, 2022
1 parent 2bb593c commit 0aa023a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion contrib/hello-finch/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ FROM public.ecr.aws/docker/library/golang:1.19 AS builder
WORKDIR /build
COPY . .

RUN CGO_ENABLED=0 go build -a -installsuffix cgo -ldflags '-extldflags "-static"' -o hello-finch .
RUN CGO_ENABLED=0 go build -a -o hello-finch .

FROM scratch
COPY --from=builder /build/hello-finch /app/
Expand Down

0 comments on commit 0aa023a

Please sign in to comment.