Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new contributing vote policies #137

Merged
merged 1 commit into from
May 24, 2017
Merged

new contributing vote policies #137

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,8 @@ merged in. If you do not wish for ChaosBot to consider your PR for merging just
yet, add "WIP" somewhere in your PR title. Remove it when you're ready for voting.

# Changing your PR
It is very important that you avoid updating your PR with new commits after it
has been created. The reason for this is that ChaosBot will only consider votes
that were cast **after** the last code change timestamp. So if you collect a
bunch of votes and PR, you have lost those votes.
You may change your PR at any time without losing votes, but keep in mind, any
new changes will reset the vote window for additional time.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do additional changes "reset" the voting or simply "extend" it?

Copy link
Contributor Author

@amoffat amoffat May 24, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resets the starting point that marks the beginning of the voting time. appears to be an extension though


# Merging your PR
At the end of the voting window, ChaosBot will review the votes, and if your PR
Expand Down