Fix PEP8 errors #248
Fix PEP8 errors #248
Conversation
|
In addition, it can cause conflicts, which will result in a new vote. |
Nah, that was fixed. |
|
Oh, you ruined my insidious attack on democracies. 😈 |
|
@chaosbot , there is no more conflicts. Stop lying. |
|
It caches that for a little while. It takes a couple minutes to update. |
| @@ -2,26 +2,34 @@ | |||
| import socketserver | |||
| import socket | |||
|
|
|||
| #set the process name to "chaos_server" so we can easily kill it with "pkill chaos_server" | |||
| # set the process name to "chaos_server" so we can easily kill it with | |||
| # "pkill chaos_server" | |||
There was a problem hiding this comment.
Instead of moving this further away from the function it's documenting, it should probably be made into a docstring.
|
Fixing Python source files for PEP8 compliance is chasing windmills unless some mechanism is in place for checking and/or fixing source files continously. It's hard just to merge PEP8 related fixes, and PEP8 issues will pop up again and again. |
|
#250 will make it easy enough to cause Chaos to stop redeploying if a linter fails if that's the direction we want to go. |
|
👍 for linting and checking in the modified source files automatically, if there are changes |
|
🙆♀️ PR passed with a vote of 11 for and 0 against, with a weighted total of 11.0 and a threshold of 6.2. See merge-commit 551a379 for more details. |
This fixes some of the PEP8 compliance errors.