Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve fil-deal-ingester error handling #41

Merged
merged 5 commits into from
Jan 16, 2025
Merged

Improve fil-deal-ingester error handling #41

merged 5 commits into from
Jan 16, 2025

Conversation

pyropy
Copy link
Contributor

@pyropy pyropy commented Jan 15, 2025 •
edited
Loading

This PR adds anyhow create to handle errors propagation and asserts

Related to #31
Loosely related to #23

@pyropy pyropy changed the title Feat/improve error handling Improve error handling Jan 15, 2025
@pyropy pyropy mentioned this pull request Jan 15, 2025
Merged
@pyropy pyropy self-assigned this Jan 15, 2025
@pyropy pyropy marked this pull request as ready for review January 15, 2025 15:34
@pyropy pyropy changed the title Improve error handling Improve fil-deal-ingester error handling Jan 15, 2025
bajtos
bajtos approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩

@pyropy pyropy merged commit fed4c33 into main Jan 16, 2025
5 checks passed
@pyropy pyropy deleted the feat/improve-error-handling branch January 16, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bajtos bajtos bajtos approved these changes

@NikolasHaimerl NikolasHaimerl Awaiting requested review from NikolasHaimerl NikolasHaimerl is a code owner

Assignees

@pyropy pyropy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pyropy @bajtos