Add HEAD request. #104 #109
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bajtos
requested changes
Feb 17, 2025
This comment was marked as outdated.
This comment was marked as outdated.
bajtos
reviewed
Feb 19, 2025
| const stats = {} | ||
| await spark.testHeadRequest('/dns/frisbii.fly.dev/tcp/443/https', KNOWN_CID, stats) | ||
| assertEquals(stats.headStatusCode, 200) | ||
| assertEquals(requests, [{ url: `https://frisbii.fly.dev/ipfs/${KNOWN_CID}?dag-scope=block`, method: 'HEAD' }]) |
There was a problem hiding this comment.
Have you considered the feedback in CheckerNetwork/frisbii-on-fly#3 (comment)?
Once fixed, you may want to test with explicit content type:
HEAD /ipfs/cid?format=raw+ passAccept: application/vnd.ipld.rawto ensure your requested trustless block responses and avoid issues if the other end supports deserialized responses as well.There is a risk of false positive if deserialized response happens to fit in a single block, so choosing CID of a chunked data may be a good idea.
Should we implement this suggestion as part of the work adding HEAD request checking to Spark? If not, can you create a follow-up issue please?
Co-authored-by: Miroslav Bajtoš <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #104
Next: Integrate into spark-api. This is not blocking, as submitting the measurements also already works with the new property -> CheckerNetwork/spark-api#521