Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude __esModule from esm wrapper #1538

Merged
merged 1 commit into from
Jun 11, 2021

Conversation

bjornstar
Copy link
Contributor

I'm pretty sure gen-esm-wrapper should automatically exclude __esModule but at least it gives us a way to do it without updating the library.

Fixes #1537

@bjornstar
Copy link
Contributor Author

[email protected] has a fix for this issue. I can update this PR to use the new version instead.

@bjornstar
Copy link
Contributor Author

PR updated, would love to get a fixed release out.

@bd82 bd82 merged commit a5e5598 into Chevrotain:master Jun 11, 2021
@bd82 bd82 changed the title Exclude __esModule from esm wrapper Exclude __esModule from esm wrapper Jun 12, 2021
@bjornstar bjornstar deleted the exclude-esmodule branch June 13, 2021 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

esm bundle: the export name "__esModule" is reserved and cannot be used
2 participants