Fix of the default prefix @mention that was no longer responding to commands #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The @mention prefix will always be followed by a space since it's a mention. Meaning this space is part of the prefix ! So need to add into counter the > character and the space, so 2 characters
brandonfl
changed the title
3 tasks
|
Nevermind, had a wrong master branch selected This PR should fix it |
freya022
reviewed
Dec 21, 2021
command/src/main/java/com/jagrosh/jdautilities/command/impl/CommandClientImpl.java
Show resolved
Hide resolved
Chew
approved these changes
Dec 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Pull Request Checklist
Please follow the following steps before opening this PR.
PRs that do not complete the checklist will be subject to denial for
missing information.
or merged features/bug fixes.
Pull Request Information
Check and fill in the blanks for all that apply:
______module of the JDA-Utilities library.______.Description
Fix the bug #39 introduced in pr #13
The default @mention prefix will always be followed by a space since it's a mention.
Meaning this space is part of the prefix !
So need to add into counter the
>character and the space, so 2 charactersas the
makeMessagePartsusesubstring(prefixLength, i)it detect the whitespace as the command and the real command as the argument...Related code :
makeMessageParts into CommandClientImpl.java lines 739-L752