Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "use rust types for RecentChainData, ProofBlockHeader and WeightProof" #17738 #18231

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Revert "use rust types for RecentChainData, ProofBlockHeader and WeightProof" #17738 #18231

merged 1 commit into from
Jun 21, 2024

Conversation

emlowe
Copy link
Contributor

@emlowe emlowe commented Jun 21, 2024 •
edited
Loading

PR 17738 introduced some rust types for the weight proofs including

ProofBlockHeader = chia_rs.ProofBlockHeader
RecentChainData = chia_rs.RecentChainData
SubEpochData = chia_rs.SubEpochData
WeightProof = chia_rs.WeightProof

On some (perhaps a majority) of systems this change resulted in a substantial performance regression when using wallet-only mode. Typically wallet would either time out while syncing, or sync very slowly - also wallet would typically start to ban peers due to unexpected timeouts.

This PR reverts this change which was isolated to a single file and in internal testing does result in wallet-only (light-wallet) syncing performance to return to 2.3.1 expected norms.

@emlowe emlowe added the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label Jun 21, 2024
wjblanke
wjblanke approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok

@emlowe emlowe changed the title Revert 17738 Revert "use rust types for RecentChainData, ProofBlockHeader and WeightProof" #17738 Jun 21, 2024
@emlowe emlowe marked this pull request as ready for review June 21, 2024 20:23
@emlowe emlowe requested a review from a team as a code owner June 21, 2024 20:23
@emlowe emlowe requested a review from arvidn June 21, 2024 20:28
@cmmarslender cmmarslender merged commit 4b2f9f0 into release/2.4.1 Jun 21, 2024
992 of 993 checks passed
@cmmarslender cmmarslender deleted the EL.revert-17738 branch June 21, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjblanke wjblanke wjblanke approved these changes

@arvidn arvidn Awaiting requested review from arvidn

Assignees
No one assigned
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emlowe @wjblanke @cmmarslender