Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CHIA-883] Fix duplicate connection log spam. #18268

Merged
merged 2 commits into from
Jul 5, 2024
Merged

[CHIA-883] Fix duplicate connection log spam. #18268

merged 2 commits into from
Jul 5, 2024

Conversation

fchirica
Copy link
Contributor

@fchirica fchirica commented Jul 3, 2024

Purpose:

Current Behavior:

New Behavior:

Testing Notes:

@fchirica fchirica requested a review from a team as a code owner July 3, 2024 00:30
@fchirica fchirica added the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label Jul 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 3, 2024

File Coverage Missing Lines
chia/server/start_service.py 50.0% lines 181
Total Missing Coverage
2 lines Unknown 50%

@emlowe emlowe linked an issue Jul 3, 2024 that may be closed by this pull request
[Bug] Node discovery / connect_peers_task_handler does not stop attempting already established connection #17619
Closed
emlowe
emlowe approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@emlowe emlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - coverage exemption

@Starttoaster Starttoaster merged commit 25154a1 into main Jul 5, 2024
369 of 370 checks passed
@Starttoaster Starttoaster deleted the fc.fix_connection_log_spam branch July 5, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emlowe emlowe emlowe approved these changes

Assignees
No one assigned
Labels
coverage-diff Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Node discovery / connect_peers_task_handler does not stop attempting already established connection
3 participants
@fchirica @emlowe @Starttoaster