-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHIA-1198 Add an end to end test for mempool bundle fill rate and the resulting block validation #18509
CHIA-1198 Add an end to end test for mempool bundle fill rate and the resulting block validation #18509
Conversation
e30d922
to
f98698a
Compare
fb5d26e
to
6db8957
Compare
6db8957
to
787fd39
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. would you mind adding a comment to the custom cost limit you set, explaining why you pick that specific number?
Also, is there a way to assert the cost of the block as well? I expect it to be different from the transaction cost, but it would be good to have the test ensure it doesn't change
787fd39
to
60b1c06
Compare
I added a comment to explain the custom cost limit. As to getting the block cost, I issued a |
60b1c06
to
50f636b
Compare
50f636b
to
8f5dce3
Compare
… block validation.
8f5dce3
to
7664fc9
Compare
We try to create a mempool bundle with the maximum fill rate possible and ensure the resulting block would still pass block validation.