delete chia/simulator/simulator_constants.py
#19037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the keychain seems unneeded, it might be wrong given the 'new consensus' comment, and it prints a python literal not a hex string or somesuch. and it uses the `DEFAULT_ROOT_PATH` global i'm trying to get rid of. oh, plus it's a directly runnable file that ought to be available via some `chia` subcommand instead, if it sticks around.
altendky
added
the
Changed
emlowe
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
the keychain seems unneeded, it might be wrong given the 'new consensus' comment, and it prints a python literal not a hex string or somesuch. and it uses the
DEFAULT_ROOT_PATHglobal i'm trying to get rid of. oh, plus it's a directly runnable file that ought to be available via somechiasubcommand instead, if it sticks around.Current Behavior:
New Behavior:
Testing Notes: