Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHIA-2264] Add config constant support to chia db validate #19182

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

Quexington
Copy link
Contributor

This change is in response to #19172 and addresses the ability to run db validation on testnet DBs.

@Quexington Quexington requested a review from arvidn January 24, 2025 21:17
@Quexington Quexington marked this pull request as ready for review January 24, 2025 21:17
@Quexington Quexington requested a review from a team as a code owner January 24, 2025 21:17
@Quexington Quexington added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Added Required label for PR that categorizes merge commit message as "Added" for changelog and removed Changed Required label for PR that categorizes merge commit message as "Changed" for changelog labels Jan 24, 2025
Copy link
Contributor

File Coverage Missing Lines
chia/cmds/db_validate_func.py 58.3% lines 21, 23-25, 29
Total Missing Coverage
23 lines 5 lines 78%

Copy link

Pull Request Test Coverage Report for Build 12957767078

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 18 of 23 (78.26%) changed or added relevant lines in 2 files are covered.
  • 24 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+0.02%) to 91.534%

Changes Missing Coverage Covered Lines Changed/Added Lines %
chia/cmds/db_validate_func.py 7 12 58.33%
Files with Coverage Reduction New Missed Lines %
chia/_tests/simulation/test_simulation.py 1 96.45%
chia/wallet/util/wallet_sync_utils.py 1 86.14%
chia/plotters/plotters.py 1 90.94%
chia/_tests/core/util/test_file_keyring_synchronization.py 1 96.88%
chia/timelord/timelord.py 2 79.61%
chia/server/node_discovery.py 2 81.5%
chia/consensus/blockchain.py 2 94.14%
chia/wallet/wallet_node.py 3 88.18%
chia/full_node/full_node.py 5 86.54%
chia/plotters/madmax.py 6 44.58%
Totals Coverage Status
Change from base Build 12894248841: 0.02%
Covered Lines: 105351
Relevant Lines: 114919

💛 - Coveralls

chia/cmds/db_validate_func.py Show resolved Hide resolved
@Quexington Quexington added the ready_to_merge Submitter and reviewers think this is ready label Jan 28, 2025
@pmaslana pmaslana merged commit 2d53b46 into main Jan 28, 2025
366 of 368 checks passed
@pmaslana pmaslana deleted the quex.config_for_db_validate branch January 28, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Added Required label for PR that categorizes merge commit message as "Added" for changelog ready_to_merge Submitter and reviewers think this is ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants