create_block_generator refactor
#19207
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvidn
force-pushed
the
create_block_generator
branch
from
f4c2342 to
6909222
Compare
arvidn
added
the
Changed
arvidn
force-pushed
the
create_block_generator
branch
from
6909222 to
3d9f473
Compare
AmineKhaldi
reviewed
Feb 5, 2025
Comment on lines
3212
to
3213
| for add in additions: | ||
| assert add in expected_additions | ||
|
|
There was a problem hiding this comment.
We're checking the length as well, so here we can simply:
Suggested change
| for add in additions: | |
| assert add in expected_additions | |
| assert set(additions) == expected_additions |
Comment on lines
+502
to
+509
| spends = [(cs.coin, bytes(cs.puzzle_reveal), bytes(cs.solution)) for cs in spend_bundle.coin_spends] | ||
| block_program = solution_generator_backrefs(spends) | ||
|
|
||
| duration = monotonic() - start_time | ||
| log.log( | ||
| logging.INFO if duration < 1 else logging.WARNING, | ||
| f"serializing block generator took {duration:0.2f} seconds", | ||
| ) |
There was a problem hiding this comment.
If we want to continue measuring the block generator serialization duration accurately, we need to keep using simple_solution_generator_backrefs here.
There was a problem hiding this comment.
The current behavior tracks the duration of calling simple_solution_generator_backrefs which contains the deserialization step and the construction of BlockGenerator, but with this, we're tracking the duration of one less step which got moved to the return step: BlockGenerator(SerializedProgram.from_bytes(block_program), []).
arvidn
force-pushed
the
create_block_generator
branch
from
3d9f473 to
f225f82
Compare
AmineKhaldi
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is best reviewed one commit at a time.
Purpose:
Change the mempool interface to create a block generator, rather than a large spend bundle (to then be turned into a block generator)
The main reason for this is to prepare for changing the implementation of the block generator creation to use an incrementally compressed block creator, to fill block more effectively.
It has some other benefits I think:
full_node_api, and probably requires a full simulation environment.The first commit is only tangentially related, and simplifies the function interface related to mempool item inclusion.
Current Behavior:
The mempool has a method:
create_bundle_from_mempool_items()New Behavior:
The mempool has a method:
create_block_generator